glusterfs.git/api, branch release-3.11

gfapi: Duplicate the buffer sent in setxattr calls

2017-08-12T13:42:27+00:00

Issue:
The caller of glfs_setxattr sends a buffer to set as the value.
We create a dict in which the pointer to the value is set.
Underlying layers like md-cache take a ref on this dict to store
the value for a longer time. But the moment setxattr is complete,
the caller of glfs_setxattr can free the value memory.

Solution:
memcpy the setxattr value to the gluster buffer.

> Reviewed-on: https://review.gluster.org/17967
> Reviewed-by: soumya k 
> Smoke: Gluster Build System 
> CentOS-regression: Gluster Build System 
> Reviewed-by: Jeff Darcy 
> (cherry picked from commit e11296f8e52b7e3b13d21b41d4fa34baea878edf)

Change-Id: I58753fe702e8b7d0f6c4f058714c65d0ad5d7a0a
BUG: 1479656
Signed-off-by: Poornima G 
Reviewed-on: https://review.gluster.org/18002
Smoke: Gluster Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Shyamsundar Ranganathan

gfapi: change root lookup from nameless to named lookup

2017-07-06T14:04:34+00:00

Problem:

During component resolve we do lookup on root based on
root gfid. If we are doing nameless lookup, then md-cache
won't be able to serve those lookup.

Solution:

With this patch, we covert nameless lookup to named lookup
on root.

Credits: Poornima G 

backport of>
>Change-Id: Ie64141936fd294d8969c39e3bd4dbc73ee375c6b
>BUG: 1458768
>Signed-off-by: Mohammed Rafi KC 
>Reviewed-on: https://review.gluster.org/17465
>Smoke: Gluster Build System 
>CentOS-regression: Gluster Build System 
>NetBSD-regression: NetBSD Build System 
>Reviewed-by: Niels de Vos 

Change-Id: Ie64141936fd294d8969c39e3bd4dbc73ee375c6b
BUG: 1463528
Signed-off-by: Mohammed Rafi KC 
Reviewed-on: https://review.gluster.org/17590
Smoke: Gluster Build System 
Tested-by: Shyamsundar Ranganathan 
CentOS-regression: Gluster Build System 
Reviewed-by: Shyamsundar Ranganathan

gfapi: fix handling of dot and double dot in path

2017-07-05T14:12:27+00:00

This patch is to handle "." and ".." in file path. Which means
this special dentry names will be resolved before sending fops
on the path.

Backport of>
>Change-Id: I5e92f6d1ad1412bf432eb2488e53fb7731edb013
>BUG: 1447266
>Signed-off-by: Mohammed Rafi KC 
>Reviewed-on: https://review.gluster.org/17177
>Smoke: Gluster Build System 
>Reviewed-by: Niels de Vos 
>CentOS-regression: Gluster Build System 
>NetBSD-regression: NetBSD Build System 
>Reviewed-by: Jeff Darcy 

Change-Id: I5e92f6d1ad1412bf432eb2488e53fb7731edb013
BUG: 1463528
Signed-off-by: Mohammed Rafi KC 
Reviewed-on: https://review.gluster.org/17237
Smoke: Gluster Build System 
Tested-by: Shyamsundar Ranganathan 
CentOS-regression: Gluster Build System 
Reviewed-by: Shyamsundar Ranganathan

gfapi: Fix few severe coverity issues

2017-05-07T15:34:01+00:00

From https://download.gluster.org/pub/gluster/glusterfs/static-analysis/master/glusterfs-coverity/2017-05-03-6484558c/html/
fixes coverity#189, 248, 250, 488, 546

This is backport of below mainline fix -
- https://review.gluster.org/17161

>Change-Id: I7c4aa5bf6c367344602748dfd736de27f341cca2
>BUG: 789278
>Signed-off-by: Soumya Koduri 
>Reviewed-on: https://review.gluster.org/17161
>Smoke: Gluster Build System 
>Reviewed-by: Niels de Vos 
>NetBSD-regression: NetBSD Build System 
>Reviewed-by: Amar Tumballi 
>CentOS-regression: Gluster Build System 
>(cherry picked from commit fa10c8a3528b95dc575bfedd30bcd68cc2dff25b)

Change-Id: I7c4aa5bf6c367344602748dfd736de27f341cca2
BUG: 1447571
Signed-off-by: Soumya Koduri 
Reviewed-on: https://review.gluster.org/17194
Reviewed-by: Niels de Vos 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Smoke: Gluster Build System

gfapi/handleops: Introducing glfs_xreaddirplus_r() fop for handleops

2017-05-05T11:12:48+00:00

Its known that readdirplus operation fetches stat as well for each of the
dirents. But often applications may need extra information, like for eg.,
NFS-Ganesha which operates on handles needs handles for each of those
dirents returned. So this would require extra calls to the backend, in this
case LOOKUP (which is very expensive operation) resulting in very low
readdir performance.

To address that introducing this new API using which applications can
make request for any extra information to be returned as part of
readdirplus response.

Currently this new api returns stat and handles as demanded by application.
The synopsis of the API is noted in glfs.h.

@todo:
* Enhance test script using this new API

Below were the perf results on single brick volume with and without
these changes -

Dataset used -
10*100 directories and each directory containing 100 empty files.

I used NFS-Ganesha application to test these changes -
>for i in {1..5}; do systemctl restart nfs-ganesha; sleep 10; mount -t nfs -o vers=4 localhost:/brick_vol /mnt; cd /mnt; echo "ITERATION$i"; date; find . > tmp-nfs.log; date; cd /; umount /mnt; sleep 2; done;

Without these changes -
ITERATION1
Mon Mar 20 17:22:26 IST 2017
Mon Mar 20 17:23:18 IST 2017
ITERATION2
Mon Mar 20 17:23:39 IST 2017
Mon Mar 20 17:24:28 IST 2017
ITERATION3
Mon Mar 20 17:24:49 IST 2017
Mon Mar 20 17:25:36 IST 2017
ITERATION4
Mon Mar 20 17:30:57 IST 2017
Mon Mar 20 17:31:37 IST 2017
ITERATION5
Mon Mar 20 17:31:57 IST 2017
Mon Mar 20 17:32:40 IST 2017
[root@dhcp35-197 /]#

On an average ~46.2 sec

With these changes applied -
ITERATION1
Mon Mar 20 17:35:03 IST 2017
Mon Mar 20 17:35:15 IST 2017
ITERATION2
Mon Mar 20 17:35:36 IST 2017
Mon Mar 20 17:35:46 IST 2017
ITERATION3
Mon Mar 20 17:36:06 IST 2017
Mon Mar 20 17:36:17 IST 2017
ITERATION4
Mon Mar 20 17:41:38 IST 2017
Mon Mar 20 17:41:49 IST 2017
ITERATION5
Mon Mar 20 17:42:10 IST 2017
Mon Mar 20 17:42:20 IST 2017

On an average ~10.8 sec

This is backport of below upstream patch -
        https://review.gluster.org/15663

>Updates #174
>BUG: 1442950
>Change-Id: I0f74f74dc62085ca4c4a23c38e3edc84bd850876
>Signed-off-by: Soumya Koduri 
>Reviewed-on: https://review.gluster.org/15663
>Smoke: Gluster Build System 
>NetBSD-regression: NetBSD Build System 
>Reviewed-by: Niels de Vos 
>CentOS-regression: Gluster Build System 

BUG: 1447571
Change-Id: I0f74f74dc62085ca4c4a23c38e3edc84bd850876
Signed-off-by: Soumya Koduri 
Reviewed-on: https://review.gluster.org/17164
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Niels de Vos

libgfapi: remove/revert glfs_ipc() changes targeted for 4.0

2017-05-03T12:32:50+00:00

revert glfs_ipc() to 3.7.0 signature and associated symbol versioning

Cherry picked from commit e549df2c0d8b5dbfa6e9c129109185aaf4cea11d:
> Change-Id: Ieffe1d966234652091a4a9ae0b2c4b23f1297147
> BUG: 1415279
> Signed-off-by: Kaleb S. KEITHLEY 
> Reviewed-on: https://review.gluster.org/16450
> Smoke: Gluster Build System 
> Reviewed-by: Shyamsundar Ranganathan 
> NetBSD-regression: NetBSD Build System 
> CentOS-regression: Gluster Build System 

Change-Id: Ieffe1d966234652091a4a9ae0b2c4b23f1297147
BUG: 1447543
Signed-off-by: Kaushal M 
Reviewed-on: https://review.gluster.org/17153
Smoke: Gluster Build System 
Reviewed-by: Niels de Vos 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System

api: fix two typos of GFAPI_PUBLIC function define

2017-04-29T12:55:43+00:00

Change-Id: I2f9915b3572c4cbce6748e99a037daba439a187e
BUG: 1446273
Signed-off-by: Kinglong Mee 
Reviewed-on: https://review.gluster.org/17112
Reviewed-by: Niels de Vos 
Smoke: Gluster Build System 
CentOS-regression: Gluster Build System 
NetBSD-regression: NetBSD Build System

api: free the xattr data after using in glfs_volfile_fetch

2017-04-26T14:57:01+00:00

Change-Id: I89a7df93039e367301fd70df722c13f1d8b3484b
Signed-off-by: Kinglong Mee 
Reviewed-on: https://review.gluster.org/17091
Smoke: Gluster Build System 
Reviewed-by: Prashanth Pai 
Reviewed-by: Poornima G 
Tested-by: Poornima G 
Reviewed-by: Amar Tumballi 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Jeff Darcy

api: fix bad release of dict causes memory leak

2017-04-25T15:04:09+00:00

Change-Id: Ic7169fd05aff7bf46108e8ac7b1f29688a7f2358
Signed-off-by: Kinglong Mee 
Reviewed-on: https://review.gluster.org/17092
Tested-by: Poornima G 
Reviewed-by: Poornima G 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Prashanth Pai 
Smoke: Gluster Build System 
Reviewed-by: Amar Tumballi

api: free all dynamic memory returned from xdr_to_generic

2017-04-21T20:08:02+00:00

Change-Id: I01235ffca80683e69e99da09a9fc1a6d3ffdcb65
Signed-off-by: Kinglong Mee 
Reviewed-on: https://review.gluster.org/17090
Tested-by: Poornima G 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Jeff Darcy 
Smoke: Gluster Build System