glusterfs.git/api/src, branch v3.7.3

syncop: Include iatt to 'syncop_link' args

2015-07-15T15:08:30+00:00

Include iatt to 'syncop_link' args to fetch proper attributes of
the newly linked inode.

This is backport of the below fix -
http://review.gluster.org/11611

Change-Id: If6b92961bd7a89add3791ed3a9b494087348b492
BUG: 1243408
Reviewed-on: http://review.gluster.org/11611
Reviewed-by: Shyamsundar Ranganathan 
Reviewed-by: Kaleb KEITHLEY 
Signed-off-by: Soumya Koduri 
Reviewed-on: http://review.gluster.org/11677
Tested-by: Gluster Build System

gfapi: Update loc->inode accordingly in 'glfs_loc_link'

2015-07-10T10:06:48+00:00

In case if the inode already exits in the cache, inode_link
returns the pointer to the exiting one instead of using loc->inode.
This will result in issues if that invalid inodei(loc->inode) is referenced
further. Fixed the same.

This is backport of the below fix -
http://review.gluster.org/#/c/11572/

BUG: 1241666
Change-Id: I1a89932397f7d2b70d619eeaf862c0a5d7f6b91c
Signed-off-by: Soumya Koduri 
Reviewed-on: http://review.gluster.org/11572
Reviewed-by: Kaleb KEITHLEY 
Reviewed-by: Shyamsundar Ranganathan 
Reviewed-on: http://review.gluster.org/11606
Tested-by: Gluster Build System

libgfapi: send explicit lookups on inodes linked in readdirp

2015-07-06T15:14:02+00:00

          Backport of http://review.gluster.org/11236

If the inode is linked via readdirp, then the consuners of gfapi which are using
handles (got either in lookup or readdirp) might not send an explicit lookup on
that object again (ex: NFS, samba, USS). If there is a replicate volume where
the replicas of the object are not in sync, then readdirp followed by fops might
lead data being served from the subvolume which is not in sync with latest
data. And since lookup is needed to trigger self-heal on that object the
consumers might keep getting wrong data until an explicit lookup is not done.

Fuse handles this situation by sending an explicit lookup by itself (fuse
xlator) on those inodes which are linked via readdirp, whenever a fop comes on
that inode.

The same procedure is done in gfapi as well to address this situation.

Thanks to shyam(srangana@redhat.com) for valuable inputs

Change-Id: I4230fae8e0b01a95c056282b08ed30832d4804a7
BUG: 1240190
Signed-off-by: Raghavendra Bhat 
Reviewed-on: http://review.gluster.org/11545
Tested-by: NetBSD Build System 
Tested-by: Gluster Build System 
Reviewed-by: Shyamsundar Ranganathan 
Reviewed-by: Niels de Vos

gfapi : symlink resolution for glfs_object

2015-06-28T07:53:27+00:00

Generally posix expects symlink should be resolved, before performing an
acl related operation. This patch introduces a new api glfs_h_resolve_symlink()
which will do the same.

backport of http://review.gluster.org/#/c/11410/1

>Change-Id: Ieee645154455a732edfb2c28834021bab4248810
>BUG: 1209735
>Signed-off-by: Jiffin Tony Thottan 

Change-Id: I13a83f37a9e59418fd8eb4bf2d44f828515beabf
BUG: 1236269
Signed-off-by: Jiffin Tony Thottan 
Reviewed-on: http://review.gluster.org/11438
Reviewed-by: Niels de Vos 
Tested-by: NetBSD Build System 
Tested-by: Gluster Build System

libgfapi: introduce bit flags for pthread mutex and cond variables

2015-06-22T09:36:24+00:00

At present stage, the initialization and destroy of conditional
and mutex variables of glfs struct happen in different places and
there is no uniform way of destroying these variables incase
there is a failure when initializing these. The fs mutex and
conditional variables are getting destroyed from glfs_free_from_ctx().
However this destroy is not done by a conditional check inside destroy
function. By introducing bit flags in glfs object, we can make use of the
same (if there is a failure in initialization) in glfs_fini()
which is evolving as one and only function to free fs and ctx resources.
This patch introduce the flags field and set the flags according
to the initialization flow of the mutex and conditional variables
of struct glfs members. Without this patch we are compelled to use
the goto lables and other hacks in init functions to make sure
the resources are freed if there is an error path.

Change-Id: I86e2719fb7ce437419a05699b4f06c14b02d0e69
BUG: 1233651
Signed-off-by: Humble Devassy Chirammal 
Signed-off-by: Poornima G 
Reviewed-on: http://review.gluster.org/10120
Reviewed-by: Niels de Vos 
Tested-by: Gluster Build System 
Tested-by: NetBSD Build System
Reviewed-by: Shyamsundar Ranganathan 
(cherry picked from commit bc858473db1e1091b15d3f3d69ac6ba5d20b58e7)
Reviewed-on: http://review.gluster.org/10971
Tested-by: NetBSD Build System 
Reviewed-by: Kaleb KEITHLEY

gfapi: zero size issue in glfs_h_acl_set()

2015-06-01T09:20:23+00:00

When setting the stringified ACLs in the xattr dict through
pub_glfs_h_setxattrs(), the size of the string is always passed as 0.
The correct way is to pass the length of the ACL in text form.

Backport of:
> Change-Id: Ia7a7fa1f3a7d615a813c703057dc97b09a0bbb34
> BUG: 789278
> Reviewd-on: http://review.gluster.org/10782
> Signed-off-by: Jiffin Tony Thottan 

Change-Id: Ia7a7fa1f3a7d615a813c703057dc97b09a0bbb34
BUG: 1224241
Signed-off-by: Niels de Vos 
Reviewed-on: http://review.gluster.org/10890
Tested-by: Gluster Build System 
Reviewed-by: Shyamsundar Ranganathan

gfapi: fix compile warning in pub_glfs_h_access()

2015-05-09T22:52:08+00:00

While compiling libgfapi, the following warning is reported:

    Making all in src
      CC       libgfapi_la-glfs-handleops.lo
    In file included from glfs-handleops.c:12:0:
    glfs-handleops.c: In function 'pub_glfs_h_access':
    glfs-internal.h:216:14: warning: 'old_THIS' may be used uninitialized in this function [-Wmaybe-uninitialized]
             THIS = old_THIS;                                            \
                  ^
    glfs-internal.h:202:36: note: 'old_THIS' was declared here
     #define DECLARE_OLD_THIS xlator_t *old_THIS = NULL
                                        ^
    glfs-handleops.c:1159:2: note: in expansion of macro 'DECLARE_OLD_THIS'
      DECLARE_OLD_THIS;
      ^
      CCLD     libgfapi.la
      CCLD     api.la

The DECLARE_OLD_THIS macro should be done with the declarations of all
the other variables used in this function. Moving the macro further up
in the function prevents this warning.

Backport of:
> Change-Id: I2bedc1aa074893ae3e2c933abc5a167ab5b55f41
> BUG: 1210934
> Reviewed-on: http://review.gluster.org/10728
> Reported-by: Shyamsundar Ranganathan 
> Signed-off-by: Niels de Vos 

Change-Id: I2bedc1aa074893ae3e2c933abc5a167ab5b55f41
BUG: 1215787
Signed-off-by: Niels de Vos 
Reviewed-on: http://review.gluster.org/10730
Reviewed-by: Shyamsundar Ranganathan 
Tested-by: Gluster Build System

core: use reference counting for mem_acct structures

2015-05-09T21:27:36+00:00

When freeing memory, our memory-accounting code expects to be able to
dereference from the (previously) allocated block to its owning
translator.  However, as we have already found once in option
validation and twice in logging, that translator might itself have
been freed and the dereference attempt causes on of our daemons to
crash with SIGSEGV.  This patch attempts to fix that as follows:

 * We no longer embed a struct mem_acct directly in a struct xlator,
   but instead allocate it separately.

 * Allocated memory blocks now contain a pointer to the mem_acct
   instead of the xlator.

 * The mem_acct structure contains a reference count, manipulated in
   both the normal and translator allocate/free code using atomic
   increments and decrements.

 * Because it's now a separate structure, we can defer freeing the
   mem_acct until its reference count reaches zero (either way).

 * Some unit tests were disabled, because they embedded their own
   copies of the implementation for what they were supposedly testing.
   Life's too short to spend time fixing tests that seem designed to
   impede progress by requiring a certain implementation as well as
   behavior.

Change-Id: Id929b11387927136f78626901729296b6c0d0fd7
BUG: 1219026
Signed-off-by: Jeff Darcy 
Reviewed-on: http://review.gluster.org/10417
Tested-by: Gluster Build System 
Reviewed-by: Krishnan Parthasarathi 
Reviewed-by: Niels de Vos 
Reviewed-by: Pranith Kumar Karampuri 
Reviewed-on: http://review.gluster.org/10723
Tested-by: NetBSD Build System

libgfapi: Store and restore THIS in every API exposed by libgfapi

2015-05-09T13:52:46+00:00

        Backport of http://review.gluster.org/#/c/9797

Storing and restoring THIS:
When the APIs exposed by libgfapi are called by other xlators like
snapview server etc. the THIS value is overwritten to contain the
THIS of libgfapi(viz libgfapi master xlator). Hence using 'THIS'
in any xlator after calling libgfapi API will lead to issues.
One such issue was uncovered in snapview and the patch
http://review.gluster.org/#/c/9469/ was sent to workaround this issue.

Hence, storing and restoring THIS, at the entry and exit of every API
exposed by libgfapi.

Change-Id: I6f330dde25e7700fb26339d667a7ccd193ec6ba0
BUG: 1210934
Signed-off-by: Poornima G 
Reviewed-on: http://review.gluster.org/9797
Reviewed-by: Raghavendra Talur 
Reviewed-by: soumya k 
Reviewed-by: Niels de Vos 
Tested-by: Gluster Build System 
(cherry picked from commit 1162bb36108ab8dba8303b86927a99835b791d79)
Reviewed-on: http://review.gluster.org/10414
Reviewed-by: Shyamsundar Ranganathan

libgfapi : anonymous fd support

2015-05-08T06:50:07+00:00

      backport of http://review.gluster.org/#/c/9971/

Anonymous fd's are floating fd assigned to a glusterfs client
without a explicit file open. Here either it will create a new
anonymous fd or existing anonymous fd in the client stack for
requested file.The anonymous fd's are mainly used for IO's.
This patch introduces two api's glfs_h_anonymous_read and
glfs_h_anonymous_write which performs read and write respectively

cherry-picked as fa0ad231745846918b2625d0e1a89c0a5c3c24dc
>Change-Id: Id646f2220e8387b2f8bb244c848dc1db6761444f
>BUG: 1204651
>Signed-off-by: Jiffin Tony Thottan 
>Reviewed-by: Niels de Vos 
>Reviewed-on: http://review.gluster.org/9971
>Tested-by: Gluster Build System 
>Signed-off-by: Jiffin Tony Thottan 

Change-Id: I6b01d88f92ad045e48debee23aa79f4517c6bdc2
BUG: 1218857
Signed-off-by: Jiffin Tony Thottan 
Reviewed-on: http://review.gluster.org/10635
Reviewed-by: Niels de Vos 
Tested-by: Gluster Build System