glusterfs.git/api/src, branch v3.7.1

gfapi: zero size issue in glfs_h_acl_set()

2015-06-01T09:20:23+00:00

When setting the stringified ACLs in the xattr dict through
pub_glfs_h_setxattrs(), the size of the string is always passed as 0.
The correct way is to pass the length of the ACL in text form.

Backport of:
> Change-Id: Ia7a7fa1f3a7d615a813c703057dc97b09a0bbb34
> BUG: 789278
> Reviewd-on: http://review.gluster.org/10782
> Signed-off-by: Jiffin Tony Thottan 

Change-Id: Ia7a7fa1f3a7d615a813c703057dc97b09a0bbb34
BUG: 1224241
Signed-off-by: Niels de Vos 
Reviewed-on: http://review.gluster.org/10890
Tested-by: Gluster Build System 
Reviewed-by: Shyamsundar Ranganathan

gfapi: fix compile warning in pub_glfs_h_access()

2015-05-09T22:52:08+00:00

While compiling libgfapi, the following warning is reported:

    Making all in src
      CC       libgfapi_la-glfs-handleops.lo
    In file included from glfs-handleops.c:12:0:
    glfs-handleops.c: In function 'pub_glfs_h_access':
    glfs-internal.h:216:14: warning: 'old_THIS' may be used uninitialized in this function [-Wmaybe-uninitialized]
             THIS = old_THIS;                                            \
                  ^
    glfs-internal.h:202:36: note: 'old_THIS' was declared here
     #define DECLARE_OLD_THIS xlator_t *old_THIS = NULL
                                        ^
    glfs-handleops.c:1159:2: note: in expansion of macro 'DECLARE_OLD_THIS'
      DECLARE_OLD_THIS;
      ^
      CCLD     libgfapi.la
      CCLD     api.la

The DECLARE_OLD_THIS macro should be done with the declarations of all
the other variables used in this function. Moving the macro further up
in the function prevents this warning.

Backport of:
> Change-Id: I2bedc1aa074893ae3e2c933abc5a167ab5b55f41
> BUG: 1210934
> Reviewed-on: http://review.gluster.org/10728
> Reported-by: Shyamsundar Ranganathan 
> Signed-off-by: Niels de Vos 

Change-Id: I2bedc1aa074893ae3e2c933abc5a167ab5b55f41
BUG: 1215787
Signed-off-by: Niels de Vos 
Reviewed-on: http://review.gluster.org/10730
Reviewed-by: Shyamsundar Ranganathan 
Tested-by: Gluster Build System

core: use reference counting for mem_acct structures

2015-05-09T21:27:36+00:00

When freeing memory, our memory-accounting code expects to be able to
dereference from the (previously) allocated block to its owning
translator.  However, as we have already found once in option
validation and twice in logging, that translator might itself have
been freed and the dereference attempt causes on of our daemons to
crash with SIGSEGV.  This patch attempts to fix that as follows:

 * We no longer embed a struct mem_acct directly in a struct xlator,
   but instead allocate it separately.

 * Allocated memory blocks now contain a pointer to the mem_acct
   instead of the xlator.

 * The mem_acct structure contains a reference count, manipulated in
   both the normal and translator allocate/free code using atomic
   increments and decrements.

 * Because it's now a separate structure, we can defer freeing the
   mem_acct until its reference count reaches zero (either way).

 * Some unit tests were disabled, because they embedded their own
   copies of the implementation for what they were supposedly testing.
   Life's too short to spend time fixing tests that seem designed to
   impede progress by requiring a certain implementation as well as
   behavior.

Change-Id: Id929b11387927136f78626901729296b6c0d0fd7
BUG: 1219026
Signed-off-by: Jeff Darcy 
Reviewed-on: http://review.gluster.org/10417
Tested-by: Gluster Build System 
Reviewed-by: Krishnan Parthasarathi 
Reviewed-by: Niels de Vos 
Reviewed-by: Pranith Kumar Karampuri 
Reviewed-on: http://review.gluster.org/10723
Tested-by: NetBSD Build System

libgfapi: Store and restore THIS in every API exposed by libgfapi

2015-05-09T13:52:46+00:00

        Backport of http://review.gluster.org/#/c/9797

Storing and restoring THIS:
When the APIs exposed by libgfapi are called by other xlators like
snapview server etc. the THIS value is overwritten to contain the
THIS of libgfapi(viz libgfapi master xlator). Hence using 'THIS'
in any xlator after calling libgfapi API will lead to issues.
One such issue was uncovered in snapview and the patch
http://review.gluster.org/#/c/9469/ was sent to workaround this issue.

Hence, storing and restoring THIS, at the entry and exit of every API
exposed by libgfapi.

Change-Id: I6f330dde25e7700fb26339d667a7ccd193ec6ba0
BUG: 1210934
Signed-off-by: Poornima G 
Reviewed-on: http://review.gluster.org/9797
Reviewed-by: Raghavendra Talur 
Reviewed-by: soumya k 
Reviewed-by: Niels de Vos 
Tested-by: Gluster Build System 
(cherry picked from commit 1162bb36108ab8dba8303b86927a99835b791d79)
Reviewed-on: http://review.gluster.org/10414
Reviewed-by: Shyamsundar Ranganathan

libgfapi : anonymous fd support

2015-05-08T06:50:07+00:00

      backport of http://review.gluster.org/#/c/9971/

Anonymous fd's are floating fd assigned to a glusterfs client
without a explicit file open. Here either it will create a new
anonymous fd or existing anonymous fd in the client stack for
requested file.The anonymous fd's are mainly used for IO's.
This patch introduces two api's glfs_h_anonymous_read and
glfs_h_anonymous_write which performs read and write respectively

cherry-picked as fa0ad231745846918b2625d0e1a89c0a5c3c24dc
>Change-Id: Id646f2220e8387b2f8bb244c848dc1db6761444f
>BUG: 1204651
>Signed-off-by: Jiffin Tony Thottan 
>Reviewed-by: Niels de Vos 
>Reviewed-on: http://review.gluster.org/9971
>Tested-by: Gluster Build System 
>Signed-off-by: Jiffin Tony Thottan 

Change-Id: I6b01d88f92ad045e48debee23aa79f4517c6bdc2
BUG: 1218857
Signed-off-by: Jiffin Tony Thottan 
Reviewed-on: http://review.gluster.org/10635
Reviewed-by: Niels de Vos 
Tested-by: Gluster Build System

Upcall: Send stat as part of cache_invalidation notifications

2015-05-07T11:23:28+00:00

Have added support to send attributes of both entries and
its parent (include oldparent in case of RENAME fop) in the
same notification request to avoid multiple rpc requests.

Also, made changes in gfapi to send parent object and its
attributes changed in a single upcall event.

Change-Id: I92833da3bcec38d65216921c2ce4d10367c32ef1
BUG: 1217711
Signed-off-by: Soumya Koduri 
Reviewed-on: http://review.gluster.org/10568
Tested-by: NetBSD Build System
Reviewed-by: Kaleb KEITHLEY 
Tested-by: Gluster Build System

gfapi: Skip and delete the upcall entry if not found

2015-05-07T11:21:38+00:00

We could run into situations where in gfapi received a upcall
notification for a file and the file may have got deleted by then.
Hence, incase of error while trying to create handle from gfid,
log it, delete the entry and return with CBK_NULL reason.

Change-Id: I191f10f44d6804be07734a6be63a3ca08f455f0e
BUG: 1218566
Signed-off-by: Soumya Koduri 
Reviewed-on: http://review.gluster.org/10341
Reviewed-by: Kaleb KEITHLEY 
Reviewed-on: http://review.gluster.org/10565
Tested-by: NetBSD Build System

Upcall: Process each of the upcall events separately

2015-05-07T11:19:16+00:00

As suggested during the code-review of Bug1200262, have modified
GF_CBK_UPCALL to be exlusively GF_CBK_CACHE_INVALIDATION.
Thus, for any new upcall event, a new CBK procedure will be added.

Also made changes to store upcall data separately based on the
upcall event type received.

BUG: 1217711
Change-Id: I0f5e53d6f5ece16aecb514a0a426dca40fa1c755
Signed-off-by: Soumya Koduri 
Reviewed-on: http://review.gluster.org/10049
Reviewed-by: Kaleb KEITHLEY 
Reviewed-on: http://review.gluster.org/10562
Tested-by: NetBSD Build System
Tested-by: Gluster Build System

libgfapi : port gfapi to new logging framework

2015-05-07T10:30:51+00:00

This also contains backport of http://review.gluster.org/10456:
- Fix ENOKEY build failure on non Linux systems

Cherry picked from commit 8986a47c54db4769feb4e6664532386f1cd0275d:
> Change-Id: Iaa0a92f82b9a0a26eda1a8d72b3b66ce66fab443
> BUG: 1194640
> Signed-off-by: Humble Devassy Chirammal 
> Reviewed-on: http://review.gluster.org/9918
> Tested-by: Gluster Build System 
> Reviewed-by: jiffin tony Thottan 
> Reviewed-by: Raghavendra Talur 
> Reviewed-by: soumya k 
> Reviewed-by: Niels de Vos 

Signed-off-by: Humble Devassy Chirammal 
Change-Id: I320b4f1268d49a1a1086412ff2a9fb815bcf1cf4 
BUG: 1217722
Change-Id: I320b4f1268d49a1a1086412ff2a9fb815bcf1cf4
Reviewed-on: http://review.gluster.org/10486
Tested-by: NetBSD Build System
Reviewed-by: Kaleb KEITHLEY 
Tested-by: Gluster Build System 
Reviewed-by: jiffin tony Thottan

api/libgfapi: Add support for statfs handle

2015-05-07T09:24:59+00:00

        Backport of http://review.gluster.org/10356

snapd feature require statfs fops and thereby
handle of statfs

Change-Id: I037ee846aee3971826a73c592e15f1be27796c64
BUG: 1218741
Signed-off-by: Mohammed Rafi KC 
Reviewed-on: http://review.gluster.org/10356
Tested-by: Gluster Build System 
Reviewed-by: Niels de Vos 
Reviewed-by: Rajesh Joseph 
Reviewed-on: http://review.gluster.org/10598