glusterfs.git/api/src/glfs-handles.h, branch v3.7.16

gfapi: redesign the public interface for upcall consumers

2016-10-03T12:20:43+00:00

The glfs_callback_arg and glfs_callback_inode_arg were allocated by
gfapi, and expected to be free()'d by the application. However it is not
reasonable to expect that applications use the same memory allocator to
as the compiled libgfapi.so. For instance, it is possible that gfapi
uses glibc malloc/free, and an application like NFS-Ganesha the versions
from jemalloc. Mismatching of the malloc() and free() functions causes
segmentation faults at best.

In order to prevent problems like this in the future, the API for
applications that consume upcalls has been remodeled. Any of the
structures that gfapi allocates, should be free'd with glfs_free(). The
members of the structures can not be accessed directly anymore, each
has its own function to access now.

Correcting the naming of the functions, structures and constants is a
continuation of commit 2775dc64101ed37c8d9809bf9852dbf0746ee2b6. These
new improvements not only have correct prefixes for the functions and
structures, the naming also reflects more to the upcall framework and
does not use "callback" anymore.

Cherry picked from commit 4721188a154acd9a0a4c096d8d73e97f3bf1b2a9:
> Change-Id: I2b8bd5a0a82036d2abea1a217f5e5975a1d4fe93
> BUG: 1344714
> Signed-off-by: Niels de Vos 
> Reviewed-on: http://review.gluster.org/14701
> Smoke: Gluster Build System 
> NetBSD-regression: NetBSD Build System 
> CentOS-regression: Gluster Build System 
> Reviewed-by: Kaleb KEITHLEY 
> Reviewed-by: soumya k 
> Reviewed-by: jiffin tony Thottan 

Once difference with the version of this change in other branches is
that leases are not included in glusterfs-3.7. Hence there is a little
change that drops the handling of GF_UPCALL_RECALL_LEASE.

In addition, this backport contains commit 2775dc6410:
> libgfapi/upcall : prepend "glfs_" to callback_arg, callback_inode_arg
> Reviewed-on: http://review.gluster.org/14702

Change-Id: I2b8bd5a0a82036d2abea1a217f5e5975a1d4fe93
BUG: 1347715
Signed-off-by: Niels de Vos 
Reviewed-on: http://review.gluster.org/15602
NetBSD-regression: NetBSD Build System 
Smoke: Gluster Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Kaushal M

libgfapi: adding 'follow' flag to glfs_h_lookupat()

2015-08-25T12:31:35+00:00

This patch is backport of http://review.gluster.org/#/c/11883/

Previously glfs_h_lookupat won't follow the symlink, this patch
introduces new flag `follow` which will resolve the same. Applications
linking against the new library will need to use the new glfs_h_lookupat
API call.

In order to stay compatible with existing binaries that use the previous
glfs_h_lookupat() function, the old symbol needs to stay available.

Verification that there are two versions of glfs_h_lookupat:

  $ objdump -T /usr/lib64/libgfapi.so.0 | grep -w glfs_h_lookupat
  0000000000015070 g    DF .text  000000000000021e  GFAPI_3.7.4 glfs_h_lookupat
  0000000000015290 g    DF .text  0000000000000008 (GFAPI_3.4.2) glfs_h_lookupat

Testing with a binary (based on anonymous_fd_read_write.c from ./tests/)
that was linked against the old library:

  $ objdump -T ./lookupat | grep -w glfs_h_lookupat
  0000000000000000      DF *UND*  0000000000000000  GFAPI_3.4.2 glfs_h_lookupat

Enable debugging for 'ld.so' so that we can check that the GFAPI_3.4.2
version of the symbol gets loaded:

  $ export LD_DEBUG_OUTPUT=lookupat.ld.log LD_DEBUG=all
  $ ./lookupat
  $ grep -w glfs_h_lookupat lookupat.ld.log.2543
  2543:     symbol=glfs_h_lookupat;  lookup in file=./lookupat [0]
  2543:     symbol=glfs_h_lookupat;  lookup in file=/lib64/libgfapi.so.0 [0]
  2543:     binding file ./lookupat [0] to /lib64/libgfapi.so.0 [0]: normal symbol `glfs_h_lookupat' [GFAPI_3.4.2]

This change has been successfully cherry-picked as 1ead86a8bcbfe4045729466e4b98f765f3c13c8d
in master

Upstream reference
>Change-Id: I8bf9b1c19a0585f681bc1a7f84aad1ccd0f75f6a
>BUG: 1252410
>Signed-off-by: Jiffin Tony Thottan 
>Signed-off-by: Niels de Vos 
>Reviewed-on: http://review.gluster.org/11883
>Reviewed-by: soumya k 
>Reviewed-by: Kaleb KEITHLEY 
>Tested-by: NetBSD Build System 
Signed-off-by: Jiffin Tony Thottan 

Change-Id: Idbbf0cd6802f86c53b16377d90d08ff6d99e7b08
BUG: 1256616
Reviewed-on: http://review.gluster.org/12009
Tested-by: NetBSD Build System 
Tested-by: Gluster Build System 
Reviewed-by: Kaleb KEITHLEY

libgfapi : anonymous fd support

2015-05-08T06:50:07+00:00

      backport of http://review.gluster.org/#/c/9971/

Anonymous fd's are floating fd assigned to a glusterfs client
without a explicit file open. Here either it will create a new
anonymous fd or existing anonymous fd in the client stack for
requested file.The anonymous fd's are mainly used for IO's.
This patch introduces two api's glfs_h_anonymous_read and
glfs_h_anonymous_write which performs read and write respectively

cherry-picked as fa0ad231745846918b2625d0e1a89c0a5c3c24dc
>Change-Id: Id646f2220e8387b2f8bb244c848dc1db6761444f
>BUG: 1204651
>Signed-off-by: Jiffin Tony Thottan 
>Reviewed-by: Niels de Vos 
>Reviewed-on: http://review.gluster.org/9971
>Tested-by: Gluster Build System 
>Signed-off-by: Jiffin Tony Thottan 

Change-Id: I6b01d88f92ad045e48debee23aa79f4517c6bdc2
BUG: 1218857
Signed-off-by: Jiffin Tony Thottan 
Reviewed-on: http://review.gluster.org/10635
Reviewed-by: Niels de Vos 
Tested-by: Gluster Build System

Upcall: Send stat as part of cache_invalidation notifications

2015-05-07T11:23:28+00:00

Have added support to send attributes of both entries and
its parent (include oldparent in case of RENAME fop) in the
same notification request to avoid multiple rpc requests.

Also, made changes in gfapi to send parent object and its
attributes changed in a single upcall event.

Change-Id: I92833da3bcec38d65216921c2ce4d10367c32ef1
BUG: 1217711
Signed-off-by: Soumya Koduri 
Reviewed-on: http://review.gluster.org/10568
Tested-by: NetBSD Build System
Reviewed-by: Kaleb KEITHLEY 
Tested-by: Gluster Build System

api/libgfapi: Add support for statfs handle

2015-05-07T09:24:59+00:00

        Backport of http://review.gluster.org/10356

snapd feature require statfs fops and thereby
handle of statfs

Change-Id: I037ee846aee3971826a73c592e15f1be27796c64
BUG: 1218741
Signed-off-by: Mohammed Rafi KC 
Reviewed-on: http://review.gluster.org/10356
Tested-by: Gluster Build System 
Reviewed-by: Niels de Vos 
Reviewed-by: Rajesh Joseph 
Reviewed-on: http://review.gluster.org/10598

gfapi: Modified CACHE_INVALIDATE flags

2015-05-03T11:35:03+00:00

Have prefixed CACHE_INVALIDATE flags exposed via gfapi with 'GFAPI_'.
In addition as INODE_UPDATE is asynchronous and may need some
support in NFS-Ganesha, have taken it out for now. Will revisit it
later.

BUG: 1217711
Change-Id: If5cd7262c85946ade04892105100aafe66887e0e
Signed-off-by: Soumya Koduri 
Reviewed-on: http://review.gluster.org/10225
Reviewed-by: Niels de Vos 
Reviewed-on: http://review.gluster.org/10484
Reviewed-by: Kaleb KEITHLEY 
Tested-by: Gluster Build System

gfapi: Fix in glfs_h_create_from_handle

2015-05-02T09:29:44+00:00

While constructing glfs_object from the handle given, incase
if inode is found in the inode table, we need not do "syncop_lookup"
unless we need to return the inode attributes.

BUG: 1217711
Change-Id: Iaf296a80f721f9fca38d8023b83d37e6e5d970a5
Signed-off-by: Soumya Koduri 
Reviewed-on: http://review.gluster.org/10232
Reviewed-by: Niels de Vos 
Reviewed-on: http://review.gluster.org/10485
Reviewed-by: Kaleb KEITHLEY 
Tested-by: Gluster Build System 
Tested-by: NetBSD Build System
Reviewed-by: Vijay Bellur

Upcall: Added xlator options to enable cache-invalidation

2015-03-31T18:16:26+00:00

Added two xlator options to enable cache-invalidation and set
cache-invalidation-timeout.

In addition, made few minor changes in the upcall processing code
in gfapi.

Change-Id: Ie0b32ca8348e34e3fe4f1e7df30cc925fa4aad31
BUG: 1200271
Signed-off-by: Soumya Koduri 
Reviewed-on: http://review.gluster.org/9975
Reviewed-by: Meghana M 
Reviewed-by: Kaleb KEITHLEY 
Tested-by: Gluster Build System

gfapi: add glfs_h_acl_set() and glfs_h_acl_get()

2015-03-18T17:39:03+00:00

These two functions add support for POSIX ACLs through the GFAPI-handle
interface.

The initial infrastructure for POSIX ACLs based on libacl has been added
with the required changes to the POSIX xlator:
- http://review.gluster.org/9627

NetBSD does not support POSIX ACLs, so using any of the functions should
return ENOTSUP.

URL: http://www.gluster.org/community/documentation/index.php/Features/Improved_POSIX_ACLs
Change-Id: Ie74f3f963c3f9d576cb2f2a1e6d97e3cd4b01eda
BUG: 1185654
Signed-off-by: Niels de Vos 
Reviewed-on: http://review.gluster.org/9736
Reviewed-by: Kaleb KEITHLEY 
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

gfapi: APIs to store and process upcall notifications received

2015-03-17T21:01:21+00:00

In case of any upcall cbk events received by the protocol/client,
gfapi will be notified which queues them up in a list ().

Applicatons are responsible to provide APIs to process & notify them in case
of any such upcall events queued.

Added a new API which will be used by Ganesha to repeatedly poll for any
such upcall event notified ().

A new test-file has been added to test the cache_invalidation upcall events.

Below link has a writeup which explains the code changes done -
        URL: https://soumyakoduri.wordpress.com/2015/02/25/glusterfs-understanding-upcall-infrastructure-and-cache-invalidation-support/

Change-Id: Iafc6880000c865fd4da22d0cfc388ec135b5a1c5
BUG: 1200262
Signed-off-by: Soumya Koduri 
Reviewed-on: http://review.gluster.org/9536
Tested-by: Gluster Build System 
Reviewed-by: Kaleb KEITHLEY