glusterfs.git, branch v3.9.0

doc: finalize release-notes for 3.9.0

2016-11-15T14:45:21+00:00

Added the BZs from last RC till now. Added Release notes for the
major features as well.

BUG: 1350744
Change-Id: Iee1dae0d5776a3e3695bfb087591964f66802dc9
Signed-off-by: Pranith Kumar K 
Signed-off-by: Aravinda VK 
Reviewed-on: http://review.gluster.org/15841
Smoke: Gluster Build System 
CentOS-regression: Gluster Build System 
NetBSD-regression: NetBSD Build System

Remove experimental translators

2016-11-14T05:27:04+00:00

Change-Id: Id645918fa236f1fc00ab5fa427f394e853c44bf8
BUG: 1389675
Signed-off-by: Kaushal M 
Reviewed-on: http://review.gluster.org/15750
Tested-by: Pranith Kumar Karampuri 
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System

Revert "rpc: Fix the race between notification and reconnection"

2016-11-12T05:06:49+00:00

This reverts commit e6c38ae1d3f3c53f8739ab2db7c4ecfdbc58fc44.

Mount is intermittently failing with this patch, which means
this patch introduced another race. So until we fix that
reverting this patch and making the release.

BUG: 1388323
Change-Id: I6e110caf38fcc6a309b2abdc864bc4fbdb3a7588
Signed-off-by: Pranith Kumar K 
Reviewed-on: http://review.gluster.org/15825
Reviewed-by: Raghavendra Talur 
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System

gfapi: remove extra fd_unref

2016-11-11T15:45:15+00:00

Online gerrit rebase does not seem to be working. Commit
a3bade0976d9f976855baf0de479205aa50e2abd is not complete backport of
http://review.gluster.org/#/c/15768.


Change-Id: I5229d87c8c403106f20c50bc8a7f38dad9a2303d
BUG: 1392286
Signed-off-by: Raghavendra Talur 
Reviewed-on: http://review.gluster.org/15829
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Smoke: Gluster Build System

glusterd/quota: upgrade quota.conf file during an upgrade

2016-11-11T10:11:36+00:00

Problem
=======
When quota is enabled on 3.6, it will have quota conf version in quota.conf
as v1.1. This node gets upgraded to 3.7 but it will still have quota conf
version as v1.1 until a quota enable/disable/set limit is initiated. When
this is not initiated and when this node tries to peer probe a node which
is a fresh install of 3.7 (which will have quota conf version as v1.2), then this
will result in "Peer rejected" state. This patch fixes the issue.

Solution
========
When an upgrade happens from 3.6 to 3.7, quota.conf file needs
to be modified as well. With 3.6, in quota.conf the version will be
v1.1 and it needs to be changed to v1.2 from 3.7. This is because in
3.7, inode quota feature is introduced. So when an op-version bumpup
happens quota.conf needs to be upgraded with quota conf version v1.2
and all the 16 byte uuid needs to be changed to 17 bytes uuid as well.

Previously, when the cluster version is upgraded to 3.7, the quota.conf
got upgraded as well. But, the upgradation was done only when quota
enable/disable/set limit is done. With this patch, the upgradation is done
during a cluster op version bump up as well.


>Reviewed-on: http://review.gluster.org/15352
>Tested-by: Atin Mukherjee 
>NetBSD-regression: NetBSD Build System 
>CentOS-regression: Gluster Build System 
>Smoke: Gluster Build System 
>Reviewed-by: Atin Mukherjee 
>(cherry picked from commit 4b2cff614462508eef529c5d128e0974720e3f50)

Change-Id: Idb5ba29d3e1ea0e45c85d87c952c75da9e0f99f0
BUG: 1392718
Signed-off-by: Manikandan Selvaganesh 
Reviewed-on: http://review.gluster.org/15792
Tested-by: Atin Mukherjee 
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
Reviewed-by: Manikandan Selvaganesh 
CentOS-regression: Gluster Build System

gfapi: async fops should unref in callbacks

2016-11-10T08:25:11+00:00

If fd is unref'd at the end of async call then the unref in cbks would
lead to double unref and possible crash. Removing duplicate unrefs.

Added unref only in failure cases.

A simple test case has been added to test async write case. Need to
extend the same for other async APIs too.

Details:
All glfd based calls in libgfapi, except for glfs_open and glfs_close,
behave in the same way. At the start of the operation, they take a ref
on glfd and fd. At the end of the operation, they unref it. Async calls
are a little different as they unref in the cbk function. A successfull
open call does not unref either the glfd or fd, thereby functioning as a
reference for a OPEN file object. glfs_close makes a syncop_flush call
sandwiched between a fd ref and unref(this can be removed, more on this
below), followed by a call to glfs_mark_glfd_for_deletion which unrefs
glfd and also calls glfs_fd_destroy as a release function thereby doing
a unref on fd too.

Functionally, there is no problem with how everything works when as
described above. However, it is a little non-intuitive that we need to
perform a fd_unref as a consequence of a implicit fd_ref that happens
within glfs_resolve_fd. As we perform a GF_REF_GET(glfd) at the start of
every operation, it would be worthwhile to remove the fd_ref that
glfs_resovle_fd takes and do away with explicit fd_unref()s at the end
of every operation. This is the same reason why we don't need the fd_ref
in glfs_close. This is however not in the scope of this patch.

Change-Id: I86b1d3b2ad846b16ea527d541dc82b5e90b0ba85
BUG: 1392286
Signed-off-by: Raghavendra Talur 
Reviewed-on: http://review.gluster.org/15768
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
Reviewed-by: Rajesh Joseph 
Reviewed-by: Xavier Hernandez 
Reviewed-by: soumya k 
Reviewed-by: Prasanna Kumar Kalever 
CentOS-regression: Gluster Build System 
Reviewed-by: Shyamsundar Ranganathan 
(cherry picked from commit e65738818dd22462ec00dda021566654d1c702b1)
Reviewed-on: http://review.gluster.org/15778

gfapi: Fix few fd ref leaks

2016-11-10T06:44:03+00:00

From the code inspection, have observed that there are fd ref
leaks for few fd-based gfapi fops. 'glfs_resolve_fd' returns
a fd (either existing or migrated) with an extra ref taken.
This needs to be unref'ed at the end of the operation.

Mainline reference:
> Change-Id: Id63394e3e7deafb0c8b06444f2ae847248b126db
> BUG: 1379285
> Signed-off-by: Soumya Koduri 
> Reviewed-on: http://review.gluster.org/15573
> Reviewed-by: Niels de Vos 
(cherry picked from commit d27cffab670858d7812bbb458a0833303d009b3b)

Change-Id: I17dd9e31eca7ffa1f60a9e3a66b1c7051ce9002f
BUG: 1379707
Signed-off-by: Soumya Koduri 
Reviewed-on: http://review.gluster.org/15584
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Shyamsundar Ranganathan 
Reviewed-by: Raghavendra Talur

posix-acl: check dictionary before using it

2016-11-09T19:17:18+00:00

If extended attributes are not present in md-cache it returns NULL as xattr.
posix acl xlator should check for NULL before using xattr.

If normal and default ACLs are not set on file then md-cache will not contain
system.posix_acl_access and system.posix_acl_default extended attributes in
its cache.

Therefore posix_acl_lookup_cbk should check xattr before using it, otherwise
the logs will get filled with dictionary errors.

> Reviewed-on: http://review.gluster.org/15769
> Reviewed-by: Raghavendra Talur 
> Smoke: Gluster Build System 
> Reviewed-by: jiffin tony Thottan 
> NetBSD-regression: NetBSD Build System 
> Reviewed-by: Vijay Bellur 
> CentOS-regression: Gluster Build System 

(cherry picked from commit de7fe24663713fff364cfc2b52b675e3e979ee68)

Change-Id: Icebf73cf0b313bd3e82ca8cbda63786dd0fa47da
BUG: 1392869
Signed-off-by: Rajesh Joseph 
Reviewed-on: http://review.gluster.org/15801
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Smoke: Gluster Build System 
Reviewed-by: Raghavendra Talur

build: Update version check for resource-agents on RHEL

2016-11-09T18:19:11+00:00

With bug1302545[1] and bug1303037[2], portblock resource agent
is made available as part of resource-agents-3.9.5* package
on RHEL 6.8 and RHEL 7.3 respectively. This change is to
update the same in the glusterfs spec.

[1] https://bugzilla.redhat.com/show_bug.cgi?id=1302545
[2] https://bugzilla.redhat.com/show_bug.cgi?id=1303037

This is backport of below mainline patch -
  http://review.gluster.org/15803


> Change-Id: I5917e5f22f07b4121d636b099dd8815847e1338f
> BUG: 1389742
> Author:    Kaleb KEITHLEY 
> Signed-off-by: Soumya Koduri 
> Reviewed-on: http://review.gluster.org/15803
> Reviewed-by: Kaleb KEITHLEY 
> Reviewed-by: jiffin tony Thottan 
> NetBSD-regression: NetBSD Build System 
> Smoke: Gluster Build System 
> CentOS-regression: Gluster Build System 
> (cherry picked from commit 3e980c5eff495725e7c01793451bc81fd6f94ad5)

Change-Id: Ib7a3194f0581f131a537a7b543f396b4837bffbf
BUG: 1389742
Signed-off-by: Soumya Koduri 
Reviewed-on: http://review.gluster.org/15807
NetBSD-regression: NetBSD Build System 
Reviewed-by: Kaleb KEITHLEY 
CentOS-regression: Gluster Build System 
Smoke: Gluster Build System

features/shard: Fill loc.pargfid too for named lookups on individual shards

2016-11-09T07:34:31+00:00

        Backport of: http://review.gluster.org/#/c/15788/

On a sharded volume when a brick is replaced while IO is going on, named
lookup on individual shards as part of read/write was failing with
ENOENT on the replaced brick, and as a result AFR initiated name heal in
lookup callback. But since pargfid was empty (which is what this patch
attempts to fix), the resolution of the shards by protocol/server used
to fail and the following pattern of logs was seen:

Brick-logs:

[2016-11-08 07:41:49.387127] W [MSGID: 115009]
[server-resolve.c:566:server_resolve] 0-rep-server: no resolution type
for (null) (LOOKUP)
[2016-11-08 07:41:49.387157] E [MSGID: 115050]
[server-rpc-fops.c:156:server_lookup_cbk] 0-rep-server: 91833: LOOKUP(null)
(00000000-0000-0000-0000-000000000000/16d47463-ece5-4b33-9c93-470be918c0f6.82)
==> (Invalid argument) [Invalid argument]

Client-logs:
[2016-11-08 07:41:27.497687] W [MSGID: 114031]
[client-rpc-fops.c:2930:client3_3_lookup_cbk] 2-rep-client-0: remote
operation failed. Path: (null) (00000000-0000-0000-0000-000000000000)
[Invalid argument]
[2016-11-08 07:41:27.497755] W [MSGID: 114031]
[client-rpc-fops.c:2930:client3_3_lookup_cbk] 2-rep-client-1: remote
operation failed. Path: (null) (00000000-0000-0000-0000-000000000000)
[Invalid argument]
[2016-11-08 07:41:27.498500] W [MSGID: 114031]
[client-rpc-fops.c:2930:client3_3_lookup_cbk] 2-rep-client-2: remote
operation failed. Path: (null) (00000000-0000-0000-0000-000000000000)
[Invalid argument]
[2016-11-08 07:41:27.499680] E [MSGID: 133010]

Also, this patch makes AFR by itself choose a non-NULL pargfid even if
its ancestors fail to initialize all pargfid placeholders.

Change-Id: I1ad027b7b2ccd6b5c0162726b63b06d261b108e8
BUG: 1392844
Signed-off-by: Krutika Dhananjay 
Reviewed-on: http://review.gluster.org/15795
Reviewed-by: Pranith Kumar Karampuri 
Reviewed-by: Ravishankar N 
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System