glusterfs.git, branch v3.8.9

doc: release-notes for GlusterFS-3.8.9

2017-02-13T08:56:26+00:00

BUG: 1412144
Change-Id: I70f5d517f475c51c1a5ac3835c85092cbceedeaf
Signed-off-by: Niels de Vos 
Reviewed-on: https://review.gluster.org/16604
CentOS-regression: Gluster Build System 
NetBSD-regression: NetBSD Build System 
Smoke: Gluster Build System

cluster/dht: Don't update layout in rebalance_task_completion

2017-02-13T08:32:11+00:00

Updating the layout in the dht inode_ctx in
rebalance_task_completion after the file is migrated
is erroneous in case of files with hardlinks.
This step can be skipped as the layout will be set
in the syncop_lookup call post the migration in
dht_migrate_file.

> Change-Id: I24ac798a919585d91a117d6a207e6a31b88486c6
> BUG: 1415761
> Signed-off-by: N Balachandran 
> Reviewed-on: https://review.gluster.org/16457
> Reviewed-by: Raghavendra G 
> Reviewed-by: Susant Palai 
Signed-off-by: N Balachandran 

Change-Id: Ifccffd67b8bc12208efb23101366a1ac7a8c60f5
BUG: 1420184
Reviewed-on: https://review.gluster.org/16561
Smoke: Gluster Build System 
Tested-by: N Balachandran 
NetBSD-regression: NetBSD Build System 
Reviewed-by: Susant Palai 
CentOS-regression: Gluster Build System 
Reviewed-by: Niels de Vos

debug/trace: Print entries' iatts in readdirp cbk

2017-02-06T08:54:07+00:00

        Backport of: http://review.gluster.org/16432

Change-Id: Ie96b04e7961d353f2a193f368ac5ae94a3f64d77
BUG: 1417802
Signed-off-by: Krutika Dhananjay 
Reviewed-on: https://review.gluster.org/16482
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Raghavendra G

features/changelog: Fix htime xattr during brick crash

2017-01-31T09:31:14+00:00

The htime file contains the path of all the changelogs
that is rolloved over till now. It also maintains xattr
which tracks the latest changelog file rolloved over
and the number of changelogs. The path and and xattr
update happens in two different system calls. If the
brick is crashed between them, the xattr value becomes
stale and can lead to the failure of gf_history_changelog.
To identify this, the total number of changelogs is being
calculated based on htime file size and the record
length. The above value is used in case of mismatch.

> Change-Id: Ia1c3efcfda7b74227805bb2eb933c9bd4305000b
> BUG: 1413967
> Signed-off-by: Kotresh HR 
> Reviewed-on: http://review.gluster.org/16420
> NetBSD-regression: NetBSD Build System 
> Smoke: Gluster Build System 
> CentOS-regression: Gluster Build System 
> Reviewed-by: Aravinda VK 

Change-Id: Ia1c3efcfda7b74227805bb2eb933c9bd4305000b
BUG: 1415053
Signed-off-by: Kotresh HR 
(cherry picked from commit 6f4811ca9331eee8c00861446f74ebe23626bbf8)
Reviewed-on: https://review.gluster.org/16437
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Smoke: Gluster Build System 
Reviewed-by: Aravinda VK

cli: keep 'gluster volume status detail' consistent

2017-01-25T04:50:01+00:00

The output of the command 'gluster volume status  detail' is
not consistent between operating systems. On linux hosts it shows the
file system type, the device name, mount options and inode size of each
brick. However the same command executed on a FreeBSD host doesn't show
all this information, even for bricks stored on a linux.

Additionally, for hosts other than linux, this information is shown as
'N/A' many times. This has been fixed to show as much information as it
can be retrieved from the operating system.

The file contrib/mount/mntent.c has been mostly rewriten because it
contained many errors that caused mount information to not be retrieved
on some operating systems.

> Change-Id: Icb6e19e8af6ec82255e7792ad71914ef679fc316
> BUG: 1411334
> Signed-off-by: Xavier Hernandez 
> Reviewed-on: http://review.gluster.org/16371
> Smoke: Gluster Build System 
> NetBSD-regression: NetBSD Build System 
> CentOS-regression: Gluster Build System 
> Reviewed-by: Atin Mukherjee 
> Reviewed-by: Kaleb KEITHLEY 

Change-Id: I01f99562dddff5d5cb6974df44d1b6366faf05dc
BUG: 1415132
Signed-off-by: Xavier Hernandez 
Reviewed-on: https://review.gluster.org/16442
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Kaleb KEITHLEY

Upcall: Fix possible memleak when inode_ctx_set fails

2017-01-24T10:15:59+00:00

In __upcall_inode_ctx_set(), if inode_ctx_set fails we should
free allocated memory for ctx. This patch takes care of the same.

This is backport of below mainline fix.
http://review.gluster.org/16381

>Change-Id: Iafb42787151a579caf6f396c9b414ea48d16e6b4
>BUG: 1412489
>Reported-by: Nithya Balachandran 
>Signed-off-by: Soumya Koduri 
>Reviewed-on: http://review.gluster.org/16381
>Reviewed-by: N Balachandran 
>Smoke: Gluster Build System 
>NetBSD-regression: NetBSD Build System 
>CentOS-regression: Gluster Build System 
>Reviewed-by: Jeff Darcy 
>(cherry picked from commit 84271e12efb783bfc83133329b0fd18aba729c84)

Change-Id: Ia258f3fb12b92795aa7546708c6da5c91f70a08a
BUG: 1414655
Reported-by: Nithya Balachandran 
Signed-off-by: Soumya Koduri 
Reviewed-on: https://review.gluster.org/16431
Smoke: Gluster Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: N Balachandran 
NetBSD-regression: NetBSD Build System 
Reviewed-by: Niels de Vos

cluster/dht: Incorrect migration checks in fsync

2017-01-23T04:15:17+00:00

Fixed the order of the migration phase checks
in dht_fsync_cbk. Phase1 should never be hit if op_ret
is non zero.

> Change-Id: I9222692e04868bffa93498059440f0aa553c83ec
> BUG: 1410777
> Reviewed-on: http://review.gluster.org/16350
> Smoke: Gluster Build System 
> Reviewed-by: Shyamsundar Ranganathan 
> Tested-by: Raghavendra G 
> NetBSD-regression: NetBSD Build System 
> CentOS-regression: Gluster Build System 
> Reviewed-by: Raghavendra G 
(cherry picked from commit 83117c71482c9f87a0b6812094cbb22497eb3faa)

Change-Id: I0455871aef230371db5ecb1b2e6b1468e8a6d079
BUG: 1412119
Signed-off-by: N Balachandran 
Reviewed-on: https://review.gluster.org/16374
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Raghavendra G

cluster/dht: Do rename cleanup as root

2017-01-18T04:03:30+00:00

Problem:
Rename linkfile cleanup is done as non-root which may not have priviliges to do
the rename so it fails with EACCESS. MKDIR on that name in future will start to
hole on this subvolume. It is not easy to hit on fuse mounts because vfs takes
care of the permission checks even before rename fop is wound. But with
nfs-ganesha mounts it happens.

Fix:
Do rename cleanup as root

 >BUG: 1409727
 >Change-Id: I414c1eb6dce76b4516a6c940557b249e6c3f22f4
 >Signed-off-by: Pranith Kumar K 
 >Reviewed-on: http://review.gluster.org/16317
 >Smoke: Gluster Build System 
 >CentOS-regression: Gluster Build System 
 >Reviewed-by: Raghavendra G 
 >Reviewed-by: N Balachandran 
 >NetBSD-regression: NetBSD Build System 

BUG: 1412913
Change-Id: I7f891034150d7a0e3210202fb0788040c91e1c09
Signed-off-by: Pranith Kumar K 
Reviewed-on: http://review.gluster.org/16390
Smoke: Gluster Build System 
Reviewed-by: N Balachandran 
CentOS-regression: Gluster Build System 
NetBSD-regression: NetBSD Build System

performance/io-threads: Exit threads in fini() as well

2017-01-18T02:46:34+00:00

Problem:
io-threads starts the thread in 'init()' but doesn't clean them up
on 'fini()'. It relies on PARENT_DOWN to exit threads but there can
be cases where event before PARENT_UP the graph init code can think
of issuing fini(). This code path is hit when glfs_init() is called
on a volume that is in 'stopped' state. It leads to a crash in ganesha
process, because the io-thread tries to access freed memory.

Fix:
Ideal fix would be to wait for all fops in io-thread list to be completed on
PARENT_DOWN, and have fini() do cleanup of threads. Because there is no proper
documentation about how PARENT_DOWN/fini are supposed to be used,
we are getting different kinds of sequences in different higher level protocols.
So for now cleaning up in both PARENT_DOWN and fini(). Fuse doesn't call fini()
gfapi is not calling PARENT_DOWN in some cases, so for now I don't see
another way out.

 >BUG: 1396793
 >Change-Id: I9c9154e7d57198dbaff0f30d3ffc25f6d8088aec
 >Signed-off-by: Pranith Kumar K 
 >Reviewed-on: http://review.gluster.org/15888
 >Smoke: Gluster Build System 
 >CentOS-regression: Gluster Build System 
 >NetBSD-regression: NetBSD Build System 
 >Reviewed-by: Raghavendra G 
 >(cherry picked from commit 25817a8c868b6c1b8149117f13e4216a99e453aa)

BUG: 1412941
Change-Id: I5e36a7d253f2ef8abce507eced1eb7073cff930c
Signed-off-by: Pranith Kumar K 
Reviewed-on: http://review.gluster.org/16397
CentOS-regression: Gluster Build System 
NetBSD-regression: NetBSD Build System 
Smoke: Gluster Build System

performance/io-threads: Exit all threads on PARENT_DOWN

2017-01-17T15:58:14+00:00

Problem:
When glfs_fini() is called on a volume where client.io-threads is enabled,
fini() will free up iothread xl's private structure but there would be some
threads that are sleeping which would wakeup after the timedwait completes
leading to accessing already free'd memory.

Fix:
As part of parent-down, exit all sleeping threads.

Please note that the upstream patch differs from this a little bit,
because least-prio-throttling feature is removed from master, 3.9

 >BUG: 1381830
 >Change-Id: I0bb8d90241112c355fb22ee3fbfd7307f475b339
 >Signed-off-by: Pranith Kumar K 
 >Reviewed-on: http://review.gluster.org/15620
 >Smoke: Gluster Build System 
 >CentOS-regression: Gluster Build System 
 >NetBSD-regression: NetBSD Build System 
 >Reviewed-by: Raghavendra G 
 >(cherry picked from commit d7a5ca16911caca03cec1112d4be56a9cda2ee30)

BUG: 1412941
Change-Id: I6341156251279b24ab2323cedf1b9722e42da671
Signed-off-by: Pranith Kumar K 
Reviewed-on: http://review.gluster.org/16396
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System