glusterfs.git, branch v3.8.15

doc: release-notes for GlusterFS-3.8.15

2017-08-16T06:30:43+00:00

BUG: 1469558
Change-Id: Ia9a4e69e5d7dfd33933b20b7c4ea41e439d3c838
Signed-off-by: Niels de Vos 
Reviewed-on: https://review.gluster.org/18039
CentOS-regression: Gluster Build System 
Smoke: Gluster Build System 
Reviewed-by: jiffin tony Thottan

api: memory leak in glfs_h_acl_get(), missing dict unref

2017-08-15T10:19:11+00:00

master review https://review.gluster.org/17092 circa April 2017
Fix already exists in release-3.12 and release-3.11 branches

Hat tip to Shyam (srangana[at]redhat.com) who found the existing
fix after sitting and debugging it with me for several hours.

Reported-by: Kinglong Mee 
Change-Id: Ic7169fd05aff7bf46108e8ac7b1f29688a7f2358
BUG: 1481398
Signed-off-by: Kaleb S. KEITHLEY 
Reviewed-on: https://review.gluster.org/18037
Smoke: Gluster Build System 
Reviewed-by: Kinglong Mee 
CentOS-regression: Gluster Build System 
Reviewed-by: Prashanth Pai 
Reviewed-by: Niels de Vos

cli/xml: fix return handling

2017-08-10T16:45:29+00:00

The return code of xmlTextWriter* APIs says it returns either the bytes
written (may be 0 because of buffering) or -1 in case of error. Now if the
volume of the xml data payload is not huge then most of the time the
data to be written gets buffered, however when this grows sometimes this
APIs will return the total number of bytes written and then it becomes
absolutely mandatory that every such call is followed by
XML_RET_CHECK_AND_GOTO otherwise we may end up returning a non zero ret
code which would result into the overall xml generation to fail.

>Reviewed-on: https://review.gluster.org/17702
>Smoke: Gluster Build System 
>Reviewed-by: Amar Tumballi 
>CentOS-regression: Gluster Build System 
>Reviewed-by: Gaurav Yadav 

Change-Id: I02ee7076e1d8c26cf654d3dc3e77b1eb17cbdab0
BUG: 1470495
Signed-off-by: Atin Mukherjee 
Reviewed-on: https://review.gluster.org/17766
Smoke: Gluster Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Samikshan Bairagya 
Reviewed-by: Niels de Vos

storage/posix: Use the ret value of posix_gfid_heal()

2017-08-10T16:41:37+00:00

... to make the change in commit acf8cfdf truly useful.

Without this, a race between entry creation fops and lookup
at posix layer can cause lookups to fail with ENODATA, as
opposed to ENOENT.

Backport of:
> Change-Id: I44a226872283a25f1f4812f03f68921c5eb335bb
> Reviewed-on: https://review.gluster.org/17821
> BUG: 1472758
> cherry-picked from 669868d23eaeba42809fca7be134137c607d64ed

Change-Id: I44a226872283a25f1f4812f03f68921c5eb335bb
BUG: 1480193
Signed-off-by: Krutika Dhananjay 
Reviewed-on: https://review.gluster.org/18015
Smoke: Gluster Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Raghavendra Bhat 
Reviewed-by: Niels de Vos

afr: mark non sources as sinks in metadata heal

2017-07-28T06:31:34+00:00

Backport of https://review.gluster.org/#/c/17717/

Problem:
In a 3 way replica, when the source brick does not have pending xattrs
for the sinks, but the 2 sinks blame each other, metadata heal was not
happpening because we were not setting all non-sources as sinks.

Fix: Mark all non-sources as sinks, like it is done in data and entry
heal.

Change-Id: I534978940f5087302e307fcc810a48ffe898ce08
BUG: 1471613
Signed-off-by: Ravishankar N 
Reviewed-on: https://review.gluster.org/17784
Smoke: Gluster Build System 
Reviewed-by: Pranith Kumar Karampuri 
CentOS-regression: Gluster Build System

doc: release-notes for GlusterFS-3.8.14

2017-07-11T14:04:07+00:00

BUG: 1464927
Change-Id: I2ce12274e4d0ed1135370341eacd9f9f66993559
Signed-off-by: Niels de Vos 
Reviewed-on: https://review.gluster.org/17748
CentOS-regression: Gluster Build System 
Reviewed-by: Michael Scherer 
Smoke: Gluster Build System

rpc: bump up conn->cleanup_gen in rpc_clnt_reconnect_cleanup

2017-07-11T13:25:40+00:00

Commit 086436a introduced generation number (cleanup_gen) to ensure that
rpc layer doesn't end up cleaning up the connection object if
application layer has already destroyed it. Bumping up cleanup_gen was
done only in rpc_clnt_connection_cleanup (). However the same is needed
in rpc_clnt_reconnect_cleanup () too as with out it if the object gets destroyed
through the reconnect event in the application layer, rpc layer will
still end up in trying to delete the object resulting into double free
and crash.

Peer probing an invalid host/IP was the basic test to catch this issue.

Cherry picked from commit 39e09ad1e0e93f08153688c31433c38529f93716:
> Change-Id: Id5332f3239cb324cead34eb51cf73d426733bd46
> BUG: 1433578
> Signed-off-by: Atin Mukherjee 
> Reviewed-on: https://review.gluster.org/16914
> Smoke: Gluster Build System 
> NetBSD-regression: NetBSD Build System 
> Reviewed-by: Milind Changire 
> CentOS-regression: Gluster Build System 
> Reviewed-by: Jeff Darcy 

Change-Id: Id5332f3239cb324cead34eb51cf73d426733bd46
BUG: 1462447
Signed-off-by: Niels de Vos 
Reviewed-on: https://review.gluster.org/17743
Smoke: Gluster Build System 
Reviewed-by: Milind Changire 
CentOS-regression: Gluster Build System

rpc/clnt: remove locks while notifying CONNECT/DISCONNECT

2017-07-11T13:25:31+00:00

Locking during notify was introduced as part of commit
aa22f24f5db7659387704998ae01520708869873 [1]. The fix was introduced
to fix out-of-order CONNECT/DISCONNECT events from rpc-clnt to parent
xlators [2]. However as part of handling DISCONNECT protocol/client
does unwind saved frames (with failure) waiting for responses. This
saved_frames_unwind can be a costly operation and hence ideally
shouldn't be included in the critical section of notifylock, as it
unnecessarily delays the reconnection to same brick. Also, its not a
good practise to pass control to other xlators holding a lock as it
can lead to deadlocks. So, this patch removes locking in rpc-clnt
while notifying parent xlators.

To fix [2], two changes are present in this patch:

* notify DISCONNECT before cleaning up rpc connection (same as commit
  a6b63e11b7758cf1bfcb6798, patch [3]).
* protocol/client uses rpc_clnt_cleanup_and_start, which cleans up rpc
  connection and does a start while handling a DISCONNECT event from
  rpc. Note that patch [3] was reverted as rpc_clnt_start called in
  quick_reconnect path of protocol/client didn't invoke connect on
  transport as the connection was not cleaned up _yet_ (as cleanup was
  moved post notification in rpc-clnt). This resulted in clients never
  attempting connect to bricks.

Note that one of the neater ways to fix [2] (without using locks) is
to introduce generation numbers to map CONNECT and DISCONNECTS across
epochs and ignore DISCONNECT events if they don't belong to current
epoch. However, this approach is a bit complex to implement and
requires time. So, current patch is a hacky stop-gap fix till we come
up with a more cleaner solution.

[1] http://review.gluster.org/15916
[2] https://bugzilla.redhat.com/show_bug.cgi?id=1386626
[3] http://review.gluster.org/15681

Cherry picked from commit 773f32caf190af4ee48818279b6e6d3c9f2ecc79:
> Change-Id: I62daeee8bb1430004e28558f6eb133efd4ccf418
> Signed-off-by: Raghavendra G 
> BUG: 1427012
> Reviewed-on: https://review.gluster.org/16784
> Smoke: Gluster Build System 
> Reviewed-by: Milind Changire 
> NetBSD-regression: NetBSD Build System 
> CentOS-regression: Gluster Build System 

Change-Id: I62daeee8bb1430004e28558f6eb133efd4ccf418
Reported-by: Markus Stockhausen 
Signed-off-by: Niels de Vos 
BUG: 1462447
Reviewed-on: https://review.gluster.org/17733
Smoke: Gluster Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Milind Changire 
Reviewed-by: Raghavendra G

glfsheal: prevent background self-heals

2017-07-10T07:42:29+00:00

Problem:
For a file in gfid split-brain, the parent directory ('/' during
testing) was detected as possibly undergoing heal instead of split-brain
in `heal-info` output. Also, it was not being displayed in `info
split-brain` output for the same reason. The problem was that when `glfsheal`
was run, lookup on '/' triggered a background self-heal due to which processing
of '/' during `heal info` failed to acquire locks with errno=EAGAIN.

Fix:
Set background-self-heal-count to zero while launching glfsheal.

> Reviewed-on: https://review.gluster.org/13772
> CentOS-regression: Gluster Build System 
> NetBSD-regression: NetBSD Build System 
> Smoke: Gluster Build System 
> Reviewed-by: Jeff Darcy 
(cherry picked from commit b4db625d0ccb4fdc6537ed9f6e8ebeaffd1c4873)

Change-Id: I153a7c75af71f213a4eefacf504a0f9806c528a5
BUG: 1467272
Signed-off-by: Ravishankar N 
Reviewed-on: https://review.gluster.org/17678
Smoke: Gluster Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Pranith Kumar Karampuri 
Reviewed-by: Niels de Vos

doc: release-notes for GlusterFS-3.8.13

2017-06-22T16:26:26+00:00

BUG: 1449988
Change-Id: I45feeaf31ac7502736448855923eccbdc8dfdb0c
Signed-off-by: Niels de Vos 
Reviewed-on: https://review.gluster.org/17610
CentOS-regression: Gluster Build System 
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
Reviewed-by: Markus Ueberall
Reviewed-by: Kaleb KEITHLEY