glusterfs.git, branch v3.6.5

features/quota: prevent statfs frame-loss when an error happens during

2015-08-20T09:04:42+00:00

ancestry building.

This is a backport of http://review.gluster.org/#/c/9380/

We do quota_build_ancestry in function 'quota_get_limit_dir',
suppose if quota_build_ancestry fails, then we don't have a
frame saved to continue the statfs FOP and client can hang.

> Change-Id: I92e25c1510d09444b9d4810afdb6b2a69dcd92c0
> BUG: 1178619
> Signed-off-by: Raghavendra G 
> Signed-off-by: vmallika 
> Reviewed-on: http://review.gluster.org/9380
> Tested-by: Gluster Build System 

Change-Id: Ia25cf738250fdc2c766f96c26e3c31093d534aba
BUG: 1247959
Signed-off-by: vmallika 
Reviewed-on: http://review.gluster.org/11790
Tested-by: Gluster Build System 
Reviewed-by: Raghavendra Bhat 
Reviewed-by: Raghavendra G

posix: fix mem-leak in posix xattrop

2015-08-20T07:26:28+00:00

This is a backport of http://review.gluster.org/#/c/11700/

> Change-Id: I1dd70f74a98c5875eb316f3c3e560047f128685b
> BUG: 1243890
> Signed-off-by: vmallika 
> Reviewed-on: http://review.gluster.org/11700
> Tested-by: NetBSD Build System 
> Tested-by: Gluster Build System 
> Reviewed-by: Pranith Kumar Karampuri 

Change-Id: Ia192342f01330f8b2c7a520a7cc749471af7d85f
BUG: 1247970
Signed-off-by: vmallika 
Reviewed-on: http://review.gluster.org/11794
Tested-by: Gluster Build System 
Reviewed-by: Raghavendra Bhat

nfs: make it possible to disable nfs.mount-rmtab

2015-08-18T13:19:48+00:00

When there are many NFS-clients doing very often mount/unmount actions,
the updating of the 'rmtab' can become a bottleneck and cause delays. In
these situations, the output of 'showmount' may be less important than
the responsiveness of the (un)mounting.

By setting 'nfs.mount-rmtab' to the value "/-", the cache file is not
updated anymore, and the entries are only kept in memory.

Cherry picked from commit 40407afb529f6e5fa2f79e9778c2f527122d75eb:
> Cherry picked from commit 331ef6e1a86bfc0a93f8a9dec6ad35c417873849:
>> BUG: 1169317
>> Change-Id: I40c4d8d754932f86fb2b1b2588843390464c773d
>> Reported-by: Cyril Peponnet 
>> Signed-off-by: Niels de Vos 
>> Reviewed-on: http://review.gluster.org/9223
>> Tested-by: Gluster Build System 
>> Reviewed-by: soumya k 
>> Reviewed-by: jiffin tony Thottan 
>> Reviewed-by: Kaleb KEITHLEY 
>
> This change also contains the fixes to the test-case from:
>>
>> nfs: fix spurious failure in bug-1166862.t
>>
>> In some environments, "showmount" could return an NFS-client that does
>> not start with "1". This would cause the test-case to fail. The check is
>> incorrect, the number of lines should get counted instead.
>>
>> Also moving the test-case to the .../nfs/... subdirectory.
>>
>> Cherry picked from commit ee9b35a780607daddc2832b9af5ed6bf414aebc0:
>> BUG: 1166862
>> Change-Id: Ic03aa8145ca57d78aea01564466e924b03bb302a
>> Signed-off-by: Niels de Vos 
>> Reviewed-on: http://review.gluster.org/10419
>> Tested-by: Gluster Build System 
>> Reviewed-by: Vijay Bellur 
>>
>
> Change-Id: I40c4d8d754932f86fb2b1b2588843390464c773d
> BUG: 1215385
> Signed-off-by: Niels de Vos 
> Reviewed-on: http://review.gluster.org/10379
> Tested-by: NetBSD Build System
> Tested-by: Gluster Build System 
> Reviewed-by: Vijay Bellur 

Change-Id: I40c4d8d754932f86fb2b1b2588843390464c773d
BUG: 1234096
Signed-off-by: Niels de Vos 
Reviewed-on: http://review.gluster.org/11335
Tested-by: Gluster Build System 
Reviewed-by: Raghavendra Bhat

glusterd: really get the inode size for a brick

2015-08-18T12:55:17+00:00

backport of http://review.gluster.org/#/c/8492/

The device to get the inode size from does not get passed to the tool
(tune2fs, xfs_info or the like) that is called. This is probably just an
oversight. While correcting this, cleanup some bits of the function too.

Change-Id: Ida45852cba061631fb304bc7dd5286df1a808010
BUG: 1254421
Signed-off-by: Niels de Vos 
Reviewed-on: http://review.gluster.org/8492
Tested-by: Gluster Build System 
Reviewed-by: Kaleb KEITHLEY 
Reviewed-by: Krishnan Parthasarathi 
Tested-by: Krishnan Parthasarathi 
Reviewed-on: http://review.gluster.org/11941
Reviewed-by: Raghavendra Bhat

quota: fix mem leak in quota enforcer

2015-08-18T10:39:05+00:00

This is a backport of http://review.gluster.org/#/c/11526/

Do inode_unref on parent

> Change-Id: I21d82eb8716dd73aa2dc291b3ae8506e4fb4ea8b
> BUG: 1207735
> Signed-off-by: vmallika 
> Reviewed-on: http://review.gluster.org/11526
> Reviewed-by: Krishnan Parthasarathi 
> Tested-by: Gluster Build System 
> Tested-by: NetBSD Build System 
> Reviewed-by: Raghavendra G 
> Tested-by: Raghavendra G 

Change-Id: I8f103ea96e6853d48c934b791ff4d95b226e4453
BUG: 1247964
Signed-off-by: vmallika 
Reviewed-on: http://review.gluster.org/11793
Tested-by: Gluster Build System 
Reviewed-by: Raghavendra Bhat

xml output: Fix non-uniform opErrstr xml output

2015-08-18T10:34:03+00:00

    Backport of http://review.gluster.org/#/c/11835/

Display  in case of no operrstr for
all xml output of gluster commands

Change-Id: Ie16f749f90b4642357c562012408c434cd38661f
BUG: 1218732
Signed-off-by: Avra Sengupta 
Reviewed-on: http://review.gluster.org/11921
Tested-by: Gluster Build System 
Reviewed-by: Raghavendra Bhat 
Reviewed-by: mohammed rafi  kc

glusterd: fix op-version bump up flow

2015-08-14T08:49:23+00:00

Backport of http://review.gluster.org/#/c/11798/

If a cluster is upgraded from 3.5 to latest version, gluster volume set all
cluster.op-version  will throw an error message back to the user saying
unlocking failed. This is because of trying to release a volume wise lock in
unlock phase as the lock was taken cluster wide. The problem surfaced because
the op-version is updated in commit phase and unlocking works in the v3
framework where it should have used cluster unlock. Fix is to decide which
lock/unlock is to be followed before invoking lock phase

Change-Id: I6a82251d88cfc7af36c7deec511c634a09e55004
BUG: 1250836
Signed-off-by: Atin Mukherjee 
Reviewed-on: http://review.gluster.org/11849
Tested-by: Gluster Build System 
Reviewed-by: Krishnan Parthasarathi 
Tested-by: NetBSD Build System 
Reviewed-by: Raghavendra Bhat

nfs: a unix-domain-socket should not be created as fifo

2015-07-23T10:03:02+00:00

Cherry picked from commit 381afd4f480533f212e1f62a0ccfd9dcf7248e17:
> Change-Id: Ic6a23165df1703b330636a059967c3c674dbde57
> BUG: 1235231
> Signed-off-by: Niels de Vos 
> Reviewed-on: http://review.gluster.org/11355
> Tested-by: NetBSD Build System 
> Reviewed-by: Kaleb KEITHLEY 
> Tested-by: Gluster Build System 

Change-Id: Ic6a23165df1703b330636a059967c3c674dbde57
BUG: 1244117
Signed-off-by: Niels de Vos 
Reviewed-on: http://review.gluster.org/11709
Tested-by: Gluster Build System 
Reviewed-by: Kaleb KEITHLEY 
Reviewed-by: Raghavendra Bhat

rpc-transport: socket_poller fixes for proper working of mgmt encryption

2015-07-17T07:18:41+00:00

  Backport of 8c39f14 from master

socket_poller, the polling function used by ssl own_thread, had two
issues which lead to GlusterD crashes when using management encryption

Issue 1
-------
socket_poller calls functions which require THIS to be set. But, THIS
was being set conditionally. Because of this, functions could sometimes
be called without THIS being set. For example, rpc_transport_notify
could be called for an accepted client socket without THIS being set, as
THIS was only set it the transport wasn't yet connected. This would
cause the process to crash when THIS was accessed by the called
functions.

To fix this, THIS is being set at the start of socket_poller
unconditionally.

Issue 2
-------
DISCONNECT notify was being sent on the listener transport instead of
the client transport. The DISCONNECT event was converted to a
LISTENER_DEAD event in rpcsvc_handle_disconnect, as it could not find
the listener socket of the listener socket. GlusterD was notified of a
LISTENER_DEAD event instead of a DISCONNECT and failed to remove the
client transport from its xprt_list. The transport would subsequently
be freed, leaving the xprt_list with a corrupted/invalid entry. Later,
when GlusterD would iterate over the xprt_list to send notifications, it
would crash when the invalid entry was accessed.

To fix this, DISCONNECT notification in socket_poller is sent on the
client socket, as it is done in the epoll handler.

Change-Id: I0370b7c6d7eb13de10ebf08d91a4a39dc7d64c7a
BUG: 1243700
Signed-off-by: Kaushal M 
Reviewed-on: http://review.gluster.org/11690
Tested-by: Gluster Build System 
Reviewed-by: Raghavendra G 
Reviewed-by: Raghavendra Bhat

cluster/afr: Pick gfid from poststat during fresh lookup for read child calculation

2015-07-17T07:05:36+00:00

        Backport of : http://review.gluster.org/11373

Change-Id: I03f11af082a0decf4ea084480b67e9e156964c76
BUG: 1235601
Signed-off-by: Krutika Dhananjay 
Reviewed-on: http://review.gluster.org/11408
Reviewed-by: Raghavendra Bhat 
Reviewed-by: Pranith Kumar Karampuri 
Tested-by: Raghavendra Bhat