glusterfs.git, branch v3.5.7

doc: release notes for GlusterFS 3.5.7

2015-12-12T16:05:27+00:00

BUG: 1263307
Change-Id: I5570ddf98ddb130a72cb25443d0c13dccf6f1766
Signed-off-by: Niels de Vos 
Reviewed-on: http://review.gluster.org/12957
Tested-by: Gluster Build System

glusterd.service: Ensure rpcbind is started before glusterd

2015-12-12T10:01:53+00:00

Having the rpcbind.service under the `After` option only ensures that
glusterd.service is started after rpcbind.service if both are
enabled/started at the same time. It doesn't ensure that starting
glusterd.service will start rpcbind.service.

The systemd.unit(5) man page suggests to use both the `Requires` and
`After` options to ensure that rpcbind is started before glusterd,
whenever glusterd is started.

Cherry picked from commit 23440a73bc348bbc3bb43ec397f0639ee45865fc:
> BUG: 1282915
> Change-Id: Iee69965486be08711299aba235f7b00c3e2fe7e9
> Signed-off-by: Kaushal M 
> Reviewed-on: http://review.gluster.org/12605
> Reviewed-by: Atin Mukherjee 
> Reviewed-by: Anand Nekkunti 
> Tested-by: Gluster Build System 
> Tested-by: NetBSD Build System 

Change-Id: Iee69965486be08711299aba235f7b00c3e2fe7e9
BUG: 1283542
Signed-off-by: Niels de Vos 
Reviewed-on: http://review.gluster.org/12659
Reviewed-by: Atin Mukherjee 
Tested-by: Gluster Build System

protocol/client: prevent use-after-free of frame->root

2015-12-12T10:01:34+00:00

A regression failure generated a coredump on the glusterfs-client side:

  (gdb) f 0
  #0  0x00007fba6cd76432 in client_submit_request (this=0x7fba68006fc0,
                  req=0x7fba6579aa70, frame=0x7fba5c0058cc,
                  prog=0x7fba6cfb53c0 , procnum=41,
                  cbkfn=0x7fba6cd9206d ,
                  iobref=0x0, rsphdr=0x0, rsphdr_count=0,
                  rsp_payload=0x0, rsp_payload_count=0, rsp_iobref=0x0,
                  xdrproc=0x7fba79801075 ) at
  /home/jenkins/root/workspace/rackspace-regression-2GB-triggered/xlators/protocol/client/src/client.c:324
  324                   frame->root->ngrps = ngroups;
  (gdb) l
  319                   gf_msg_debug (this->name, 0, "rpc_clnt_submit failed");
  320           }
  321
  322           if (!conf->send_gids) {
  323                   /* restore previous values */
  324                   frame->root->ngrps = ngroups;
  325                   if (ngroups <= SMALL_GROUP_COUNT)
  326                           frame->root->groups_small[0] = gid;
  327           }
  328
  (gdb) p *frame->root
  Cannot access memory at address 0x64185df000000000

After looking at this in more detail, the flow is like this:

  client_submit_request()
    |
    '- rpc_clnt_submit() // on line 314
         |
         '- cbkfn() // = client3_3_release_cbk
              |
              :- STACK_DESTROY (frame->root);
         .----'
    .----'
    |
    :- frame->root->ngrps = ngroups; // on line 324
    '

So, there is a use-after-free, and it is not needed to restore the
previous groups in frame->root.

Cherry picked from commit dc3aa7524e4974f9d02465e2e5dd6ed9b6d319e1:
> Change-Id: I9e7d712183692ed92cfc2f75cd3c2781a9db20e2
> BUG: 1281285 (was incorrect in original patch)
> Signed-off-by: Niels de Vos 
> Reviewed-on: http://review.gluster.org/12575
> Reviewed-by: Dan Lambright 
> Tested-by: NetBSD Build System 
> Reviewed-by: Jeff Darcy 

Change-Id: I9e7d712183692ed92cfc2f75cd3c2781a9db20e2
BUG: 1283691
Signed-off-by: Niels de Vos 
Reviewed-on: http://review.gluster.org/12666
Tested-by: Gluster Build System

doc: release notes for GlusterFS 3.5.6

2015-09-15T14:11:19+00:00

BUG: 1240783
Change-Id: I259f4d24ab5e7826ea304be9759f54b461853621
Signed-off-by: Niels de Vos 
Reviewed-on: http://review.gluster.org/12183

build: drop incorrect usage of 'inline'

2015-07-23T14:33:03+00:00

Newer versions of gcc complain loudly about the incorrect usage of
'inline'.

These changes have been part of commit a3cb38e3 in other branches. There
is no need to backport everything from that commit, but silencing the
warnings would be good.

Change-Id: I2319d9682b47e8533e9c179056a5152f75aeddc3
BUG: 1244147
Signed-off-by: Niels de Vos 
Reviewed-on: http://review.gluster.org/11711
Tested-by: Gluster Build System 
Reviewed-by: Kaleb KEITHLEY

nfs: a unix-domain-socket should not be created as fifo

2015-07-23T12:59:20+00:00

Cherry picked from commit 381afd4f480533f212e1f62a0ccfd9dcf7248e17:
> Change-Id: Ic6a23165df1703b330636a059967c3c674dbde57
> BUG: 1235231
> Signed-off-by: Niels de Vos 
> Reviewed-on: http://review.gluster.org/11355
> Tested-by: NetBSD Build System 
> Reviewed-by: Kaleb KEITHLEY 
> Tested-by: Gluster Build System 

Change-Id: Ic6a23165df1703b330636a059967c3c674dbde57
BUG: 1244118
Signed-off-by: Niels de Vos 
Reviewed-on: http://review.gluster.org/11710
Tested-by: Gluster Build System 
Reviewed-by: Kaleb KEITHLEY

doc: release notes for GlusterFS 3.5.5

2015-07-07T18:19:40+00:00

BUG: 1208083
Change-Id: I3559f6d03c049b55009fcd116c48b99a7434ab6c
Signed-off-by: Niels de Vos 
Reviewed-on: http://review.gluster.org/11568
Reviewed-by: Kaleb KEITHLEY 
Tested-by: Gluster Build System

nfs: make it possible to disable nfs.mount-rmtab

2015-07-07T16:11:58+00:00

When there are many NFS-clients doing very often mount/unmount actions,
the updating of the 'rmtab' can become a bottleneck and cause delays. In
these situations, the output of 'showmount' may be less important than
the responsiveness of the (un)mounting.

By setting 'nfs.mount-rmtab' to the value "/-", the cache file is not
updated anymore, and the entries are only kept in memory.

Cherry picked from commit 40407afb529f6e5fa2f79e9778c2f527122d75eb:
> Cherry picked from commit 331ef6e1a86bfc0a93f8a9dec6ad35c417873849:
>> BUG: 1169317
>> Change-Id: I40c4d8d754932f86fb2b1b2588843390464c773d
>> Reported-by: Cyril Peponnet 
>> Signed-off-by: Niels de Vos 
>> Reviewed-on: http://review.gluster.org/9223
>> Tested-by: Gluster Build System 
>> Reviewed-by: soumya k 
>> Reviewed-by: jiffin tony Thottan 
>> Reviewed-by: Kaleb KEITHLEY 
>
> This change also contains the fixes to the test-case from:
>>
>> nfs: fix spurious failure in bug-1166862.t
>>
>> In some environments, "showmount" could return an NFS-client that does
>> not start with "1". This would cause the test-case to fail. The check is
>> incorrect, the number of lines should get counted instead.
>>
>> Also moving the test-case to the .../nfs/... subdirectory.
>>
>> Cherry picked from commit ee9b35a780607daddc2832b9af5ed6bf414aebc0:
>> BUG: 1166862
>> Change-Id: Ic03aa8145ca57d78aea01564466e924b03bb302a
>> Signed-off-by: Niels de Vos 
>> Reviewed-on: http://review.gluster.org/10419
>> Tested-by: Gluster Build System 
>> Reviewed-by: Vijay Bellur 
>>
>
> Change-Id: I40c4d8d754932f86fb2b1b2588843390464c773d
> BUG: 1215385
> Signed-off-by: Niels de Vos 
> Reviewed-on: http://review.gluster.org/10379
> Tested-by: NetBSD Build System
> Tested-by: Gluster Build System 
> Reviewed-by: Vijay Bellur 

GLUSTERD_WORKDIR has been added to tests/include.rc and is not
configurable through ./configure like on newer branches. It is not
suitable to change the GlusterD working directory in an update for a
stable release.

Change-Id: I40c4d8d754932f86fb2b1b2588843390464c773d
BUG: 1166862
Signed-off-by: Niels de Vos 
Reviewed-on: http://review.gluster.org/11336
Tested-by: Gluster Build System 
Reviewed-by: jiffin tony Thottan 
Reviewed-by: Kaleb KEITHLEY

features/quota : Fix XML output for quota list command

2015-07-07T16:11:38+00:00

This is a backport of http://review.gluster.org/#/c/9481/

> Sample output:
> ---------------
>
> Sample 1)
> ----------
> [root@snapshot-28 glusterfs]# gluster volume quota vol1 list /dir1 /dir4
> /dir5 --xml
> 
> 
>   0
>   0
>   
>   
>     
>       /dir1
>       10.0MB
>       80%
>       0Bytes
>       10.0MB
>     
>     
>       /dir4
>       No such file or directory
>     
>     
>       /dir5
>       No such file or directory
>     
>   
> 
>
> Sample 2)
> ---------
> gluster volume quota vol1 list --xml
> 
> 
>   0
>   0
>   
>   
> 
> 
> 
>   
>     
>       /dir
>       10.0MB
>       80%
>       0Bytes
>       10.0MB
>     
>     
>       /dir1
>       10.0MB
>       80%
>       0Bytes
>       10.0MB
>     
>   
> 
>
> Change-Id: I8a8d83cff88f778e5ee01fbca07d9f94c412317a
> BUG: 1185259
> Signed-off-by: Sachin Pandit 
> Reviewed-on: http://review.gluster.org/9481
> Reviewed-by: Vijaikumar Mallikarjuna 
> Tested-by: Gluster Build System 
> Reviewed-by: Kaushal M 

Change-Id: Ibdf51db626a07e68b5ace98140877f6d21918c20
BUG: 1231641
Signed-off-by: vmallika 
Reviewed-on: http://review.gluster.org/11220
Tested-by: Gluster Build System 
Reviewed-by: Sachin Pandit 
Reviewed-by: Niels de Vos

quota: Validate NULL inode from the entries received in readdirp_cbk

2015-06-28T19:52:19+00:00

This is a backport of http://review.gluster.org/#/c/10416/

> In quota readdirp_cbk, inode ctx filled for the all entries
> received.
> In marker readdirp_cbk, files/directories are inspected for
> dirty

> There is no guarantee that entry->inode is populated.
> If entry->inode is NULL, this needs to be treated as readdir
>
> Change-Id: Id2d17bb89e4770845ce1f13d73abc2b3c5826c06
> BUG: 1215550
> Signed-off-by: vmallika 
> Reviewed-on: http://review.gluster.org/10416
> Tested-by: NetBSD Build System
> Tested-by: Gluster Build System 
> Reviewed-by: Raghavendra G 
> Tested-by: Raghavendra G 

Change-Id: If6578984ab1a33a3bdbaf0ec169f7c9548991144
BUG: 1217433
Signed-off-by: vmallika 
Reviewed-on: http://review.gluster.org/10472
Tested-by: Gluster Build System 
Reviewed-by: Niels de Vos