glusterfs.git, branch v3.4.6beta1

mount/fuse: Handle fd resolution failures

2014-09-02T11:30:47+00:00

Backport from http://review.gluster.org/#/c/8402, BZ 1126048

Problem:
Even when the fd resolution failed, the fop is continuing on the
new graph which may not have valid inode. This lead to NULL layout
subvols in dht which lead to crash in fsync after graph migration.

Fix:
- Remove resolution error handling in FUSE_FOP as it was only added
  to handle fd migration failures.
- check in fuse_resolve_done for fd resolution failures and fail the
  fop right away.
- loc resolution failures are already handled in the corresponding
  fops.
- Return errno from state->resolve.op_errno in resume functions.
- Send error to fuse on frame allocation failures.
- Removed unused variable state->resolved
- Removed unused macro FUSE_FOP_COOKIE

Change-Id: I3f3129b9b4fc34ff1fe07218e6924a027346a95e
BUG: 1123289
Signed-off-by: Kaleb S. KEITHLEY 
Reviewed-on: http://review.gluster.org/8562
Tested-by: Gluster Build System 
Reviewed-by: Raghavendra G

cluster/afr: Fix memory leak of file-path in self-heal-daemon

2014-08-27T13:46:38+00:00

        Backport of http://review.gluster.org/4790

Note: Only the part which fixes the memory leak is backported

shd event has path which needs to be freed as part of circular buffer cleanup.
This patch introduces the functionality so that self-heal-daemon can use it.

Change-Id: I3f3823d5587eda2fcb278f0fdb89123a31c9d786
BUG: 1119894
Signed-off-by: Pranith Kumar K 
Reviewed-on: http://review.gluster.org/8541
Tested-by: Gluster Build System 
Reviewed-by: Ravishankar N 
Reviewed-by: Kaleb KEITHLEY

NFS: stripe-xlator should pass EOF at end of READDIR

2014-08-27T13:43:33+00:00

NFS READDIR replies are made of a header, a sequence of
entries, and a EOF flag. When GlusterFS's NFS server is
used along with stripe xlator, it fails to set the EOF
flag, which violates NFS RFC and confuses some clients.

The bug is caused because nfs xlator sets EOF if it gets
op_errno set to ENOENT. That value is produced in storage
xlator and propagated through server, client, and other
xlators until stripe xlator handles it. stripe only passed
op_errno if op_ret < 0, which is not the case here. This
change set adds a special case for that situation to fix
the problem.

Cherry picked from commit 9b5231e5c98b8cfa116838287c7a14042702795f:
> Change-Id: Ie6db94b0515292387cfb04c1e4a9363f34fcd19a
> BUG: 1130969
> Reported-by: Emmanuel Dreyfus 
> Signed-off-by: Niels de Vos 
> Reviewed-on: http://review.gluster.org/8493
> Tested-by: Gluster Build System 
> Reviewed-by: Santosh Pradhan 
> Reviewed-by: Kaleb KEITHLEY 
> Reviewed-by: Emmanuel Dreyfus 
> Tested-by: Emmanuel Dreyfus 

Change-Id: Ie6db94b0515292387cfb04c1e4a9363f34fcd19a
BUG: 1132392
Signed-off-by: Niels de Vos 
Reviewed-on: http://review.gluster.org/8510
Reviewed-by: Santosh Pradhan 
Tested-by: Gluster Build System

doc/release-nodes: release notes for 3.4.5 GA

2014-07-23T17:00:48+00:00

Change-Id: I359c280b67006473a836c90771b28598fe712c80
BUG: 1110456
Signed-off-by: Kaleb S. KEITHLEY 
Reviewed-on: http://review.gluster.org/8370

nfs: prevent assertion error with MOUNT over UDP

2014-07-08T18:35:19+00:00

see http://review.gluster.org/#/c/8258/, http://review.gluster.org/8241;
and BZs 1116997, 1116503, respectively.

The MOUNT service over UDP runs in a separate thread. This thread does
not have the correct *THIS xlator set. *THIS points to the global (base)
xlator structure, but GF_CALLOC() requires it to be the NFS-xlator so
that assertions can get validated correctly.

This is solved by passing the NFS-xlator to the pthread function, and
setting the *THIS pointer explicitly in the new thread.

It seems that on occasion (needs further investigation) MOUNT over UDP
does not unregister itself. There can also be issues when the kernel NLM
implementation has been registered at portmap/rpcbind, so adding some
unregister procedures in the cleanup of the test-cases.

Change-Id: Iea3bafd65bf480f2b12da91875c73571594d52d3
BUG: 1117256
Signed-off-by: Kaleb S. KEITHLEY 
Reviewed-on: http://review.gluster.org/8262
Tested-by: Gluster Build System 
Reviewed-by: Niels de Vos 
Reviewed-by: Santosh Pradhan

performance/quick-read: Check for iobuf and iobref before unref.

2014-07-08T11:52:13+00:00

In the absence of this check, iobuf_unref() can cause a log flood
for read operations.

Change-Id: Ib8beef6e55b69ecfb566bf61a96215ef0d0d74dc
BUG: 1116514
Signed-off-by: Vijay Bellur 
Reviewed-on: http://review.gluster.org/8242
Tested-by: Gluster Build System 
Reviewed-by: Humble Devassy Chirammal 
Reviewed-by: Prashanth Pai 
Reviewed-by: Kaleb KEITHLEY

fuse: fix memory leak in fuse_getxattr()

2014-06-25T11:46:48+00:00

The fuse_getxattr() function was not freeing fuse_state_t resulting in a
memory leak. As a result, when continuous writes (run dd command in a loop)
were done from a FUSE mount point, the OOM killer killed the client
process (glusterfs).

Manual backport of: http://review.gluster.org/#/c/5392/, provided
by Martin Svec .

BUG: 1112844
Change-Id: Ic723675c53384d48c79ad1b11b21c1b17fb56866
Reviewed-on: http://review.gluster.org/8164
Tested-by: Gluster Build System 
Reviewed-by: Ravishankar N 
Reviewed-by: Kaleb KEITHLEY

doc: Fix peer probe deficiencies

2014-06-20T12:52:27+00:00

Added the command to probe the first server to assign it a hostname

Change-Id: I67f35553df74718f23cd8453dc7854a44c61be11
BUG: 1095596
Reviewed-on: http://review.gluster.org/7854
Tested-by: Gluster Build System 
Reviewed-by: Kaleb KEITHLEY

cluster/dht: Don't do extra unref in dht-migration checks

2014-06-18T12:17:34+00:00

Problem:
syncop_open used to perform a ref in syncop_open_cbk so the extra
unref was needed but now syncop_open_cbk does not take a ref so no
need to do extra unref.

Fix:
remove the extra fd_unref and let dht_local_wipe do the final unref.

Change-Id: Ibe8f9a678d456a0c7bff175306068b5cd297ecc4
BUG: 961615
Signed-off-by: Pranith Kumar K 
Signed-off-by: Vijay Bellur 
Reviewed-on: http://review.gluster.org/8029
Tested-by: Gluster Build System 
Tested-by: Joe Julian 
Reviewed-by: Kaleb KEITHLEY

release-notes: 3.4.4

2014-05-25T15:15:01+00:00

Change-Id: I9553500016a6a56d1aaf7bc7f90249bed95fa1b1
BUG: 1095324
Signed-off-by: Kaleb S. KEITHLEY 
Reviewed-on: http://review.gluster.org/7866