glusterfs.git, branch v3.3.0qa43

performance/quick-read: fix race-conditions in qr_unlink.

2012-05-23T13:46:07+00:00

The list of fds on which open needs to be done as part of unlink,
was being modified at different places using different locks.
This resulted in a race-condition where open was marked as in-transit,
but fdctx was removed from the list of fds on which open was being
sent even before open was done. Because of this, open_in_transit would
be set forever (as an open was never actually sent, there would be no
open_cbk called and hence we could not reset the variable), blocking
all the future fd based fops on this fd.

Change-Id: Ie84a55bee578869a9a060a094ba28480e7643ae8
BUG: 819490
Signed-off-by: Raghavendra G 
Reviewed-on: http://review.gluster.com/3372
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

cluster/dht: Handle ENOENT failure in dht_rmdir_opendir_cbk

2012-05-23T09:11:35+00:00

We should not treat ENOENT as a failure in rmdir.

BUG: 806761
Change-Id: I847cfd9fb31880b8200cf04aa795fed3c870f71a
Signed-off-by: shishir gowda 
Reviewed-on: http://review.gluster.com/3402
Tested-by: Gluster Build System 
Reviewed-by: Amar Tumballi 
Reviewed-by: Vijay Bellur

features/marker: use the gfid from the stat structure instead of inode

2012-05-23T09:10:24+00:00

in fresh lookup, the inode would not have linked to the inode table
until the fop reaches back to protocol/server, thus it would not contain
the gfid within it (gfid would still be null). So use the stat structure
to get the gfid in lookup callback instead of inode's gfid.

Change-Id: Id70277f0228f3db64b05d613108cfb4f070197e6
BUG: 791087
Signed-off-by: Raghavendra Bhat 
Reviewed-on: http://review.gluster.com/3400
Tested-by: Gluster Build System 
Reviewed-by: Amar Tumballi 
Reviewed-by: Vijay Bellur

performance/md-cache: use mdc_fsetattr_cbk as the callback if setattr is on a fd

2012-05-23T09:04:23+00:00

Change-Id: I114a16055540e0cd3317b83b329600251ffe03c3
BUG: 823886
Signed-off-by: Raghavendra Bhat 
Reviewed-on: http://review.gluster.com/3404
Tested-by: Gluster Build System 
Reviewed-by: Amar Tumballi 
Reviewed-by: Vijay Bellur

glusterfs/rebalance: Register cbk for glusterfs_rebalance_event_notify

2012-05-23T09:02:10+00:00

In case of n/w failures, cbk needs to be passed to
mgmt_submit_request

BUG: 822086
Change-Id: Ie443902b94a09e11a2696b89de44a11fb477ca3e
Signed-off-by: shishir gowda 
Reviewed-on: http://review.gluster.com/3403
Tested-by: Gluster Build System 
Reviewed-by: Amar Tumballi 
Reviewed-by: Raghavendra Bhat 
Reviewed-by: Vijay Bellur

glusterd / mountbroker: warn if mountbroker-root permissions are suspected to be too strict

2012-05-23T09:01:02+00:00

At the level of mountbroker, this is a best effort, as "too strict" depends
on the purpose it's being used for (thus we just warn, don't err). However,
it's a good guess, as it stands for existing use cases of mountbroker.

Change-Id: Ic5e7d6cb44ced5509c05e0ee8a9043252470683f
BUG: 765214
Signed-off-by: Csaba Henk 
Reviewed-on: http://review.gluster.com/3171
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati 
Reviewed-on: http://review.gluster.com/3406
Reviewed-by: Vijay Bellur

geo-rep / gsyncd: typo fix

2012-05-23T09:00:08+00:00

fix topy.

Change-Id: I84df3e850dd24d9e86713dfa401c603a84a81ca6
BUG: 763302
Signed-off-by: Csaba Henk 
Reviewed-on: http://review.gluster.com/3375
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur 
Reviewed-on: http://review.gluster.com/3407

geo-rep / gsyncd: recognize ECONNABORTED as termination of aux glusterfs

2012-05-23T08:59:47+00:00

Don't dump stack, rather log the "glusterfs session went down" message.

If the aux glusterfs is already dead when we try to do some file
operation, we get a failure with ENOTCONN, which is already handled
as above. However, it's also possible that glusterfs dies while we
are in a syscall into it -- in that case we get ECONNABORTED, and
so far then we end up with an ugly stack strace. From now on we
take ECONNABORTAD as well into consideration.

Nb. wrt. testing: it's not easy to synthetically force the aux glusterfs
to end this way; for that we have to provoke gsyncd into intensive
synchronization. I succeeded in that with the following ruby oneliner:

ruby -rcgi -e '
  Dir.chdir($*[0])
  a=[]
  Thread.new { loop { while a.size >= 100; File.delete a.shift; end; sleep 1 }}
  loop { a<
Reviewed-on: http://review.gluster.com/3078
Tested-by: Gluster Build System 
Reviewed-by: Venky Shankar 
Reviewed-by: Vijay Bellur 
Reviewed-on: http://review.gluster.com/3408

glusterd: On-wire changes required for probe/detach errstr

2012-05-23T07:04:04+00:00

This patch changes the on-wire structures for 'peer probe' and 'peer detach' to
include op_errstr. These changes have been backported from patches
feb99ca (glusterd, cli: Enable errstr for peer probe) and
3213a4e (glusterd,cli: Enable errstr for peer detach). The remaining changes
will be included later on.

Change-Id: I6e8e917f5ad928b80862d301c364cd4df56bb4c0
BUG: 816840
Signed-off-by: Kaushal M 
Reviewed-on: http://review.gluster.com/3387
Tested-by: Gluster Build System 
Reviewed-by: Amar Tumballi

geo-rep / gsyncd: fixes regarding the command invocation framework

2012-05-22T18:25:23+00:00

Some of the bugs to fix were found by the following stress-test:
make "glusterfs --client-pid=-1" exit immediately on slave
side.

Also fix eintr_wrap which should not "adopt" exceptions generated
by the wrapped call, by re-raising them as GsyncdError.

Change-Id: Ia0d39e0635975ebbbf98d86e1e26f3122e1ed6ff
BUG: 764678
Signed-off-by: Csaba Henk 
Reviewed-on: http://review.gluster.com/3258
Tested-by: Gluster Build System 
Reviewed-by: Venky Shankar 
Reviewed-on: http://review.gluster.com/3409
Reviewed-by: Vijay Bellur