glusterfs.git, branch v3.3.0.5rhs-39

features/locks: fcntl(3) on F_GETLK must return first conflicting lock

2012-12-17T17:48:59+00:00

- Added test program, getlk_owner.c to capture the bug when regressed.

Change-Id: Id6055a1e64609b9701560e50a9767f387ddadce7
BUG: 869724
Signed-off-by: Krishnan Parthasarathi 
Reviewed-on: https://code.engineering.redhat.com/gerrit/1993
Reviewed-by: Vijay Bellur 
Tested-by: Vijay Bellur

cluster/dht: Add "afr.readdir-failover=off" option the rebalance process

2012-12-17T17:46:31+00:00

By failing over readdir (default behaviour), rebalance could get duplicate
files, as readdir would re-read from offset 0. Rebalance should not attempt
to migrate these files again.

Additionally, we need to handle these cases as failure in rebalance crawl.

BUG: 859387
Change-Id: I77c5c14176bb4d9e593efd6d4739fbc8233bd0c5
Signed-off-by: shishir gowda 
Reviewed-on: https://code.engineering.redhat.com/gerrit/1991
Reviewed-by: Vijay Bellur 
Tested-by: Vijay Bellur

cluster/afr: Provide option to disable readdir failover

2012-12-17T17:45:38+00:00

In a replica pair unlike files, directories may not have their
content in same order, so readdir for same (offset, size) may
not give same entries on both the sobvolumes of replica pair.
Switching over from one subvolume to another may not be a good
idea sometimes. It may lead to duplicate entries or fewer entries
or both. This patch provides a way to disable readdir-failover
so that applications like rebalance can retry if they want to.

Change-Id: I02e5762e7f8a5847eaf54356e5d6b5f49fe6c609
BUG: 859387
Signed-off-by: Pranith Kumar K 
Reviewed-on: https://code.engineering.redhat.com/gerrit/1989
Reviewed-by: Vijay Bellur 
Tested-by: Vijay Bellur

geo-rep / gsyncd: play nicely with peer multiplexing when setting a checkpoint

2012-12-17T17:41:03+00:00

From upstream commit 01217e4e16677b13c7febc66e4e4ca3f0025739b:
> The gsyncd invocation that instruments the "geo-rep config" command is
> multiplexed over peers to ensure the uniformity of configuration.
> In general, that works well, but checkpoint setting is a special case,
> because (unlike other instances of config-set) it is logged (as recording
> of checkpoint events is part of the feature).
>
> Problem is that the path components leading to the log file are
> created only on the original node, where gsyncd was started.
> Therefore the logging attempt will fail on the other nodes.
>
> Fix: ignore if opening the logfile on behalf of checkpoint setting
> fails with ENOENT.
>
> Change-Id: I677f3f081bf4b9e3ba4d25d58979d86931e6beb4
> BUG: 881997
> Signed-off-by: Csaba Henk 
> Reviewed-on: http://review.gluster.org/4248
> Reviewed-by: Niels de Vos 
> Tested-by: Christos Triantafyllidis 
> Reviewed-by: Christos Triantafyllidis 
> Reviewed-by: Anand Avati 

Change-Id: I83b2cb7f78cf8613b78d3c8ff8e7b3828050cfc3
BUG: 881736
Signed-off-by: Niels de Vos 
Reviewed-on: https://code.engineering.redhat.com/gerrit/1929
Reviewed-by: Vijay Bellur 
Tested-by: Vijay Bellur

geo-replication: catch select.error on select()

2012-12-17T17:39:18+00:00

From upstream commit 15bf92d53c72774e2fd7aba146644a2e460e543f:
> tailer() in resource.py does not correctly catch exceptions from
> select(). select() can raise an instance of the select.error class and
> the current expression only catches ValueError (and the instance will
> have reference called selecterror).
>
> The geo-rep log contains a call trace like this:
> > E [syncdutils:190:log_raise_exception] : FAIL:
> > Traceback (most recent call last):
> > File "/usr/libexec/glusterfs/python/syncdaemon/syncdutils.py", line 216, in twrap
> > tf(*aa)
> > File "/usr/libexec/glusterfs/python/syncdaemon/resource.py", line 123, in tailer
> > poe, _ ,_ = select([po.stderr for po in errstore], [], [], 1)
> > File "/usr/libexec/glusterfs/python/syncdaemon/syncdutils.py", line 276, in select
> > return eintr_wrap(oselect.select, oselect.error, *a)
> > File "/usr/libexec/glusterfs/python/syncdaemon/syncdutils.py", line 269, in eintr_wrap
> > return func(*a)
> > error: (9, 'Bad file descriptor')
>
> BUG: 880308
> Change-Id: I2babe42918950d0e9ddb3d08fa21aa3548ccf7c5
> Signed-off-by: Niels de Vos 
> Reviewed-on: http://review.gluster.org/4233
> Reviewed-by: Peter Portante 
> Reviewed-by: Csaba Henk 
> Tested-by: Gluster Build System 

BUG: 880308
Change-Id: Iece1f50c0064853669d1dd4a777f77f10e2fd0dc
Upstream-bug: 886808 (changed after upstream merge)
Signed-off-by: Niels de Vos 
Reviewed-on: https://code.engineering.redhat.com/gerrit/1927
Reviewed-by: Vijay Bellur 
Tested-by: Vijay Bellur

fuse: have setxattr on geo-rep related xattrs take effect

2012-12-17T17:37:35+00:00

From upstream commit 6e3244a131b6d25141bef0cbc59968d3271f8ea3:
> In http://review.gluster.com/3687 setxattr was made to a noop for
> geo-rep special clients, with the exception of some special ones,
> relevant to geo-rep. These exceptions were all in trusted namespace.
>
> That's no good, because with a mountbroker (unprivileged) setup,
> the relevant attributes are in system namespace. So here we
> just let setxattr through for any geo-rep related xattr, regardless
> of namespace.
>
> Change-Id: I261141293b7db955a2e8b2405b4510cb10a42694
> BUG: 848447
> Signed-off-by: Csaba Henk 
> Reviewed-on: http://review.gluster.com/3821
> Tested-by: Gluster Build System 
> Reviewed-by: Venky Shankar 
> Reviewed-by: Anand Avati 

BUG: 883827
Change-Id: I86a044d52ad3e679b21ff3832ee6536c5c6809fb
Signed-off-by: Niels de Vos 
Reviewed-on: https://code.engineering.redhat.com/gerrit/1925
Reviewed-by: Vijay Bellur 
Tested-by: Vijay Bellur

cluster/dht: fail fix-layout if any of the subvol is down

2012-12-17T17:34:27+00:00

If any subvolume is down, and a layout is re-written and hash
values change, entry names in the downed subvol can be reused
in the other subvol which got the same hash range. when the
downed subvol is brought back up, duplicate entried might appear

Also separated handling of ENOSPC and ENOTCONN error.

Change-Id: I1a49a689f6891a32128adcfb92dc46f39eaddec7
BUG: 860599
Signed-off-by: shishir gowda 
Reviewed-on: https://code.engineering.redhat.com/gerrit/1898
Reviewed-by: Vijay Bellur 
Tested-by: Vijay Bellur

storage/posix: if create returns EXIST, donot set gfid/xattrs

2012-12-17T17:31:23+00:00

Change-Id: I9f2b75b10bde428d36d6516aa09c18e590d17ed9
BUG: 864801
Signed-off-by: shishir gowda 
Reviewed-on: https://code.engineering.redhat.com/gerrit/1896
Reviewed-by: Vijay Bellur 
Tested-by: Vijay Bellur

protocol/client: Conditional logging in client3_1_unlink_cbk

2012-12-17T09:19:04+00:00

Change-Id: Ic6f4e276a5ab6906e4b3ad28e9b8c7eed52b3080
BUG: 861925
Signed-off-by: Venkatesh Somyajulu 
Reviewed-on: https://code.engineering.redhat.com/gerrit/1985
Reviewed-by: Vijay Bellur 
Tested-by: Vijay Bellur

cluster/afr : Edited log message in afr_sh_entry_expunge_entry_cbk

2012-12-17T09:18:32+00:00

Change-Id: Ic5256650652416e3a043b9e4640748ce1fa50e83
BUG: 860246
Signed-off-by: Venkatesh Somyajulu 
Reviewed-on: https://code.engineering.redhat.com/gerrit/1986
Reviewed-by: Vijay Bellur 
Tested-by: Vijay Bellur