glusterfs.git, branch heal-info

glusterd: Add warning and abort in case of failures in migration during remove-brick commit

2019-08-25T05:19:11+00:00

Problem -
Currently remove-brick commit goes through even though there were files
that failed to migrate or were skipped. There is no warning raised to the user.
Solution-
Add a check in the remove brick staging phase to verify if the status of the
rebalnce process is complete but there has been failures or some skipped files
while migration, In this case user will be given a warning and remove-brick
commit. User will need to use the force option to remove the bricks.

Fixes: bz#1514683
Signed-offby- Vishal Pandey 

Change-Id: I014d0f0afb4b2fac35ab0de52227f98dbae079d5

cli - group files to set volume options supports comments

2019-08-25T05:18:33+00:00

Modified parsing of group files in such a way that line that starts with
"#" would be treated as comments

Fixes: bz#1423442

Change-Id: Id85ceb49f8f9c920d4ea551f60bd28767279d4be
Signed-off-by: Barak Sason

cluster/afr - Unused variables

2019-08-24T04:28:00+00:00

-Minor change to if-else structure to avoid code duplication.
-Added logging in case method calls fails

CID: 1394654
Updates: bz#789278

Change-Id: Ibef4450dc89ddd3bf951303d5b87f503924fd250
Signed-off-by: Barak Sason

Revert "glusterd: (storhaug) remove ganesha (843e1b0)"

2019-08-24T02:08:57+00:00

please note as an additional change, macro GLUSTERD_GET_SNAP_DIR
moved from glusterd-store.c to glusterd-snapshot-utils.h

Change-Id: I811efefc148453fe32e4f0d322e80455447cec71
updates: #663
Signed-off-by: Jiffin Tony Thottan

Revert "packaging: (ganesha) remove glusterfs-ganesha subpackage and related files"

2019-08-24T02:08:57+00:00

Until 3.12, glusterd had an option to setup HA cluster for nfs-ganesha using pacemaker
and corosync. But later infavour of "Storhaug" Project, this functionality was removed
from the codebase. Since there is not much development happening towards storhaug,
it better to keep back old working HA solution for nfs-ganesha with bit improvements.

Planned improvements :

* add an option in nfs-ganesha enable to set ganesha without HA.

* Handle usage of export id's properly in the scripts.

Change-Id: I1d60c8970bfc20035cf674d7b2705dfd4819647e
updates: #663
Signed-off-by: Jiffin Tony Thottan

posix: log aio_error return codes in posix_fs_health_check

2019-08-22T10:29:35+00:00

Problem: Sometime brick is going down to health check thread is
         failed without logging error codes return by aio system calls.
         As per aio_error man page it returns a positive error number
         if the asynchronous I/O operation failed.

Solution: log aio_error return codes in error message

Change-Id: I2496b1bc16e602b0fd3ad53e211de11ec8c641ef
Fixes: bz#1744519
Signed-off-by: Mohit Agrawal

geo-rep: Fix the name of changelog archive file

2019-08-22T10:02:42+00:00

Background:
The processed changelogs are archived each month in a single tar file.
The default format is "archive_YYYYMM.tar" which is specified as "%%Y%%m"
in configuration file.

Problem:
The created changelog archive file didn't have corresponding year
and month. It created as "archive_%Y%m.tar" on python2 only systems.

Cause and Fix:
Geo-rep expects "%Y%m" after the ConfigParser reads it from config file.
Since it was "%%Y%%m" in config file, geo-rep used to get correct value
"%Y%m" in python3 and "%%Y%%m" in python2 which is incorrect.
The fix can be to use "%Y%m" in config file but that fails in python3.
So the fix is to use "RawConfigParser" in geo-rep and use "%Y%m". This
works both in python2 and python3.

Change-Id: Ie5b7d2bc04d0d53cd1769e064c2d67aaf95d557c
fixes: bz#1741890
Signed-off-by: Kotresh HR

ctime: Fix incorrect realtime passed to frame->root->ctime

2019-08-22T05:35:15+00:00

On systems that don't support "timespec_get"(e.g., centos6), it
was using "clock_gettime" with "CLOCK_MONOTONIC" to get unix epoch
time which is incorrect. This patch introduces "timespec_now_realtime"
which uses "clock_gettime" with "CLOCK_REALTIME" which fixes
the issue.

Change-Id: I57be35ce442d7e05319e82112b687eb4f28d7612
Signed-off-by: Kotresh HR 
fixes: bz#1743652

nlm: check if nlm4 is initialized in nlm_priv

2019-08-22T04:54:11+00:00

Otherwise, gnfs will crash in following steps.
1) gluster v set  nfs.disable off
2) gluster v set  nfs.nlm off
3) kill -SIGUSR1 
4) gnfs crash with SIGSEGV as follows:
nlm_priv (this=this@entry=0x7f1ad00173b0) at nlm4.c:2742
0x00007f1acf89d29d in nfs_priv (this=0x7f1ad00173b0) at nfs.c:1662
0x00007f1ae2941085 in gf_proc_dump_single_xlator_info (trav=trav@entry=0x7f1ad00173b0) at statedump.c:502
0x00007f1ae29410b8 in gf_proc_dump_per_xlator_info (top=top@entry=0x7f1ad00173b0) at statedump.c:519

fixes: bz#1739360
Change-Id: Ib9b207a4ccb3226dbc2c449b77de348cbc9a3d3c
Signed-off-by: Xie Changlong

storage/posix - Fixing a coverity issue

2019-08-21T14:01:40+00:00

Fixed a resource leak of variable 'pfd'

CID: 1400673
Updates: bz#789278

Change-Id: I78e1e8a89e0604b56e35a75c25d436b35db096c3
Signed-off-by: Barak Sason