From dbfe779f3049e6fbc2394bdacdb57165d51dc3f3 Mon Sep 17 00:00:00 2001 From: shishir gowda Date: Tue, 4 Jun 2013 16:43:35 +0530 Subject: cluster/dht: Prevent crash in dht_linkfile_lookup Assign local = frame->local before dereferencing local->linkfile.linkfile_cbk. Additionally, fail if op_ret is non_zero. Change-Id: I96a2f34ba29887da9ccaae38a644431cf7c43265 BUG: 966858 Signed-off-by: shishir gowda Reviewed-on: http://review.gluster.org/5141 Reviewed-by: Amar Tumballi Tested-by: Gluster Build System --- xlators/cluster/dht/src/dht-linkfile.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'xlators/cluster/dht') diff --git a/xlators/cluster/dht/src/dht-linkfile.c b/xlators/cluster/dht/src/dht-linkfile.c index 13d791a8f..39d72ae63 100644 --- a/xlators/cluster/dht/src/dht-linkfile.c +++ b/xlators/cluster/dht/src/dht-linkfile.c @@ -30,13 +30,13 @@ dht_linkfile_lookup_cbk (call_frame_t *frame, void *cookie, xlator_t *this, dht_local_t *local = NULL; call_frame_t *prev = NULL; - if (!op_ret) - goto out; - local = frame->local; prev = cookie; conf = this->private; + if (op_ret) + goto out; + is_linkfile = check_is_linkfile (inode, stbuf, xattr, conf->link_xattr_name); if (!is_linkfile) -- cgit