From b9fdbc079025ffd743305cee868e02f653326419 Mon Sep 17 00:00:00 2001 From: Krutika Dhananjay Date: Mon, 13 May 2013 14:59:21 +0530 Subject: glusterd: Perform NULL check on rsp.op_errstr before using it Change-Id: Id18b215a91cf016964ea98d2f414293b82167d24 BUG: 962362 Signed-off-by: Krutika Dhananjay Reviewed-on: http://review.gluster.org/4992 Reviewed-by: Krishnan Parthasarathi Reviewed-by: Jeff Darcy Tested-by: Gluster Build System --- xlators/mgmt/glusterd/src/glusterd-syncop.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xlators/mgmt/glusterd/src/glusterd-syncop.c b/xlators/mgmt/glusterd/src/glusterd-syncop.c index 59df582db..41530090e 100644 --- a/xlators/mgmt/glusterd/src/glusterd-syncop.c +++ b/xlators/mgmt/glusterd/src/glusterd-syncop.c @@ -481,7 +481,7 @@ _gd_syncop_brick_op_cbk (struct rpc_req *req, struct iovec *iov, args->errstr = gf_strdup (rsp.op_errstr); out: - if (strcmp (rsp.op_errstr, "") != 0) + if ((rsp.op_errstr) && (strcmp (rsp.op_errstr, "") != 0)) free (rsp.op_errstr); free (rsp.output.output_val); -- cgit