From 2123e83976b1ca77bb253cabda3092e79c406145 Mon Sep 17 00:00:00 2001 From: shishir gowda Date: Fri, 25 Oct 2013 12:05:01 +0530 Subject: mgmt/glusterd: Fix glusterd crash due to extra unref Change-Id: I9d600b4d971b7fdcd54da50e4a069eab19648fa6 Original-author: Rajesh Joseph Signed-off-by: shishir gowda --- xlators/mgmt/glusterd/src/glusterd-snapshot.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/xlators/mgmt/glusterd/src/glusterd-snapshot.c b/xlators/mgmt/glusterd/src/glusterd-snapshot.c index c1094966b..f8ce8a654 100644 --- a/xlators/mgmt/glusterd/src/glusterd-snapshot.c +++ b/xlators/mgmt/glusterd/src/glusterd-snapshot.c @@ -2277,8 +2277,11 @@ glusterd_handle_snapshot_fn (rpcsvc_request_t *req) goto out; } ret = dict_set_dynstr (dict, "host-uuid", host_uuid); - if (ret) + if (ret) { + GF_FREE (host_uuid); goto out; + } + } else { gf_log (this->name, GF_LOG_ERROR, "request dict length is %d", @@ -2320,7 +2323,6 @@ glusterd_handle_snapshot_fn (rpcsvc_request_t *req) out: if (ret) { - GF_FREE (host_uuid); if (err_str[0] == '\0') snprintf (err_str, sizeof (err_str), "Operation failed"); -- cgit