From 1feaebfe0ae140ecafd5c37a0ce1bb5f0a1ac0cf Mon Sep 17 00:00:00 2001 From: Anand Avati Date: Wed, 7 Aug 2013 01:30:42 -0700 Subject: md-cache: fix xattr caching code in getxattr Bad condition check, fix it! Change-Id: I6e047de70f77d7b98b2ca771a467f14a76fd62fe BUG: 994392 Signed-off-by: Anand Avati Reviewed-on: http://review.gluster.org/5513 Reviewed-by: Amar Tumballi Tested-by: Amar Tumballi Tested-by: Gluster Build System --- xlators/performance/md-cache/src/md-cache.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/xlators/performance/md-cache/src/md-cache.c b/xlators/performance/md-cache/src/md-cache.c index 2f52cbe58..f10d5fc43 100644 --- a/xlators/performance/md-cache/src/md-cache.c +++ b/xlators/performance/md-cache/src/md-cache.c @@ -1689,7 +1689,7 @@ mdc_getxattr (call_frame_t *frame, xlator_t *this, loc_t *loc, const char *key, if (ret != 0) goto uncached; - if (!xattr || dict_get (xattr, (char *)key)) { + if (!xattr || !dict_get (xattr, (char *)key)) { ret = -1; op_errno = ENODATA; } @@ -1751,7 +1751,7 @@ mdc_fgetxattr (call_frame_t *frame, xlator_t *this, fd_t *fd, const char *key, if (ret != 0) goto uncached; - if (!xattr || dict_get (xattr, (char *)key)) { + if (!xattr || !dict_get (xattr, (char *)key)) { ret = -1; op_errno = ENODATA; } -- cgit