| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also populated the error message in case of snapshot create, list, info and delete failure.
When snapshot list, info or delete is issued, if the entered snapname/volname does not exist then populate error string along with logging.
Change-Id: I632d25110bc63ff0e4ac98b27e2f410f7ccbb990
Signed-off-by: Sachin Pandit <spandit@redhat.com>
Reviewed-on: http://review.gluster.org/7203
Reviewed-by: Vijaikumar Mallikarjuna <vmallika@redhat.com>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Tested-by: Rajesh Joseph <rjoseph@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This Patch includes cli change and few backend changes.
Syntax :
gluster snapshot restore <snap-name>
** Also removed unwanted snapshot remove parsing code.
Change-Id: Ie32590ccd4080da9409fd16c543866c14fae28f5
Signed-off-by: Sachin Pandit <spandit@redhat.com>
Reviewed-on: http://review.gluster.org/7191
Reviewed-by: Vijaikumar Mallikarjuna <vmallika@redhat.com>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Tested-by: Rajesh Joseph <rjoseph@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Now instead of creating volume store files first we constructing
the in-memory volinfo first and then generate the backend store
files. This gives lot of flexibility in restore operation.
This patch also fixes the read-only issue with restored snaps.
Change-Id: I51032228a5212fc3b90dc6e93f3539af3eb36074
BUG: 1064688
Signed-off-by: Rajesh Joseph <rjoseph@redhat.com>
Reviewed-on: http://review.gluster.org/7209
Reviewed-by: Sachin Pandit <spandit@redhat.com>
Reviewed-by: Vijaikumar Mallikarjuna <vmallika@redhat.com>
|
|
|
|
|
|
|
|
|
|
| |
Ported upstream volume-locks.t as mgmt-v3-locks.t
Change-Id: Id4824716cde4ac54efbf1c1dd9a5f530b0324e39
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/7190
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Tested-by: Rajesh Joseph <rjoseph@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
| |
Created framework to process single volume lock, single snap lock,
multiple volume locks, multiple snap locks, and multiple snap and
volume locks requests.
Change-Id: I3f87bdec0bf142d6a1fd3f9d9f5012cc44eaf4bd
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/7189
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Tested-by: Rajesh Joseph <rjoseph@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Within the same namespace allowing mgmt_v3 lock engine to handle
entities of valid types. Postfixing the element's name with the entity
type allows us to perform locking operations on different elements
of different entitites at the same time.
For example: A volume named test, will acquire a lock on the name test_vol,
while a snap named test will acquire lock on the name test_snap, and thus be
allowed to co-exist in the same namespace.
Change-Id: I611d1a59b707e497d35a37bdca5a66e29a1b6f06
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/7188
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Tested-by: Rajesh Joseph <rjoseph@redhat.com>
|
|
|
|
|
|
|
|
|
|
| |
Renaming volume locks as mgmt_v3 locks
Change-Id: I2a324e2b8e1772d7b165fe96ce8ba5b902c2ed9a
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/7187
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Tested-by: Rajesh Joseph <rjoseph@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Snapshot volume bricks are mounted under /var/run/gluster/snaps
folder. In the latest machines /var/run is a symbolic link to
/run folder. In such cases if we use /var/run then there would
be mismatch between mtab entry for the mount and the folder
where we actually mount.
Therefore this patch will get the correct folder and also create
it if the folder is missing.
Change-Id: I267aa7f3e171b486c5b3bb2a9f88cbd4be0e47ea
BUG: 1072253
Signed-off-by: Rajesh Joseph <rjoseph@redhat.com>
Reviewed-on: http://review.gluster.org/7140
|
|
|
|
|
|
|
|
|
|
|
|
| |
This changes includes snap-driven based list and info changes:
Change-Id: Ie82a2a3c785baa36892ca0cd97a958a2ae819d4c
Signed-off-by: Vijaikumar M <vmallika@redhat.com>
Signed-off-by: Sachin Pandit <spandit@redhat.com>
Reviewed-on: http://review.gluster.org/7139
Reviewed-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Tested-by: Rajesh Joseph <rjoseph@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
With the snap driven approach, While creating the snapshot, We have to
mention the snap-name first and then the volumes to be associated with
that. Corresponding changes has been made in glusterd.
While deleting the snapshot, we have to mention only the snapname.
Corresponding changes has been made in glusterd.
CLI changes for the same can be found here:
http://review.gluster.org/#/c/6947/
Change-Id: I8bd8f471da5b728165da5f331faad3dde3486823
Signed-off-by: Vijaikumar M <vmallika@redhat.com>
Reviewed-on: http://review.gluster.org/7123
Reviewed-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Tested-by: Rajesh Joseph <rjoseph@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
| |
Syntax:
gluster snapshot delete <snapname>
Change-Id: I5de7b9a79eeba12e4f0b8abfbe96a2db738f25c0
Signed-off-by: Sachin Pandit <spandit@redhat.com>
Reviewed-on: http://review.gluster.org/7144
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Tested-by: Rajesh Joseph <rjoseph@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
syntax:
gluster snapshot list [volname]
This will list all the snapshots (or) snapshots of a particular volume.
Change-Id: If879e06fe13caf2236f48df345857f833ae83c5b
Signed-off-by: Sachin Pandit <spandit@redhat.com>
Reviewed-on: http://review.gluster.org/7143
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Tested-by: Rajesh Joseph <rjoseph@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
snapshot info [(snapname | volume <volname>)].
Snapshot info will list all the basic information.
Syntax :
** gluster snapshot info **
This will list all the snap object along with that
it also prints the snaps volume name, UUID and
status.
** gluster snapshot info <snap-name> **
This will list only the mentioned snap object and
also snap volume information along with that
** gluster snapshot info volume <volname> **
This will list all the snaps present in the
mentioned volume.
Change-Id: I1e92774cb08eaebbfe141b9b47d1a887d76916a4
Signed-off-by: Sachin Pandit <spandit@redhat.com>
Reviewed-on: http://review.gluster.org/6996
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Tested-by: Rajesh Joseph <rjoseph@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Syntax:
gluster snapshot create <snap-name> <vol-names>
[description <description>] [force].
New change:
With the snap driven approach, While creating the snapshot, We have
to mention the snap-name first and then the volumes to be associated
with that. Corresponding changes has been made in CLI,and all the
hyphenated options are replaced by keywords.
Previous Syntax :
snapshot create <volnames> [-n <snap-name/cg-name>] [-d <description>]
Change-Id: I9b4caf9629fdc3195b682190d999db2ecd9ce3e1
Signed-off-by: Sachin Pandit <spandit@redhat.com>
Reviewed-on: http://review.gluster.org/6947
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Tested-by: Rajesh Joseph <rjoseph@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently snapshot volfiles are stored at:
<workdir>/vols/<volname>/snaps/<snapvol>
With snap driven approach we need to store the volfiles at:
<workdir>/snaps/<snapname>/<snapvol>
Change-Id: I8efdd5db29833b2b06b64a900cbb4c9b9a5d36b6
Signed-off-by: Vijaikumar M <vmallika@redhat.com>
Signed-off-by: Sachin Pandit <spandit@redhat.com>
Reviewed-on: http://review.gluster.org/7006
Reviewed-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Tested-by: Rajesh Joseph <rjoseph@redhat.com>
|
|
|
|
|
|
|
|
|
|
| |
Change-Id: Ic988ffeb26a49b4c6ac0d4a8ca33124f2192744c
BUG: 1064768
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/6997
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Tested-by: Rajesh Joseph <rjoseph@redhat.com>
|
|
|
|
|
|
|
|
|
| |
Admin guide for snapshot management. Provide details of snapshot cli.
Change-Id: I83cf082a8e2c1546d8fcac2e9b234e236024220a
Signed-off-by: Rajesh Joseph <rjoseph@redhat.com>
Reviewed-on: http://review.gluster.org/7027
Reviewed-by: Sachin Pandit <spandit@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Added the check on snap-max-limit in snapshot_create_prevalidate. Now snapshot
creation will fail if snap count reaches max limit.
Change-Id: I5b1cf8441f02c32085d2f6f5fd8902cb61031af5
BUG: 1049834
Author: Joseph Fernandes <josferna@redhat.com>
Signed-off-by: Joseph Fernandes <josferna@redhat.com>
Signed-off-by: Rajesh Joseph <rjoseph@redhat.com>
Reviewed-on: http://review.gluster.org/6981
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
|
|
|
|
|
|
|
|
|
| |
Change-Id: I886a003c1bd9959105eab64a098b66a7303d4bba
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-on: http://review.gluster.org/7001
Reviewed-by: Sachin Pandit <spandit@redhat.com>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Tested-by: Rajesh Joseph <rjoseph@redhat.com>
|
|
|
|
|
|
|
|
|
|
| |
Change-Id: I6315d5b96ac72f6520037d4e96e29e5862aec346
Signed-off-by: Sachin Pandit <spandit@redhat.com>
Reviewed-on: http://review.gluster.org/6867
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Tested-by: Rajesh Joseph <rjoseph@redhat.com>
|
|
|
|
|
|
|
|
| |
Change-Id: I60b635f275498b285aa34702ce6ca41bfb7e01a0
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-on: http://review.gluster.org/6995
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Tested-by: Rajesh Joseph <rjoseph@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
| |
Using snap uuid to create lvm snapshot will solve the problem of having
'-' in the snap name or snap name is too long.
Change-Id: If204f02a8f5de599fb409d06c7893ef3542a6300
BUG: 1045333
Signed-off-by: Vijaikumar M <vmallika@redhat.com>
Reviewed-on: http://review.gluster.org/6709
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Tested-by: Rajesh Joseph <rjoseph@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
supported
To check if setactivationskip is supported or not, we run lvcreate --help
and look for the setactivationskip flag, and accordingly issue lvcreate
with or without the said flag.
Change-Id: Ief349674ea3f7ceff6b7051b1a5104257e547ce2
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/6776
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Tested-by: Rajesh Joseph <rjoseph@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
| |
Basically loading the read-only translator on the server side,
during the snapshot create.
Change-Id: I88dcce85b5f3f00e438f08165a8177b064f004fe
BUG: 1040934
Signed-off-by: Sachin Pandit <spandit@redhat.com>
Reviewed-on: http://review.gluster.org/6694
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Tested-by: Rajesh Joseph <rjoseph@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
| |
This framework can be used to write functional testcase for snapshot
operations
Change-Id: I850d0e5021ac6c053d89c58567648e1bff273b19
Signed-off-by: Vijaikumar M <vmallika@redhat.com>
Reviewed-on: http://review.gluster.org/6798
Reviewed-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Tested-by: Rajesh Joseph <rjoseph@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
| |
Change-Id: I88eeffd64c521db78b9e7539ae57ed046854cb63
BUG: 1049278
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/6903
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-by: Sachin Pandit <spandit@redhat.com>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Tested-by: Rajesh Joseph <rjoseph@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
unmounting.
Change-Id: Idf0cf63429212142795e1aeb4fd4962b51620426
BUG: 1049353
Signed-off-by: Sachin Pandit <spandit@redhat.com>
Reviewed-on: http://review.gluster.org/6772
Reviewed-by: Vijaikumar Mallikarjuna <vmallika@redhat.com>
Reviewed-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Tested-by: Rajesh Joseph <rjoseph@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Instead performing store on all the snaps of the volume when a new snap
is created, store only the new snap's info. Otherwise with more and more
snapshots in the volume, time creation for new snapshot becomes very large
as glusterd has to store all the snapshots related info everytime (that too by
doing fsyncs)
Change-Id: I0e005d1d4c044b07a8abde8e6ba55e66a1bbd590
BUG: 1059146
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-on: http://review.gluster.org/6841
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Tested-by: Rajesh Joseph <rjoseph@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
| |
Introducing a wrapper function glusterd_txn_opinfo_init(),
to initialize the opinfo to be set in the txn_id engine.
Removed glusterd_op_fini_ctx() as the txn opinfo should
only be cleared by glusterd_clear_txn_opinfo().
Change-Id: I17e85a162d6a3bca79941f8603d0c2b579f0d194
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
|
|\
| |
| |
| | |
into development
|
| |
| |
| |
| |
| |
| |
| |
| | |
On receiving peer disconnect, release volume locks held
by the disconnected peer
Change-Id: I0e36ba2fba4761225092ce2fb7b9b3c2d2dca0ad
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
|
|/
|
|
|
|
|
|
| |
Move the code part that need to executed at the origin glusterd to a
seperate function.
Change-Id: Ieb53fbd4fb12e3e4d5087db306be37616657ee04
Signed-off-by: Vijaikumar M <vmallika@redhat.com>
|
|\
| |
| |
| | |
barrier" into development
|
| |
| |
| |
| |
| |
| |
| | |
* Remove the reference to client object from server_state_t structure
Change-Id: Ic2dbf9dd487f1177bd889fe481e63bc063fd6183
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
|
|/
|
|
|
| |
Change-Id: I2d07717ee01751e481571ce420b0f84711ea9597
Signed-off-by: Sachin Pandit <spandit@redhat.com>
|
|\
| |
| |
| | |
the pointer" into development
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The response structure filled up in server_submit_reply is local to the
function (i.e stack allocated) whose address is stored in the barrier
payload to use later while sending the replies. But after the function
is exited (server_submit_reply) the pointer is not valid and contains
invalid data, which either leads in a segfault due to illegal memory
access or reply not being sent as the total length of the reply obtained
from that memory might not be valid.
So instead of saving the pointer inside the payload, save the complete
reply itself.
Change-Id: I7d0b7b181584865199357a67165b99bf35def5ab
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
|
|\ \ |
|
| | |
| | |
| | |
| | |
| | |
| | | |
Change-Id: Ife2395a92997168bb147a7db4bba346d3adc916b
BUG: 1048126
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Creating a separate list for snaps taken, as cluttering
snaps in the volume list does not look neat.
Change-Id: Ida4a183e95e8694b85ebb5a680d06b7d29a460a0
BUG: 1040947
Signed-off-by: Sachin Pandit <spandit@redhat.com>
|
| | |
| | |
| | |
| | |
| | |
| | | |
Change-Id: I9663342e49073a172667220d4839b2beb65ffc0e
BUG: 1040947
Signed-off-by: Sachin Pandit <spandit@redhat.com>
|
|\ \ \
| | | |
| | | |
| | | | |
deleted" into development
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Currently, on deleting snapshot , there is no warning message displayed
to the user.
A Warning must be displayed before the snapshot is deleted as follows:
Deleting snap will erase all information about the snap. Do you want to
continue? (y/n)
Change-Id: I60f4f346da36b6564576c7482f5989a17d4bb5e1
BUG: 1048216
Signed-off-by: Vijaikumar M <vmallika@redhat.com>
|
|/ / /
| | |
| | |
| | |
| | |
| | |
| | | |
Some changes were missed in resolving conflict in the restore patch.
Change-Id: Ie0cf01237bf975027056c10bb3681e122334f83e
Signed-off-by: Rajesh Joseph <rjoseph@redhat.com>
|
|\ \ \
| | | |
| | | |
| | | | |
of vol delete." into development
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
delete.
Change-Id: I5056c0e46015278bd8d0c39307e4671fd4259961
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
|
|\ \ \ \ |
|
| | |_|/
| |/| |
| | | |
| | | |
| | | | |
Change-Id: Id98d6e2d0436621486c311889f128077558e59f8
Signed-off-by: Sachin Pandit <spandit@redhat.com>
|
|\ \ \ \
| | | | |
| | | | |
| | | | | |
into development
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Change-Id: I34cf0f2ee42074bb40edda875e0b290069d856ae
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
|