summaryrefslogtreecommitdiffstats
path: root/xlators/mgmt/glusterd/src/glusterd-snapshot.c
diff options
context:
space:
mode:
Diffstat (limited to 'xlators/mgmt/glusterd/src/glusterd-snapshot.c')
-rw-r--r--xlators/mgmt/glusterd/src/glusterd-snapshot.c22
1 files changed, 18 insertions, 4 deletions
diff --git a/xlators/mgmt/glusterd/src/glusterd-snapshot.c b/xlators/mgmt/glusterd/src/glusterd-snapshot.c
index be910f73a..830903818 100644
--- a/xlators/mgmt/glusterd/src/glusterd-snapshot.c
+++ b/xlators/mgmt/glusterd/src/glusterd-snapshot.c
@@ -715,6 +715,7 @@ glusterd_add_snap (glusterd_volinfo_t *volinfo, glusterd_snap_t *snap)
unlock:
UNLOCK (&volinfo->lock);
out:
+ gf_log ("", GF_LOG_TRACE, "Returning %d", ret);
return ret;
}
@@ -876,12 +877,13 @@ glusterd_add_snap_cg (glusterd_conf_t *conf, glusterd_snap_cg_t *cg)
last = entry;
}
list_add_tail (&cg->cg_list, &conf->snap_cg);
+
gf_log (THIS->name, GF_LOG_DEBUG, "Added CG %s (%s) @ %"PRIu64,
cg->cg_name, uuid_utoa(cg->cg_id), count);
ret = 0;
out:
+ gf_log ("", GF_LOG_TRACE, "Returning %d", ret);
return ret;
-
}
glusterd_snap_cg_t*
@@ -2276,7 +2278,6 @@ glusterd_snap_create (glusterd_volinfo_t *volinfo,
}
snap->snap_status = GD_SNAP_STATUS_IN_USE;
-
out:
if (ret) {
if (snap) {
@@ -2287,6 +2288,8 @@ out:
GF_FREE (snap);
}
}
+
+ gf_log ("", GF_LOG_TRACE, "Returning %d", ret);
return ret;
}
@@ -2519,6 +2522,7 @@ glusterd_take_snapshot (glusterd_brickinfo_t *brickinfo, char *volname,
}
out:
+ gf_log ("", GF_LOG_TRACE, "Returning %d", ret);
return ret;
}
@@ -2623,6 +2627,8 @@ out:
}
if (mtab)
endmntent (mtab);
+
+ gf_log ("", GF_LOG_TRACE, "Returning %d", ret);
return ret;
}
@@ -2767,6 +2773,8 @@ glusterd_do_snap (glusterd_volinfo_t *volinfo, char *name, dict_t *dict,
out:
if (ret)
glusterd_volinfo_delete (snap_volume);
+
+ gf_log ("", GF_LOG_TRACE, "Returning %d", ret);
return ret;
}
@@ -3029,6 +3037,7 @@ glusterd_snapshot_create_commit (dict_t *dict, char **op_errstr,
}
}
out:
+ gf_log ("", GF_LOG_TRACE, "Returning %d", ret);
return ret;
}
@@ -3180,7 +3189,7 @@ glusterd_snapshot_config_commit (dict_t *dict, char **op_errstr,
goto out;
}
out:
- gf_log (this->name, GF_LOG_DEBUG, "Returning %d", ret);
+ gf_log (this->name, GF_LOG_TRACE, "Returning %d", ret);
return ret;
}
@@ -3213,6 +3222,11 @@ glusterd_snapshot (dict_t *dict, char **op_errstr, dict_t *rsp_dict)
case (GF_SNAP_OPTION_TYPE_CREATE):
ret = glusterd_snapshot_create_commit (dict, op_errstr,
rsp_dict);
+ if (ret) {
+ gf_log (this->name, GF_LOG_ERROR, "Failed to "
+ "create snapshot");
+ goto out;
+ }
break;
case GF_SNAP_OPTION_TYPE_CONFIG:
@@ -3238,7 +3252,7 @@ glusterd_snapshot (dict_t *dict, char **op_errstr, dict_t *rsp_dict)
ret = 0;
out:
- gf_log (this->name, GF_LOG_DEBUG, "Returning %d", ret);
+ gf_log (this->name, GF_LOG_TRACE, "Returning %d", ret);
return ret;
}