glusterfs-snapshot.git/xlators/protocol, branch work

protocol/server: eliminate an unnecessary frame create and destroy

2013-10-02T23:57:22+00:00

connection_cleanup creates a frame solely so that it can be copied.

But the process of copying creates a new frame, and there's nothing
apparently magic about the one being copied; we can eliminate an
unnecessary create and destroy.

Which in the grand scheme of things probably isn't the worst thing
we do, but it's low hanging fruit.

Change-Id: I4a23b84a53e086137b7d4167ad8c20b673d1ffe5
Signed-off-by: Kaleb S. KEITHLEY 
Reviewed-on: http://review.gluster.org/6019
Reviewed-by: Amar Tumballi 
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

rpc/rpc-lib: rpcsvc should reply when rpc_err is set

2013-09-11T19:32:33+00:00

Problem:
When requests are received on a connection before setvolume
is done, creating frame from the requests fail because there is
no association of the transport with the conn(i.e. xl_private).
xl_private is set only on set_volume. In such cases error response
is not sent from server xlator to that request because of which
operations on mount point are hanging.

Fix:
Set actor return value to RPCSVC_ACTOR_ERROR so that response is sent
even in these cases.

Change-Id: I74d7bc6849fde6c734008d67c1f4bc9d9f7a84f9
BUG: 1006367
Signed-off-by: Pranith Kumar K 
Reviewed-on: http://review.gluster.org/5892
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

features/locks : Improves debuggability of inode/entry locks.

2013-09-03T13:50:40+00:00

Prints, in the statedump, the information about the mount that
performed the inode/entry lk.

For the entrylks that are granted after a blocked state, the
blocked time is not printed. A patch for that will be sent
later.

Change-Id: Ib0c1ed21fa9328b435f96b590dd343f59814a08d
BUG: 915629
Signed-off-by: Anuradha Talur 
Reviewed-on: http://review.gluster.org/5712
Reviewed-by: Pranith Kumar Karampuri 
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

libglusterfs/client_t client_t implementation, phase 1

2013-07-30T05:22:21+00:00

Implementation of client_t

The feature page for client_t is at
http://www.gluster.org/community/documentation/index.php/Planning34/client_t

In addition to adding libglusterfs/client_t.[ch] it also extracts/moves
the locktable functionality from xlators/protocol/server to libglusterfs,
where it is used; thus it may now be shared by other xlators too.

This patch is large as it is. Hooking up the state dump is left to do
in phase 2 of this patch set.

(N.B. this change/patch-set supercedes previous change 3689, which was
corrupted during a rebase. That change will be abandoned.)

BUG: 849630
Change-Id: I1433743190630a6d8119a72b81439c0c4c990340
Signed-off-by: Kaleb S. KEITHLEY 
Reviewed-on: http://review.gluster.org/3957
Tested-by: Gluster Build System 
Reviewed-by: Amar Tumballi

core: increase the auxillary group limit to 65536

2013-07-24T18:36:46+00:00

Make the allocation of groups dynamic and increase the limit
to 65536.

Change-Id: I702364ff460e3a982e44ccbcb3e337cac9c2df51
BUG: 953694
Signed-off-by: Anand Avati 
Reviewed-on: http://review.gluster.org/5111
Reviewed-by: Xavier Hernandez 
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

protocol/server: Initialize connection variable

2013-06-28T06:31:52+00:00

Change-Id: I46badd812e9b936911ddd2793cef7ce30ec220a6
BUG: 979237
Signed-off-by: Pranith Kumar K 
Reviewed-on: http://review.gluster.org/5266
Reviewed-by: Raghavendra G 
Tested-by: Gluster Build System

rpc: duplicate request cache for nfs

2013-06-21T17:33:49+00:00

Duplicate request cache provides a mechanism for detecting
duplicate rpc requests from clients. DRC caches replies
and on duplicate requests, sends the cached reply instead of
re-processing the request.

Change-Id: I3d62a6c4aa86c92bf61f1038ca62a1a46bf1c303
BUG: 847624
Signed-off-by: Rajesh Amaravathi 
Reviewed-on: http://review.gluster.org/4049
Reviewed-by: Rajesh Joseph 
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

protocol/server: print connection-id in fop failure logs.

2013-06-19T06:27:20+00:00

Currently we have tuple (server-xlator-name, callid) for identifying
a call. However it does not uniquely identify the operation when there
are multiple clients (since operations from all clients go through same
server). Adding connection-id resolves this ambiguity.
Also printing connection-id helps diagnose failures associated with
connection state (like fds, locks).

Change-Id: I13563bd06ee9b72fc1a10d239f77db5183658573
BUG: 963540
Signed-off-by: Raghavendra G 
Reviewed-on: http://review.gluster.org/5011
Reviewed-by: Vijay Bellur 
Tested-by: Gluster Build System

protocol/rpc: move latest added procedures to the end of the array

2013-06-17T16:34:56+00:00

While looking at the newly introduced procedures FALLOCATE and DISCARD,
it seems that these were added with already existing procedure numbers.
This makes the protocol incompatible with existing roll-outs.

It is very confusing when new procedures are added somewhere in the
middle of the array. This will cause the number of existing procedures
to change. It is much preferred to add new procedures at the end of the
array. This changes not only corrects the enum that generates the
procedure numbers, but also the ordering in the client and server
fops-array for clarity.

Correcting this greatly simplifies adding support for these new
procedures in Wireshark and will prevent confusion to the people reading
network traces (with or without Wireshark).

Change-Id: Ib9e7978531d016c7230d756b855cb94cb0793b0f
BUG: 974976
Signed-off-by: Niels de Vos 
Reviewed-on: http://review.gluster.org/5215
Tested-by: Gluster Build System 
Reviewed-by: Brian Foster 
Reviewed-by: Anand Avati

glusterfs: discard (hole punch) support

2013-06-13T21:37:43+00:00

Add support for the DISCARD file operation. Discard punches a hole
in a file in the provided range. Block de-allocation is implemented
via fallocate() (as requested via fuse and passed on to the brick
fs) but a separate fop is created within gluster to emphasize the
fact that discard changes file data (the discarded region is
replaced with zeroes) and must invalidate caches where appropriate.

BUG: 963678
Change-Id: I34633a0bfff2187afeab4292a15f3cc9adf261af
Signed-off-by: Brian Foster 
Reviewed-on: http://review.gluster.org/5090
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati