<feed xmlns='http://www.w3.org/2005/Atom'>
<title>glusterfs-snapshot.git/xlators/protocol/server/src, branch development</title>
<subtitle></subtitle>
<link rel='alternate' type='text/html' href='http://git.gluster.org/cgit/glusterfs-snapshot.git/'/>
<entry>
<title>protocol/server: get the client object from frame-&gt;root even in barrier</title>
<updated>2014-01-15T11:34:36+00:00</updated>
<author>
<name>Raghavendra Bhat</name>
<email>raghavendra@redhat.com</email>
</author>
<published>2014-01-15T11:33:38+00:00</published>
<link rel='alternate' type='text/html' href='http://git.gluster.org/cgit/glusterfs-snapshot.git/commit/?id=ba3cf3a90bd9ba9648252f12fcfce4f0a66c3b74'/>
<id>ba3cf3a90bd9ba9648252f12fcfce4f0a66c3b74</id>
<content type='text'>
* Remove the reference to client object from server_state_t structure

Change-Id: Ic2dbf9dd487f1177bd889fe481e63bc063fd6183
Signed-off-by: Raghavendra Bhat &lt;raghavendra@redhat.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
* Remove the reference to client object from server_state_t structure

Change-Id: Ic2dbf9dd487f1177bd889fe481e63bc063fd6183
Signed-off-by: Raghavendra Bhat &lt;raghavendra@redhat.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>protocol/server: copy the response into the payload instead of using the pointer</title>
<updated>2014-01-13T04:53:39+00:00</updated>
<author>
<name>Raghavendra Bhat</name>
<email>raghavendra@redhat.com</email>
</author>
<published>2014-01-09T14:52:58+00:00</published>
<link rel='alternate' type='text/html' href='http://git.gluster.org/cgit/glusterfs-snapshot.git/commit/?id=bae3b86cc44adb43fb70f674da1d9e31c60bba96'/>
<id>bae3b86cc44adb43fb70f674da1d9e31c60bba96</id>
<content type='text'>
The response structure filled up in server_submit_reply is local to the
function (i.e stack allocated) whose address is stored in the barrier
payload to use later while sending the replies. But after the function
is exited (server_submit_reply) the pointer is not valid and contains
invalid data, which either leads in a segfault due to illegal memory
access or reply not being sent as the total length of the reply obtained
from that memory might not be valid.

So instead of saving the pointer inside the payload, save the complete
reply itself.

Change-Id: I7d0b7b181584865199357a67165b99bf35def5ab
Signed-off-by: Raghavendra Bhat &lt;raghavendra@redhat.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The response structure filled up in server_submit_reply is local to the
function (i.e stack allocated) whose address is stored in the barrier
payload to use later while sending the replies. But after the function
is exited (server_submit_reply) the pointer is not valid and contains
invalid data, which either leads in a segfault due to illegal memory
access or reply not being sent as the total length of the reply obtained
from that memory might not be valid.

So instead of saving the pointer inside the payload, save the complete
reply itself.

Change-Id: I7d0b7b181584865199357a67165b99bf35def5ab
Signed-off-by: Raghavendra Bhat &lt;raghavendra@redhat.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>protocol/server: Unbarrier in a thread.</title>
<updated>2013-11-19T04:24:03+00:00</updated>
<author>
<name>shishir gowda</name>
<email>sgowda@redhat.com</email>
</author>
<published>2013-11-18T03:55:24+00:00</published>
<link rel='alternate' type='text/html' href='http://git.gluster.org/cgit/glusterfs-snapshot.git/commit/?id=a9af293525e8f8dae4ecfb0048fbb60c45dd3a62'/>
<id>a9af293525e8f8dae4ecfb0048fbb60c45dd3a62</id>
<content type='text'>
Currently if the queue length is large, the response to glusterd
will get blocked

Change-Id: I713e8803a087b5131a35050ca027165562d7e1b7
Signed-off-by: shishir gowda &lt;sgowda@redhat.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Currently if the queue length is large, the response to glusterd
will get blocked

Change-Id: I713e8803a087b5131a35050ca027165562d7e1b7
Signed-off-by: shishir gowda &lt;sgowda@redhat.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>protocol/server: init the barrier queue</title>
<updated>2013-11-15T10:04:14+00:00</updated>
<author>
<name>shishir gowda</name>
<email>sgowda@redhat.com</email>
</author>
<published>2013-11-13T11:34:29+00:00</published>
<link rel='alternate' type='text/html' href='http://git.gluster.org/cgit/glusterfs-snapshot.git/commit/?id=6ac146597ad78ce5ca84ac532e2b0e21d261620e'/>
<id>6ac146597ad78ce5ca84ac532e2b0e21d261620e</id>
<content type='text'>
Change-Id: Ib39b244fd29d837a0640dba505eeff42e0a22f9a
Signed-off-by: shishir gowda &lt;sgowda@redhat.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Change-Id: Ib39b244fd29d837a0640dba505eeff42e0a22f9a
Signed-off-by: shishir gowda &lt;sgowda@redhat.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>snapshot: Merge conflict resolution</title>
<updated>2013-11-15T09:23:44+00:00</updated>
<author>
<name>shishir gowda</name>
<email>sgowda@redhat.com</email>
</author>
<published>2013-11-15T09:23:44+00:00</published>
<link rel='alternate' type='text/html' href='http://git.gluster.org/cgit/glusterfs-snapshot.git/commit/?id=f0503527548a13cd1af2db640488b4c01857fc4d'/>
<id>f0503527548a13cd1af2db640488b4c01857fc4d</id>
<content type='text'>
Signed-off-by: shishir gowda &lt;sgowda@redhat.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Signed-off-by: shishir gowda &lt;sgowda@redhat.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>protocol/server: avoid rpc reply to the client only if the fop is barriered</title>
<updated>2013-11-15T09:09:42+00:00</updated>
<author>
<name>Raghavendra Bhat</name>
<email>raghavendra@redhat.com</email>
</author>
<published>2013-10-24T11:40:22+00:00</published>
<link rel='alternate' type='text/html' href='http://git.gluster.org/cgit/glusterfs-snapshot.git/commit/?id=4e1c76a68f2208822c503a555206f21a3da52256'/>
<id>4e1c76a68f2208822c503a555206f21a3da52256</id>
<content type='text'>
* Now, reply submission to the client is avoided even if the
  fop is not barriered

Change-Id: I9d503935c4d851f5dd0e8e4be0fea9c92e636ff3
Signed-off-by: Raghavendra Bhat &lt;raghavendra@redhat.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
* Now, reply submission to the client is avoided even if the
  fop is not barriered

Change-Id: I9d503935c4d851f5dd0e8e4be0fea9c92e636ff3
Signed-off-by: Raghavendra Bhat &lt;raghavendra@redhat.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>protocol/server: Implement barriering mechanisms for fops</title>
<updated>2013-11-15T07:00:00+00:00</updated>
<author>
<name>shishir gowda</name>
<email>sgowda@redhat.com</email>
</author>
<published>2013-08-20T11:00:06+00:00</published>
<link rel='alternate' type='text/html' href='http://git.gluster.org/cgit/glusterfs-snapshot.git/commit/?id=83417fbfeb4262eaed78b6c086f9d249361ebb65'/>
<id>83417fbfeb4262eaed78b6c086f9d249361ebb65</id>
<content type='text'>
Barriering allows cbk's responses to be held back until either a
timeout or a un-barrier event is received.

The event is triggered by a brick-op.

barrier-timeout, barrier-queue-lenght, and barrier-fops are currently
exposed as a xlator-options only

Change-Id: Ifb62d5b2bd2fbb35aca3b537e534156c877ce3a6
Signed-off-by: shishir gowda &lt;sgowda@redhat.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Barriering allows cbk's responses to be held back until either a
timeout or a un-barrier event is received.

The event is triggered by a brick-op.

barrier-timeout, barrier-queue-lenght, and barrier-fops are currently
exposed as a xlator-options only

Change-Id: Ifb62d5b2bd2fbb35aca3b537e534156c877ce3a6
Signed-off-by: shishir gowda &lt;sgowda@redhat.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>gNFS: RFE for NFS connection behavior</title>
<updated>2013-11-15T00:07:02+00:00</updated>
<author>
<name>Santosh Kumar Pradhan</name>
<email>spradhan@redhat.com</email>
</author>
<published>2013-10-28T07:16:37+00:00</published>
<link rel='alternate' type='text/html' href='http://git.gluster.org/cgit/glusterfs-snapshot.git/commit/?id=e479660d9dd8bf7017c7dc78ccfa6edd9c51ec7a'/>
<id>e479660d9dd8bf7017c7dc78ccfa6edd9c51ec7a</id>
<content type='text'>
Implement reconfigure() for NFS xlator so that volume set/reset wont
restart the NFS server process. But few options can not be reconfigured
dynamically e.g. nfs.mem-factor, nfs.port etc which needs NFS to be
restarted.

Change-Id: Ic586fd55b7933c0a3175708d8c41ed0475d74a1c
BUG: 1027409
Signed-off-by: Santosh Kumar Pradhan &lt;spradhan@redhat.com&gt;
Reviewed-on: http://review.gluster.org/6236
Tested-by: Gluster Build System &lt;jenkins@build.gluster.com&gt;
Reviewed-by: Rajesh Joseph &lt;rjoseph@redhat.com&gt;
Reviewed-by: Anand Avati &lt;avati@redhat.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Implement reconfigure() for NFS xlator so that volume set/reset wont
restart the NFS server process. But few options can not be reconfigured
dynamically e.g. nfs.mem-factor, nfs.port etc which needs NFS to be
restarted.

Change-Id: Ic586fd55b7933c0a3175708d8c41ed0475d74a1c
BUG: 1027409
Signed-off-by: Santosh Kumar Pradhan &lt;spradhan@redhat.com&gt;
Reviewed-on: http://review.gluster.org/6236
Tested-by: Gluster Build System &lt;jenkins@build.gluster.com&gt;
Reviewed-by: Rajesh Joseph &lt;rjoseph@redhat.com&gt;
Reviewed-by: Anand Avati &lt;avati@redhat.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>server/rpc: bricks goes offline and comes back online, with lots of "No such file or directory" log messages</title>
<updated>2013-11-13T07:38:03+00:00</updated>
<author>
<name>Vikhyat Umrao</name>
<email>vumrao@redhat.com</email>
</author>
<published>2013-11-12T12:41:23+00:00</published>
<link rel='alternate' type='text/html' href='http://git.gluster.org/cgit/glusterfs-snapshot.git/commit/?id=eeac099cf405849f07989c410968e77f95acdc77'/>
<id>eeac099cf405849f07989c410968e77f95acdc77</id>
<content type='text'>
Problem:
Messages were getting logged very frequently at log level INFO.

[2013-03-01 11:34:28.029222] I [server3_1-fops.c:1541:server_open_cbk] vol-server: 993888: OPEN (null) (--) ==&gt; -1 (No such file or directory)
[2013-03-01 11:34:28.031579] I [server3_1-fops.c:252:server_inodelk_cbk] vol-server: 993896: INODELK (null) (--) ==&gt; -1 (No such file or directory)
[2013-03-01 11:34:28.034041] I [server3_1-fops.c:252:server_inodelk_cbk] vol-server: 993914: INODELK (null) (--) ==&gt; -1 (No such file or directory)
[2013-03-01 11:34:28.040435] I [server3_1-fops.c:1338:server_flush_cbk] vol-server: 993938: FLUSH -2 (--) ==&gt; -1 (No such file or directory)

Solution:
Moved them to DEBUG log level if error number equlas to ENOENT else to ERROR log level.
It will help in decreasing the size of log files at INFO log level.
For server_open_cbk and for some other functions we already have a patch, below is the URL for it.
URL- http://review.gluster.org/6241
This patch solves logging problem for functions server_inodelk_cbk and server_flush_cbk.

Change-Id: I57372e851371e466f1674726015e28378b826f5f
BUG: 1029372
Signed-off-by: Vikhyat Umrao&lt;vumrao@redhat.com&gt;
Reviewed-on: http://review.gluster.org/6252
Reviewed-by: Niels de Vos &lt;ndevos@redhat.com&gt;
Tested-by: Gluster Build System &lt;jenkins@build.gluster.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Problem:
Messages were getting logged very frequently at log level INFO.

[2013-03-01 11:34:28.029222] I [server3_1-fops.c:1541:server_open_cbk] vol-server: 993888: OPEN (null) (--) ==&gt; -1 (No such file or directory)
[2013-03-01 11:34:28.031579] I [server3_1-fops.c:252:server_inodelk_cbk] vol-server: 993896: INODELK (null) (--) ==&gt; -1 (No such file or directory)
[2013-03-01 11:34:28.034041] I [server3_1-fops.c:252:server_inodelk_cbk] vol-server: 993914: INODELK (null) (--) ==&gt; -1 (No such file or directory)
[2013-03-01 11:34:28.040435] I [server3_1-fops.c:1338:server_flush_cbk] vol-server: 993938: FLUSH -2 (--) ==&gt; -1 (No such file or directory)

Solution:
Moved them to DEBUG log level if error number equlas to ENOENT else to ERROR log level.
It will help in decreasing the size of log files at INFO log level.
For server_open_cbk and for some other functions we already have a patch, below is the URL for it.
URL- http://review.gluster.org/6241
This patch solves logging problem for functions server_inodelk_cbk and server_flush_cbk.

Change-Id: I57372e851371e466f1674726015e28378b826f5f
BUG: 1029372
Signed-off-by: Vikhyat Umrao&lt;vumrao@redhat.com&gt;
Reviewed-on: http://review.gluster.org/6252
Reviewed-by: Niels de Vos &lt;ndevos@redhat.com&gt;
Tested-by: Gluster Build System &lt;jenkins@build.gluster.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>server/rpc: Numerous entries of error - "No such file or directory" in bricks log</title>
<updated>2013-11-11T12:36:45+00:00</updated>
<author>
<name>Vikhyat Umrao</name>
<email>vumrao@redhat.com</email>
</author>
<published>2013-11-11T09:22:54+00:00</published>
<link rel='alternate' type='text/html' href='http://git.gluster.org/cgit/glusterfs-snapshot.git/commit/?id=cfbc7ddbadfc7d01124aa713c4769c45e0522db5'/>
<id>cfbc7ddbadfc7d01124aa713c4769c45e0522db5</id>
<content type='text'>
Problem:
Messages were getting logged very frequently at log level INFO.

One of the log file snippet -

[2013-10-27 00:05:01.501355] I [server3_1-fops.c:1707:server_stat_cbk] 0-vol-server: 24846575: STAT (null) (--) ==&gt; -1 (No such file or directory)
[2013-10-27 00:05:01.505101] I [server3_1-fops.c:1707:server_stat_cbk] 0-vol-server: 24846577: STAT (null) (--) ==&gt; -1 (No such file or directory)
[2013-10-27 00:05:01.507299] I [server3_1-fops.c:1707:server_stat_cbk] 0-vol-server: 24846578: STAT (null) (--) ==&gt; -1 (No such file or directory)
[2013-10-20 19:50:35.554563] I [server3_1-fops.c:1538:server_open_cbk] 0-vol-server: 18714687: OPEN &lt;gfid:01c70ca0-1952-4e82-abee-a07205757d8e&gt;
(01c70ca0-1952-4e82-abee-a07205757d8e) ==&gt; -1 (No such file or directory)
[2013-10-20 19:50:35.555520] I [server3_1-fops.c:1538:server_open_cbk] 0-vol-server: 18714697: OPEN &lt;gfid:01c70ca0-1952-4e82-abee-a07205757d8e&gt;
(01c70ca0-1952-4e82-abee-a07205757d8e) ==&gt; -1 (No such file or directory)
[2013-10-20 19:50:35.558292] I [server3_1-fops.c:1538:server_open_cbk] 0-vol-server: 18714712: OPEN (null) (--) ==&gt; -1 (No such file or directory)

Solution:
Moved them to DEBUG log level if error number equlas to ENOENT else to ERROR log level.
It will help in decreasing the size of log files at INFO log level.

Change-Id: I23d74320c9c21bbce4805c20295556cc2cc0a8d8
BUG: 808073
Signed-off-by: Vikhyat Umrao &lt;vumrao@redhat.com&gt;
Reviewed-on: http://review.gluster.org/6241
Reviewed-by: Niels de Vos &lt;ndevos@redhat.com&gt;
Tested-by: Gluster Build System &lt;jenkins@build.gluster.com&gt;
Reviewed-by: Vijay Bellur &lt;vbellur@redhat.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Problem:
Messages were getting logged very frequently at log level INFO.

One of the log file snippet -

[2013-10-27 00:05:01.501355] I [server3_1-fops.c:1707:server_stat_cbk] 0-vol-server: 24846575: STAT (null) (--) ==&gt; -1 (No such file or directory)
[2013-10-27 00:05:01.505101] I [server3_1-fops.c:1707:server_stat_cbk] 0-vol-server: 24846577: STAT (null) (--) ==&gt; -1 (No such file or directory)
[2013-10-27 00:05:01.507299] I [server3_1-fops.c:1707:server_stat_cbk] 0-vol-server: 24846578: STAT (null) (--) ==&gt; -1 (No such file or directory)
[2013-10-20 19:50:35.554563] I [server3_1-fops.c:1538:server_open_cbk] 0-vol-server: 18714687: OPEN &lt;gfid:01c70ca0-1952-4e82-abee-a07205757d8e&gt;
(01c70ca0-1952-4e82-abee-a07205757d8e) ==&gt; -1 (No such file or directory)
[2013-10-20 19:50:35.555520] I [server3_1-fops.c:1538:server_open_cbk] 0-vol-server: 18714697: OPEN &lt;gfid:01c70ca0-1952-4e82-abee-a07205757d8e&gt;
(01c70ca0-1952-4e82-abee-a07205757d8e) ==&gt; -1 (No such file or directory)
[2013-10-20 19:50:35.558292] I [server3_1-fops.c:1538:server_open_cbk] 0-vol-server: 18714712: OPEN (null) (--) ==&gt; -1 (No such file or directory)

Solution:
Moved them to DEBUG log level if error number equlas to ENOENT else to ERROR log level.
It will help in decreasing the size of log files at INFO log level.

Change-Id: I23d74320c9c21bbce4805c20295556cc2cc0a8d8
BUG: 808073
Signed-off-by: Vikhyat Umrao &lt;vumrao@redhat.com&gt;
Reviewed-on: http://review.gluster.org/6241
Reviewed-by: Niels de Vos &lt;ndevos@redhat.com&gt;
Tested-by: Gluster Build System &lt;jenkins@build.gluster.com&gt;
Reviewed-by: Vijay Bellur &lt;vbellur@redhat.com&gt;
</pre>
</div>
</content>
</entry>
</feed>
