glusterfs-snapshot.git, branch gluster-snap

cli/cli-xml : skipped files should be treated as failures for

2014-02-06T07:38:16+00:00

remove-brick operation.

Fix: For remove-brick operation skipped count is included into
failure count.

clixml-output : skipped count would be zero always for remove-brick
status.

Change-Id: Ic0bb23b89e0cf5b884b6d1ae42bbf98deedc9173
BUG: 1060209
Signed-off-by: Susant Palai 
Reviewed-on: http://review.gluster.org/6889
Reviewed-by: Kaushal M 
Reviewed-by: Krishnan Parthasarathi 
Reviewed-by: Vijay Bellur 
Tested-by: Gluster Build System

changelog: Restrict length of unix socket files to UNIX_PATH_MAX.

2014-02-06T07:05:34+00:00

Bug fix for Coverity-CID 1124847.

Change-Id: I410ef8e06cbc491b1f72535298fae5e9bc77220d
BUG: 789278
Signed-off-by: Raghavendra Talur 
Reviewed-on: http://review.gluster.org/6870
Reviewed-by: Venky Shankar 
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

libglusterfs: Allow all valid file handle values to be closed.

2014-02-06T06:26:07+00:00

Zero (0) is a valid file handle. The code, as written, interprets return
values of open(2) that are less than or equal to zero to indicate an
error.  Only -1 indicates an error.

BUG: 789278
CID: 1124756

Change-Id: Ie77c25f1f557d5d5adcec464b49dc7df2e3dc7e5
Signed-off-by: Christopher R. Hertel 
Reviewed-on: http://review.gluster.org/6884
Reviewed-by: Lalatendu Mohanty 
Reviewed-by: Shyamsundar Ranganathan 
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

Fix for 'use after free' errors reported by coverity.

2014-02-06T06:09:13+00:00

Change-Id: I941fc89b2d696c7f227330321ed4bba3ed1deac4
BUG: 789278
Signed-off-by: Poornima 
Reviewed-on: http://review.gluster.org/6868
Reviewed-by: Raghavendra G 
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

mgmt/glusterd: Fix double free.

2014-02-06T05:46:07+00:00

Change-Id: I7a8b7772849715b019c86c6c768f33c1d9dcb27c
BUG: 789278
Signed-off-by: Poornima 
Reviewed-on: http://review.gluster.org/6881
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

Problem : getfattr fails and mount point becomes inaccessible while

2014-02-06T05:44:26+00:00

fetching glusterfs.ancestry.path key value for a gfid from aux-gfid-mount 
based mount point.

Analysis : The caller of posix_make_ancestryfromgfid() function i.e. 
posix_get_ancestry_non_directory() is sending an incorrect type value as 
an argument leading to a crash in posix_make_ancestral_node() (head 
dirent pointer is NULL and an attempt to dereference causes seg fault). 
For a non directory operation this piece of code should not have been 
executed but due to incorrect type value this happened.

Solution : In posix_make_ancestryfromgfid() call type is passed as 
logical or of type and POSIX_ANCESTRY_PATH instead of logical or of 
POSIX_ANCESTRY_PATH and POSX_ANCESTRY_DENTRY.


Change-Id: Iaf844bea91396c5e2ee295d5a082998fda66f0a9
BUG: 1060104
Signed-off-by: Atin Mukherjee 
Reviewed-on: http://review.gluster.org/6892
Reviewed-by: Raghavendra G 
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

tests/basic: Prevent mount-options.t from being run.

2014-02-06T04:07:56+00:00

mount-options.t introduces a race leading to failures in
regression tests. Hence disabling the test unit till we
sort out the race.

Also removing the workaround introduced in mount.t.

Change-Id: I7d60413bbff8597f90153cca838e326247e96cd9
BUG: 1060654
Signed-off-by: Vijay Bellur 
Reviewed-on: http://review.gluster.org/6911
Reviewed-by: Kaleb KEITHLEY 
Tested-by: Gluster Build System

libxlator: fix memleak in cluster_markerxtime_cbk and cluster_markeruuid_cbk

2014-02-04T19:29:27+00:00

Change-Id: Ide3574bf9f661b077f707990d47821feda18b1a3
BUG: 841617
Reviewed-on: http://review.gluster.org/6850
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

libglusterfs:Fixing Dereference NULL return value.

2014-02-04T18:00:13+00:00

1.Checking of data for NULL.

Change-Id: If49513f7c3fd1dc443c05dc62ed07d3254059e6e
BUG: 789278
Signed-off-by: surabhi 
Reviewed-on: http://review.gluster.org/6799
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

cluster/dht: Set restrictive open flags for files under rebalance

2014-02-04T17:56:57+00:00

Files that are being rebalanced are created in the new volume
and access path needs to open these files to write changing
data in parallel to both the old and new locations. While opening
the file in the new location, we need to restrict the open flags
to not use truncate or create and fail if exist flags, to prevent
open failures or inadvertently truncate the file under rebalance.

Change-Id: I12130e0377adc393f1925c45585200ad991fd0d5
BUG: 1058569
Signed-off-by: ShyamsundarR 
Reviewed-on: http://review.gluster.org/6830
Reviewed-by: Raghavendra G 
Reviewed-by: Krutika Dhananjay 
Tested-by: Gluster Build System 
Reviewed-by: Raghavendra Bhat 
Reviewed-by: Vijay Bellur