From 96ae0db506f43ceed0d3346d0351b1bb73b0b19c Mon Sep 17 00:00:00 2001 From: Junaid Date: Sun, 19 Jun 2011 23:41:25 +0000 Subject: features/quota: Print a log when reconfigure fails. Signed-off-by: Junaid Signed-off-by: Anand Avati BUG: 2775 (crash in reconfigure) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2775 --- xlators/features/quota/src/quota.c | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) (limited to 'xlators/features/quota/src/quota.c') diff --git a/xlators/features/quota/src/quota.c b/xlators/features/quota/src/quota.c index dc3ed30a..8f63c7ae 100644 --- a/xlators/features/quota/src/quota.c +++ b/xlators/features/quota/src/quota.c @@ -2746,11 +2746,14 @@ reconfigure (xlator_t *this, dict_t *options) } ret = quota_parse_options (priv, this, options); - - if (ret == -1) - GF_ASSERT (0); - - return ret; + if (ret == -1) { + gf_log ("quota", GF_LOG_WARNING, + "quota reconfigure failed, " + "new changes will not take effect"); + goto out; + } +out: + return 0; } -- cgit