From 7062eda1575214819f5c7411748b06be95e08ffa Mon Sep 17 00:00:00 2001
From: Kaushal M <kaushal@redhat.com>
Date: Mon, 24 Jun 2013 12:50:32 +0530
Subject: libglusterfs: Fix valid_host_name for consecutive dots

The valid_host_name() function must reject addresses with consecutive
dots in them.

Change-Id: I1749de80c66e8fbad63b2e014f79e0203906030e
BUG: 977246
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.org/5249
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
---
 libglusterfs/src/common-utils.c | 8 ++++++++
 1 file changed, 8 insertions(+)

(limited to 'libglusterfs/src')

diff --git a/libglusterfs/src/common-utils.c b/libglusterfs/src/common-utils.c
index b44c1d0b3..ab3674ead 100644
--- a/libglusterfs/src/common-utils.c
+++ b/libglusterfs/src/common-utils.c
@@ -1784,6 +1784,14 @@ valid_host_name (char *address, int length)
                 goto out;
         }
 
+        /* Check for consecutive dots, which is invalid in a hostname and is
+         * ignored by strtok()
+         */
+        if (strstr (dup_addr, "..")) {
+                ret = 0;
+                goto out;
+        }
+
         /* gen-name */
         temp_str = strtok_r (dup_addr, ".", &save_ptr);
         do {
-- 
cgit