From a7243ea310613ad0681fd68bc951492fe311916b Mon Sep 17 00:00:00 2001 From: Harshavardhana Date: Sat, 25 Jan 2014 02:39:11 -0800 Subject: build: GFAPI_VERSION should be 6.0.0 not 0.0.6 -------------------------------------> "In essence, every time you make a change to the library and release it, the C:R:A should change. A new library should start with 0:0:0. Each time you change the public interface (i.e., your installed header files), you should increment the CURRENT number." So the version which was 3 became 5 when discard API was added and became 6 when zerofill was added. As per the above description, API addition will result in a change to the installed header (glfs.h) and hence warrants a change in CURRENT number ? Should you have changed the version to 6.0.0 instead of 0.0.6 ? <------------------------------------ Thanks Bharata B Rao for pointing this out Change-Id: I0aa980a6713fbd28922a94c5debb170a89aa3512 BUG: 862082 Signed-off-by: Harshavardhana Reviewed-on: http://review.gluster.org/6790 Reviewed-by: Niels de Vos Tested-by: Gluster Build System Reviewed-by: Bharata B Rao Reviewed-by: Vijay Bellur --- configure.ac | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'configure.ac') diff --git a/configure.ac b/configure.ac index abcf99ac9..010e27097 100644 --- a/configure.ac +++ b/configure.ac @@ -889,7 +889,7 @@ AM_CONDITIONAL([GF_DARWIN_HOST_OS], test "${GF_HOST_OS}" = "GF_DARWIN_HOST_OS") AM_CONDITIONAL([GF_INSTALL_VAR_LIB_GLUSTERD], test ! -d ${localstatedir}/lib/glusterd && test -d ${sysconfdir}/glusterd ) dnl pkg-config versioning -GFAPI_VERSION="0.0.6" +GFAPI_VERSION="6.0.0" LIBGFCHANGELOG_VERSION="0.0.1" AC_SUBST(GFAPI_VERSION) AC_SUBST(LIBGFCHANGELOG_VERSION) @@ -899,7 +899,7 @@ LIBGFXDR_LT_VERSION="0:1:0" LIBGFRPC_LT_VERSION="0:1:0" LIBGLUSTERFS_LT_VERSION="0:1:0" LIBGFCHANGELOG_LT_VERSION="0:1:0" -GFAPI_LT_VERSION="0:6:0" +GFAPI_LT_VERSION="6:0:0" AC_SUBST(LIBGFXDR_LT_VERSION) AC_SUBST(LIBGFRPC_LT_VERSION) AC_SUBST(LIBGLUSTERFS_LT_VERSION) -- cgit