From ffef7f14ef5c6d88ca8d68f9ab7b0a2319faef12 Mon Sep 17 00:00:00 2001 From: Nitin Goyal Date: Tue, 27 Aug 2019 10:57:53 +0530 Subject: Fix error handling logic in the "vmware" cloud provider Fix error handling logic in the "vmware" cloud provider module by adding "raise" statement in places where it is lost. Change-Id: I92e97da4109bc6ab7368b41d2a6886e9f2be31c1 --- .../openshiftstoragelibs/cloundproviders/vmware.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'openshift-storage-libs') diff --git a/openshift-storage-libs/openshiftstoragelibs/cloundproviders/vmware.py b/openshift-storage-libs/openshiftstoragelibs/cloundproviders/vmware.py index 8312efa6..fe69b532 100644 --- a/openshift-storage-libs/openshiftstoragelibs/cloundproviders/vmware.py +++ b/openshift-storage-libs/openshiftstoragelibs/cloundproviders/vmware.py @@ -196,12 +196,12 @@ class VmWare(object): if not vm: msg = 'VM %s is not present in list' % vm_name g.log.error(msg) - exceptions.CloudProviderError(msg) + raise exceptions.CloudProviderError(msg) if vm[0].summary.runtime.powerState == 'poweredOn': msg = 'VM %s is already powered On' % vm_name g.log.error(msg) - exceptions.CloudProviderError(msg) + raise exceptions.CloudProviderError(msg) tasks = [vm[0].PowerOn()] self._wait_for_tasks(tasks, self.vsphere_client) @@ -226,12 +226,12 @@ class VmWare(object): if not vm: msg = 'VM %s is not present in list' % vm_name g.log.error(msg) - exceptions.CloudProviderError(msg) + raise exceptions.CloudProviderError(msg) if vm[0].summary.runtime.powerState == 'poweredOff': msg = 'VM %s is already powered Off' % vm_name g.log.error(msg) - exceptions.CloudProviderError(msg) + raise exceptions.CloudProviderError(msg) tasks = [vm[0].PowerOff()] self._wait_for_tasks(tasks, self.vsphere_client) -- cgit