From 56d0124224259ccfc4c8b1cc33939902ed480d23 Mon Sep 17 00:00:00 2001 From: "M. Mohan Kumar" Date: Fri, 15 Nov 2013 18:23:29 +0530 Subject: BD fixes for coverity scan BUG: 1028672 Change-Id: I2e7889fb113cedd2d5928b210149d3fd7b8b22ab Signed-off-by: M. Mohan Kumar Reviewed-on: http://review.gluster.org/6292 Tested-by: Gluster Build System Reviewed-by: Vijay Bellur --- xlators/storage/bd/src/bd.c | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) (limited to 'xlators/storage/bd/src') diff --git a/xlators/storage/bd/src/bd.c b/xlators/storage/bd/src/bd.c index 405474c58..1eb5cd158 100644 --- a/xlators/storage/bd/src/bd.c +++ b/xlators/storage/bd/src/bd.c @@ -1102,7 +1102,7 @@ out: if (local->fd) BD_STACK_UNWIND (fsetxattr, frame, op_ret, op_errno, NULL); else - BD_STACK_UNWIND (setxattr, frame, op_errno, op_errno, NULL); + BD_STACK_UNWIND (setxattr, frame, op_ret, op_errno, NULL); return 0; } @@ -2328,11 +2328,15 @@ init (xlator_t *this) return 0; error: - GF_FREE (_private->vg); - if (_private->handle) - lvm_quit (_private->handle); + if (_private) { + GF_FREE (_private->vg); + if (_private->handle) + lvm_quit (_private->handle); + GF_FREE (_private); + } + mem_pool_destroy (this->local_pool); - GF_FREE (_private); + return -1; } -- cgit