From c0b8e886cac4ef0f16d5f93adab02229bb1414cd Mon Sep 17 00:00:00 2001 From: Amar Tumballi Date: Tue, 14 Feb 2012 15:05:19 +0530 Subject: iobuf: use 'iobuf_get2()' to get variable sized buffers added 'TODO' in places where it is missing. Change-Id: Ia802c94e3bb76930f7c88c990f078525be5459f5 Signed-off-by: Amar Tumballi BUG: 765264 Reviewed-on: http://review.gluster.com/388 Tested-by: Gluster Build System Reviewed-by: Vijay Bellur --- xlators/performance/quick-read/src/quick-read.c | 3 +++ xlators/performance/write-behind/src/write-behind.c | 1 + 2 files changed, 4 insertions(+) (limited to 'xlators/performance') diff --git a/xlators/performance/quick-read/src/quick-read.c b/xlators/performance/quick-read/src/quick-read.c index 14ff58b51..c1460b1de 100644 --- a/xlators/performance/quick-read/src/quick-read.c +++ b/xlators/performance/quick-read/src/quick-read.c @@ -1180,6 +1180,9 @@ qr_readv (call_frame_t *frame, xlator_t *this, fd_t *fd, size_t size, } for (i = 0; i < count; i++) { + /* TODO: Now that we have support for variable + io-buf-sizes, i guess we need to get rid of + default size here */ iobuf = iobuf_get (iobuf_pool); if (iobuf == NULL) { op_ret = -1; diff --git a/xlators/performance/write-behind/src/write-behind.c b/xlators/performance/write-behind/src/write-behind.c index 7c666b403..be7da2f44 100644 --- a/xlators/performance/write-behind/src/write-behind.c +++ b/xlators/performance/write-behind/src/write-behind.c @@ -1901,6 +1901,7 @@ __wb_copy_into_holder (wb_request_t *holder, wb_request_t *request) int ret = -1; if (holder->flags.write_request.virgin) { + /* TODO: check the required size */ iobuf = iobuf_get (request->file->this->ctx->iobuf_pool); if (iobuf == NULL) { goto out; -- cgit