From be1d2cd4d042bda2e53e3c45dd36e8ed9525ba32 Mon Sep 17 00:00:00 2001 From: Jeff Darcy Date: Tue, 5 Jun 2012 21:59:47 -0400 Subject: rpc: avoid an invalid free of item on a list If we actually "consumed" vol_opt by putting it on THIS->volume_options, it's still in use and we shouldn't free it before returning. Change-Id: I8ef3e4ce8a8b9f2552faa3345f1686e173d1aa10 BUG: 829104 Signed-off-by: Jeff Darcy Reviewed-on: http://review.gluster.com/3528 Tested-by: Gluster Build System Reviewed-by: Amar Tumballi Reviewed-by: Anand Avati --- rpc/rpc-lib/src/rpc-transport.c | 1 + 1 file changed, 1 insertion(+) (limited to 'rpc/rpc-lib') diff --git a/rpc/rpc-lib/src/rpc-transport.c b/rpc/rpc-lib/src/rpc-transport.c index d0e7834e8..4b6937424 100644 --- a/rpc/rpc-lib/src/rpc-transport.c +++ b/rpc/rpc-lib/src/rpc-transport.c @@ -305,6 +305,7 @@ rpc_transport_load (glusterfs_ctx_t *ctx, dict_t *options, char *trans_name) "volume option validation failed"); goto fail; } + vol_opt = NULL; } trans->options = options; -- cgit