From 7ce46fa0fc4fc3e4039ae91c97b2a8eb1975ea2e Mon Sep 17 00:00:00 2001 From: Shehjar Tikoo Date: Fri, 12 Jun 2009 05:11:53 +0000 Subject: libglusterfsclient: Call inode_lookup to prevent pruning This bug shows up while using unfs3 with replicate. The absence of an inode_lookup on a looked-up/created inode results in it getting pruned from the inode table. Consequently, a subsequent lookup for the inode results in a different inode number being returned by replicate. This breaks unfs3 because it tries to remember the inode numbers returned by two different stat-family calls. Resolves: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=11 Signed-off-by: Anand V. Avati --- libglusterfsclient/src/libglusterfsclient.c | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) (limited to 'libglusterfsclient/src/libglusterfsclient.c') diff --git a/libglusterfsclient/src/libglusterfsclient.c b/libglusterfsclient/src/libglusterfsclient.c index 9399d2c29..d5990384f 100755 --- a/libglusterfsclient/src/libglusterfsclient.c +++ b/libglusterfsclient/src/libglusterfsclient.c @@ -1509,7 +1509,7 @@ libgf_client_lookup_cbk (call_frame_t *frame, parent = local->fop.lookup.loc->parent; inode_link (inode, parent, local->fop.lookup.loc->name, buf); - /* inode_lookup (inode); */ + inode_lookup (inode); } else { if ((local->fop.lookup.is_revalidate == 0) && (op_errno == ENOENT)) { @@ -1758,7 +1758,7 @@ libgf_client_lookup_async_cbk (call_frame_t *frame, libgf_alloc_inode_ctx (ctx, inode); libgf_update_iattr_cache (inode, LIBGF_UPDATE_ALL, stbuf); - /* inode_lookup (inode); */ + inode_lookup (inode); } else { if ((local->fop.lookup_cbk.is_revalidate == 0) && (op_errno == ENOENT)) { @@ -2278,7 +2278,7 @@ libgf_client_creat (libglusterfs_client_ctx_t *ctx, inode_link (libgf_inode, loc->parent, loc->name, &stub->args.create_cbk.buf); - /* inode_lookup (libgf_inode); */ + inode_lookup (libgf_inode); libgf_alloc_inode_ctx (ctx, libgf_inode); libgf_update_iattr_cache (libgf_inode, LIBGF_UPDATE_ALL, @@ -4261,7 +4261,7 @@ libgf_client_mkdir (libglusterfs_client_ctx_t *ctx, inode_link (libgf_inode, loc->parent, loc->name, &stub->args.mkdir_cbk.buf); - /* inode_lookup (libgf_inode); */ + inode_lookup (libgf_inode); libgf_alloc_inode_ctx (ctx, libgf_inode); libgf_update_iattr_cache (libgf_inode, LIBGF_UPDATE_ALL, @@ -5090,6 +5090,7 @@ libgf_client_link (libglusterfs_client_ctx_t *ctx, loc_t *old, loc_t *new) inode = stub->args.link_cbk.inode; sbuf = &stub->args.link_cbk.buf; inode_link (inode, new->parent, basename ((char *)new->path), sbuf); + inode_lookup (inode); libgf_update_iattr_cache (inode, LIBGF_UPDATE_STAT, sbuf); out: @@ -5769,6 +5770,7 @@ libgf_client_mknod (libglusterfs_client_ctx_t *ctx, loc_t *loc, mode_t mode, inode = stub->args.mknod_cbk.inode; inode_link (inode, loc->parent, loc->name, &stub->args.mknod_cbk.buf); + inode_lookup (inode); if (!libgf_alloc_inode_ctx (ctx, inode)) libgf_alloc_inode_ctx (ctx, inode); @@ -6063,7 +6065,7 @@ libgf_client_symlink (libglusterfs_client_ctx_t *ctx, const char *linkpath, inode = stub->args.symlink_cbk.inode; inode_link (inode, loc->parent, loc->name, &stub->args.symlink_cbk.buf); - + inode_lookup (inode); if (!libgf_get_inode_ctx (inode)) libgf_alloc_inode_ctx (ctx, inode); -- cgit