From a279af40f11a437fabc5b59234e677282bea246b Mon Sep 17 00:00:00 2001 From: Kaushik BV Date: Mon, 8 Aug 2011 15:13:57 +0530 Subject: mgmt/glusterd: volume set help/help-xml minor fixes - fix few typos in description - fix the memory leak - add an explicit flush call to flush the contents of xmlWriter to buffer Change-Id: Iae58b117361e3701ee31fbd65890734312289203 BUG: 2041 Reviewed-on: http://review.gluster.com/191 Tested-by: Gluster Build System Reviewed-by: Vijay Bellur --- libglusterfs/src/xlator.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'libglusterfs') diff --git a/libglusterfs/src/xlator.c b/libglusterfs/src/xlator.c index 81b308d33..7db671d6d 100644 --- a/libglusterfs/src/xlator.c +++ b/libglusterfs/src/xlator.c @@ -605,8 +605,6 @@ xlator_volopt_dynload (char *xlator_type, void **dl_handle, } *dl_handle = handle; - INIT_LIST_HEAD (&opt_list->list); - vol_opt = GF_CALLOC (1, sizeof (volume_opt_list_t), gf_common_mt_volume_opt_list_t); @@ -619,10 +617,12 @@ xlator_volopt_dynload (char *xlator_type, void **dl_handle, gf_log ("xlator", GF_LOG_DEBUG, "Strict option validation not enforced -- neglecting"); } - list_add_tail (&vol_opt->list, &opt_list->list); + list_add (&vol_opt->list, &opt_list->list); ret = 0; out: + if (name) + GF_FREE (name); gf_log ("xlator", GF_LOG_DEBUG, "Returning %d", ret); return ret; -- cgit