From f01aa2aa7487cdb3198fb7749d2fbf25d41ad1e6 Mon Sep 17 00:00:00 2001 From: Shehjar Tikoo Date: Fri, 30 Oct 2009 03:40:11 +0000 Subject: booster: Must check errno for error number not return value Signed-off-by: Shehjar Tikoo Signed-off-by: Anand V. Avati BUG: 346 (booster returns success on failed getxattr and lgetxattr) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=346 --- booster/src/booster.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'booster') diff --git a/booster/src/booster.c b/booster/src/booster.c index 3f171646c..00352d621 100644 --- a/booster/src/booster.c +++ b/booster/src/booster.c @@ -2296,7 +2296,7 @@ getxattr (const char *path, const char *name, void *value, size_t size) gf_log ("booster", GF_LOG_TRACE, "getxattr: path %s, name %s", path, name); ret = glusterfs_getxattr (path, name, value, size); - if ((ret == -1) && (ret != ENODEV)) { + if ((ret == -1) && (errno != ENODEV)) { gf_log ("booster", GF_LOG_ERROR, "getxattr failed: %s", strerror (errno)); goto out; @@ -2327,11 +2327,11 @@ lgetxattr (const char *path, const char *name, void *value, size_t size) gf_log ("booster", GF_LOG_TRACE, "lgetxattr: path %s, name %s", path, name); ret = glusterfs_lgetxattr (path, name, value, size); - if ((ret == -1) && (ret != ENODEV)) { + if ((ret == -1) && (errno != ENODEV)) { gf_log ("booster", GF_LOG_ERROR, "lgetxattr failed: %s", strerror (errno)); - return ret; + goto out; } if (ret > 0) { -- cgit