From b78fa55bbbb645d4a9ac58ff7f6b59684dfa83d4 Mon Sep 17 00:00:00 2001 From: Raghavendra G Date: Thu, 15 Oct 2009 08:39:01 +0000 Subject: performance/quick-read: frame->local need not be set in qr_open_cbk. - local is used only by certain operations and hence it need not be set by all the operations invoking open. Signed-off-by: Anand V. Avati BUG: 323 (fd leak with quick-read loaded in translator tree) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=323 --- xlators/performance/quick-read/src/quick-read.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/xlators/performance/quick-read/src/quick-read.c b/xlators/performance/quick-read/src/quick-read.c index 54367a3fd..2c54b559e 100644 --- a/xlators/performance/quick-read/src/quick-read.c +++ b/xlators/performance/quick-read/src/quick-read.c @@ -344,10 +344,7 @@ qr_open_cbk (call_frame_t *frame, void *cookie, xlator_t *this, int32_t op_ret, char is_open = 0; local = frame->local; - if (local == NULL) { - op_ret = -1; - op_errno = EINVAL; - } else { + if (local != NULL) { local->op_ret = op_ret; local->op_errno = op_errno; is_open = local->is_open; -- cgit