From 9af34ababcc2682bb668d00b7a49bac8e5fe7811 Mon Sep 17 00:00:00 2001 From: Raghavendra Bhat Date: Mon, 16 Jan 2012 15:03:48 +0530 Subject: mgmt/glusterd: check brickinfo for NULL before dereferencing it Change-Id: I59fed6adf13d6d72d79c986bf3578ca79b9756ac BUG: 781953 Signed-off-by: Raghavendra Bhat Reviewed-on: http://review.gluster.org/2648 Tested-by: Gluster Build System Reviewed-by: Krishnan Parthasarathi --- xlators/mgmt/glusterd/src/glusterd-utils.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/xlators/mgmt/glusterd/src/glusterd-utils.c b/xlators/mgmt/glusterd/src/glusterd-utils.c index c7edefc03..c314aecc5 100644 --- a/xlators/mgmt/glusterd/src/glusterd-utils.c +++ b/xlators/mgmt/glusterd/src/glusterd-utils.c @@ -738,7 +738,8 @@ glusterd_volume_brickinfo_get (uuid_t uuid, char *hostname, char *path, "given path %s lies" " within %s", path, brickiter->path); - *brickinfo = brickiter; + if (brickinfo) + *brickinfo = brickiter; break; } } else @@ -748,7 +749,8 @@ glusterd_volume_brickinfo_get (uuid_t uuid, char *hostname, char *path, " %s", brickiter->path, path); ret = 0; - *brickinfo = brickiter; + if (brickinfo) + *brickinfo = brickiter; break; } } -- cgit