From 550d83889857c1fe2c8eb04b1740a4884db7697d Mon Sep 17 00:00:00 2001 From: Anand Avati Date: Wed, 27 Nov 2013 10:35:30 -0800 Subject: cluster/afr: handle NULL check before strlen/strcmp in fgetxattr xattr name can legally be NULL. Handle that case without crashing. Change-Id: Ie214cb05ccd52565dc247a9234ad83ae799d3866 BUG: 1036879 Signed-off-by: Anand Avati Reviewed-on: http://review.gluster.org/6422 Tested-by: Gluster Build System Reviewed-by: Vijay Bellur --- xlators/cluster/afr/src/afr-inode-read.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xlators/cluster/afr/src/afr-inode-read.c b/xlators/cluster/afr/src/afr-inode-read.c index ac64a7636..8a2853319 100644 --- a/xlators/cluster/afr/src/afr-inode-read.c +++ b/xlators/cluster/afr/src/afr-inode-read.c @@ -1405,7 +1405,7 @@ afr_is_special_xattr (const char *name, fop_getxattr_cbk_t *cbk, gf_boolean_t is_spl = _gf_true; GF_ASSERT (cbk); - if (!cbk) { + if (!cbk || !name) { is_spl = _gf_false; goto out; } -- cgit