From 1c825e5f2498ec586c0e9123c472f6d134706e08 Mon Sep 17 00:00:00 2001 From: Raghavendra Bhat Date: Fri, 27 Apr 2012 14:34:07 +0530 Subject: mgmt/glusterd: take the statedumps of running bricks if one of the bricks is down Till now if one of the bricks of the volume is down, then statedump of that volume (bricks) did not take the statedumps of running bricks. This patch fixes that issue and cli command will take the statedumps of running brick processes. Change-Id: Id9b11905d3d759202e505c2ecfa6ccd5dce6a9ff BUG: 816884 Signed-off-by: Raghavendra Bhat Reviewed-on: http://review.gluster.com/3237 Tested-by: Gluster Build System Reviewed-by: Amar Tumballi Reviewed-by: Vijay Bellur --- xlators/mgmt/glusterd/src/glusterd-volume-ops.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/xlators/mgmt/glusterd/src/glusterd-volume-ops.c b/xlators/mgmt/glusterd/src/glusterd-volume-ops.c index 85e7abba8..4ee9582fd 100644 --- a/xlators/mgmt/glusterd/src/glusterd-volume-ops.c +++ b/xlators/mgmt/glusterd/src/glusterd-volume-ops.c @@ -1596,8 +1596,14 @@ glusterd_op_statedump_volume (dict_t *dict, char **op_errstr) ret = glusterd_brick_statedump (volinfo, brickinfo, options, option_cnt, op_errstr); + /* Let us take the statedump of other bricks instead of + * exiting, if statedump of this brick fails. + */ if (ret) - goto out; + gf_log (THIS->name, GF_LOG_WARNING, "could not " + "take the statedump of the brick %s:%s." + " Proceeding to other bricks", + brickinfo->hostname, brickinfo->path); } } -- cgit