summaryrefslogtreecommitdiffstats
path: root/extras
Commit message (Collapse)AuthorAgeFilesLines
* extras/rpc-coverage.sh : behavior fixAmar Tumballi2012-02-181-2/+1
| | | | | | | | | | | | don't treat getfattr after 'setfattr -x' (ie, removexattr()) as an error. ignore the output so the script runs for completion Change-Id: Id7089b91e7259a39be7cb6fce627828774c4acbc Signed-off-by: Amar Tumballi <amar@gluster.com> BUG: 787956 Reviewed-on: http://review.gluster.com/2768 Tested-by: Gluster Build System <jenkins@build.gluster.com> Reviewed-by: Vijay Bellur <vijay@gluster.com>
* extras: create PID file for glusterd when started from init scriptsKaushik BV2012-02-031-7/+25
| | | | | | | | | | | | thanks to Jaroslav Pulchart (jaroslav.pulchart@centrum.cz) for the patch Change-Id: Id07bf50536c8638f790f06e6e5994f85555c3978 BUG: 771221 Signed-off-by: Kaushik BV <kbudiger@redhat.com> Reviewed-on: http://review.gluster.com/2668 Tested-by: Gluster Build System <jenkins@build.gluster.com> Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com> Reviewed-by: Vijay Bellur <vijay@gluster.com>
* extras/test: add a test file to test 'f-fops'.Amar Tumballi2012-02-031-0/+105
| | | | | | | | | | | | | mainly to test f*xattr(), fchown()/fchmod()/ftruncate() on fuse mounts. Change-Id: I59edbe172f307a2ba94f11c650ac0176fd35564f Signed-off-by: Amar Tumballi <amar@gluster.com> BUG: 766571 Reviewed-on: http://review.gluster.com/2692 Tested-by: Gluster Build System <jenkins@build.gluster.com> Reviewed-by: Jeff Darcy <jdarcy@redhat.com> Reviewed-by: Vijay Bellur <vijay@gluster.com>
* core: change lk-owner as a 1k bufferAmar Tumballi2012-01-241-1/+1
| | | | | | | | | | | | | so, NLM can send the lk-owner field directly to the locks translators, while doing the same effort, also enabled sending maximum of 500 aux gid over protocol. Change-Id: I87c2514392748416f7ffe21d5154faad2e413969 Signed-off-by: Amar Tumballi <amar@gluster.com> BUG: 767229 Reviewed-on: http://review.gluster.com/779 Tested-by: Gluster Build System <jenkins@build.gluster.com> Reviewed-by: Anand Avati <avati@gluster.com>
* extras: add check for brick path existenceRajesh Amaravathi2012-01-051-3/+13
| | | | | | | | | | | | Adding a couple of checks to validate brick path(s) Change-Id: I2d8538add21407d9457542373b528c2a02cd7eb6 BUG: 765572 Signed-off-by: Rajesh Amaravathi <rajesh@redhat.com> Reviewed-on: http://review.gluster.com/2514 Tested-by: Gluster Build System <jenkins@build.gluster.com> Reviewed-by: Jeff Darcy <jdarcy@redhat.com> Reviewed-by: Vijay Bellur <vijay@gluster.com>
* extras: clean up a brick's gfid xattrRajesh Amaravathi2011-12-251-0/+43
| | | | | | | | | | | | | | | | | | | | | | * extras/clear_xattrs.sh: This script enables a brick from a deleted volume(stale brick) to be used in a new volume by clearing all the trusted.gfid xattr from the brick tree. * One should run this script on all machines which have stale bricks if one wants to re-use the same bricks for a new volume. NOTE: This script *SHOULD BE RUN ONLY AFTER STOPPING A VOLUME*, thereby ensuring that no replace-brick or rebalance operations are on-going. Change-Id: I35a4a2784fe502749184b87299b1a043b8e48e90 BUG: 765572 Signed-off-by: Rajesh Amaravathi <rajesh@redhat.com> Reviewed-on: http://review.gluster.com/781 Reviewed-by: Amar Tumballi <amar@gluster.com> Tested-by: Gluster Build System <jenkins@build.gluster.com> Reviewed-by: Vijay Bellur <vijay@gluster.com>
* Change the start/stop order of glusterd script at boot time.Sachidananda Urs2011-11-231-35/+35
| | | | | | | | | | | | | | | | | | | | | | In cases of client and server sharing the same machine, mounting GlusterFS at boot time failed due to the start and stop order we use for glusterd. And people had to resort to the idea of adding mount command in rc.local. Currently the start and stop order at the boot time were 90 and 12, and netfs started before `glusterd' and failed to mount GlusterFS. By changing the rc order to 20 80 glusterd is started earlier than netfs, thus enabling netfs to mount GlusterFS during boot process. Thanks to: alex@net13.info for the suggestion in bug 2484. Change-Id: I482f4dac5e5dd8bc5b8f5034c394f5dbe6c1fd3e BUG: 2484 Reviewed-on: http://review.gluster.com/746 Tested-by: Gluster Build System <jenkins@build.gluster.com> Reviewed-by: Harshavardhana <fharshav@redhat.com> Tested-by: Harshavardhana <fharshav@redhat.com> Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com> Reviewed-by: Anand Avati <avati@gluster.com>
* rdd: create the file and do rdd if the file does not exist.Raghavendra Bhat2011-11-151-2/+174
| | | | | | | | | | | | | | rdd takes input file and copies the its data to the specified output file ( by creating it) by selecting random offset. If the input file does not exist it will not work. This patch will create the input file if it does not exist and then does the copy. File size is given as an argument. If the file exists it truncates the file and then does the copy. Change-Id: Ia09451e9e80e13f27320f1edc12c73c0dcf663a9 BUG: 3724 Reviewed-on: http://review.gluster.com/596 Tested-by: Gluster Build System <jenkins@build.gluster.com> Reviewed-by: Vijay Bellur <vijay@gluster.com>
* Second round of warning suppression.Jeff Darcy2011-09-291-0/+6
| | | | | | | | | | | | | | | | | | | | | | Used a #pragma to kill ~170 in rpcgen code. Added GF_UNUSED to deal with a few more from macros elsewhere. The remainder are function return values (mostly context and dict calls) that really should be checked. Those would be harder to fix without real understanding of the code where they occur, so they remain as reminders. (Patchset 2: deal with older gcc that doesn't handle #pragma GCC diagnostic) (Patchset 3: fix include paths in generated files) (Patchset 4: keep up with trunk, squash 9 new warnings) (Patchset 5: six more, all in AFR) Change-Id: I29760c8c81be4d7e6489312c5d0e92cc24814b7b BUG: 2550 Reviewed-on: http://review.gluster.com/378 Tested-by: Gluster Build System <jenkins@build.gluster.com> Reviewed-by: Vijay Bellur <vijay@gluster.com>
* build: Solaris build fixesv3.3.0qa12Kaushik BV2011-09-271-0/+1
| | | | | | | | Change-Id: Ic47d07a199ecbc42a141e391bbc75096e270e404 BUG: 3446 Reviewed-on: http://review.gluster.com/503 Tested-by: Gluster Build System <jenkins@build.gluster.com> Reviewed-by: Amar Tumballi <amar@gluster.com>
* modify to the way we used XDR definitions files (.x files)Amar Tumballi2011-09-071-0/+100
| | | | | | | | | | | | | | | | | | | | | | | | Earlier: step 1: copy the existing <xdr>.x files to /tmp step 2: generate '.[ch]' files using 'rpcgen <xdr>.x' step 3: check diff with the to the existing files, add only your part of changes back to the original file. (ignore other changes). step 4: there is another file to write wrapper functions to convert structures to/from XDR buffers, update it with your new structure. step 5: use these wrapper functions in the newly written procedures. step 6: commit :-| Now: step 1: update (mostly adding only) the <xdr>.x file step 2: run '<path-to-src>/extras/generate-xdr-files.sh <xdr>.x' command step 3: implement rpc procedure to handle the request/response. step 4: commit :-) Change-Id: I219f9159fc980438c86e847c6b030be96e595ea2 BUG: 3488 Reviewed-on: http://review.gluster.com/341 Tested-by: Gluster Build System <jenkins@build.gluster.com> Reviewed-by: Anand Avati <avati@gluster.com>
* rdd: changes in rdd.c and whitespace cleanupRaghavendra Bhat2011-08-251-344/+342
| | | | | | | Change-Id: Ic117c6a3f9234a0181db1a106ef8a6574248f010 Reviewed-on: http://review.gluster.com/313 Tested-by: Gluster Build System <jenkins@build.gluster.com> Reviewed-by: Amar Tumballi <amar@gluster.com>
* Change Copyright current yearPranith Kumar K2011-08-1013-13/+13
| | | | | | | | Change-Id: I2d10f2be44f518f496427f257988f1858e888084 BUG: 3348 Reviewed-on: http://review.gluster.com/200 Tested-by: Gluster Build System <jenkins@build.gluster.com> Reviewed-by: Anand Avati <avati@gluster.com>
* Provides an upstart job for glusterd on Ubuntu, solving Bug 3282Louis Zuckerman2011-08-032-0/+37
| | | | | | | | | | | | | | | Mounting from localhost in fstab fails at boot on ubuntu when glusterd is started by debian initscript. A new directory, extras/Ubuntu, contains the new upstart job (glusterd.conf) and a brief README.Ubuntu file. This makes the upstart job available to package maintainers like the SysV initscripts are in extras/init.d. This has been tested on Ubuntu 10.10 Maverick. Change-Id: I6ccd06054e920cd6dc45dba4eb8ab89aa30f8b47 BUG: 3282 Reviewed-on: http://review.gluster.com/126 Tested-by: Gluster Build System <jenkins@build.gluster.com> Reviewed-by: Anand Avati <avati@gluster.com>
* extras: Add quota-related debugging scripts.Raghavendra G2011-06-192-0/+90
| | | | | | | | Signed-off-by: Raghavendra G <raghavendra@gluster.com> Signed-off-by: Anand Avati <avati@gluster.com> BUG: 2697 (Quota: add-brick creates the size go awkward, though it was perfect earlier) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2697
* build : use pid file to kill nfs processLakshmipathi2011-06-081-2/+11
| | | | | | | | Signed-off-by: Lakshmipathi.G <lakshmipathi@gluster.com> Signed-off-by: Anand Avati <avati@gluster.com> BUG: 2969 (add --pidfile option) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2969
* gnfs-loganalyse: Track fh & entry operations given filenameShehjar Tikoo2011-05-111-14/+138
| | | | | | | | | | | | Introduces support for outputting only those NFS operations that operate on a given filename and all the filehandles that are seen in the log file for that filename. Signed-off-by: Shehjar Tikoo <shehjart@gluster.com> Signed-off-by: Anand Avati <avati@gluster.com> BUG: 913 (NFS-specific log analyzer tool) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=913
* add 'logrotate' config file to the packageAmar Tumballi2011-05-042-1/+31
| | | | | | | | Signed-off-by: Amar Tumballi <amar@gluster.com> Signed-off-by: Anand Avati <avati@gluster.com> BUG: 2053 (We need to support the standard *nix 'logrotate' for server and client log files.) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2053
* extras/quota-xattr-cleanup: don't follow symbolic links.Raghavendra G2011-04-161-2/+2
| | | | | | | | Signed-off-by: Raghavendra G <raghavendra@gluster.com> Signed-off-by: Anand Avati <avati@gluster.com> BUG: 2664 (Quota: recreating the volume on same bricks shows similar info as for earlier one using "list") URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2664
* script: fix the typo while doing replace brickRaghavendra Bhat2011-04-131-1/+1
| | | | | | | | Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com> Signed-off-by: Anand Avati <avati@gluster.com> BUG: 1436 (script for running basic gluster commands) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1436
* extras: scripts to cleanup xattrs stored by quota.Raghavendra G2011-04-073-1/+49
| | | | | | | | Signed-off-by: Raghavendra G <raghavendra@gluster.com> Signed-off-by: Vijay Bellur <vijay@gluster.com> BUG: 2664 (Quota: recreating the volume on same bricks shows similar info as for earlier one using "list") URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2664
* install gluster binaries under /opt/glusterfs/version with sym.link at /usr/binLakshmipathi G2011-02-221-0/+7
| | | | | | | | Signed-off-by: Lakshmipathi G <lakshmipathi@gluster.com> Signed-off-by: Anand V. Avati <avati@dev.gluster.com> BUG: 2279 (rpm spec file changes) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2279
* removed some of the stale scriptsAmar Tumballi2011-02-106-1129/+2
| | | | | | | | Signed-off-by: Amar Tumballi <amar@gluster.com> Signed-off-by: Anand V. Avati <avati@dev.gluster.com> BUG: 2393 ('gluster-volgen' and 'gluster-defrag' scripts are stale, but present in AMI) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2393
* rpc-coverage.sh: Make error messages explicit.Sachidananda2010-11-251-101/+88
| | | | | | | | | | | Make failure explicit, with `set -e' script exits silently and we have no way to know where it failed unless run by set -x. Signed-off-by: Sachidananda Urs <sac@gluster.com> Signed-off-by: Anand V. Avati <avati@dev.gluster.com> BUG: 875 (Implement a new protocol to provide proper backward/forward compatibility) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=875
* rpc-coverage.sh: enhancements for more extensive testingAnand Avati2010-11-241-29/+440
| | | | | | | | Signed-off-by: Anand V. Avati <avati@blackhole.gluster.com> Signed-off-by: Anand V. Avati <avati@dev.gluster.com> BUG: 875 (Implement a new protocol to provide proper backward/forward compatibility) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=875
* glusterd test-script change in add/remove-brick syntaxPranith K2010-11-091-4/+4
| | | | | | | | Signed-off-by: Pranith Kumar K <pranithk@gluster.com> Signed-off-by: Anand V. Avati <avati@dev.gluster.com> BUG: 1436 () URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1436
* script for testing glusterd sanityRaghavendra Bhat2010-10-283-4/+98
| | | | | | | | Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com> Signed-off-by: Anand V. Avati <avati@dev.gluster.com> BUG: 1436 () URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1436
* Remove libglusterfsclient option from gld-dm benchmarking toolshishir gowda2010-10-271-229/+0
| | | | | | | | Signed-off-by: shishir gowda <shishirng@gluster.com> Signed-off-by: Anand V. Avati <avati@dev.gluster.com> BUG: 968 (gluster client encountered out of memory very quickly when running glfs-bm) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=968
* added a test script to test rpc proceduresAmar Tumballi2010-10-271-0/+83
| | | | | | | | Signed-off-by: Amar Tumballi <amar@gluster.com> Signed-off-by: Anand V. Avati <avati@dev.gluster.com> BUG: 875 (Implement a new protocol to provide proper backward/forward compatibility) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=875
* extras: Do not check_config() for glusterd in Debian initVijay Bellur2010-10-261-8/+0
| | | | | | | | Signed-off-by: Vijay Bellur <vijay@gluster.com> Signed-off-by: Anand V. Avati <avati@dev.gluster.com> BUG: 971 (dynamic volume management) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=971
* Copyright changesVijay Bellur2010-10-117-7/+7
| | | | | | | | Signed-off-by: Vijay Bellur <vijay@gluster.com> Signed-off-by: Vijay Bellur <vijay@dev.gluster.com> BUG: 971 (dynamic volume management) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=971
* migrate from port 69* to 24007Amar Tumballi2010-10-081-2/+2
| | | | | | | | Signed-off-by: Amar Tumballi <amar@gluster.com> Signed-off-by: Vijay Bellur <vijay@dev.gluster.com> BUG: 1870 (Change the port from 69* to some other ports.) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1870
* changes for the sanity scriptRaghavendra Bhat2010-10-061-14/+48
| | | | | | | | Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com> Signed-off-by: Vijay Bellur <vijay@dev.gluster.com> BUG: 1436 () URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1436
* init.d: Path not resolved during compilation to actual prefixHarshavardhana2010-10-051-1/+1
| | | | | | | | Signed-off-by: Harshavardhana <harsha@gluster.com> Signed-off-by: Vijay Bellur <vijay@dev.gluster.com> BUG: 1810 (qa 40 glusterd path is hardcoded, won't start by default.) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1810
* /etc/init.d/glusterd (for RPM based distros), fix output formatAmar Tumballi2010-10-041-2/+4
| | | | | | | | | | Thanks to Bernard Li <bernard@vanhpc.org> for the patch Signed-off-by: Amar Tumballi <amar@gluster.com> Signed-off-by: Vijay Bellur <vijay@dev.gluster.com> BUG: 1677 (Fix output formatting for Red Hat init script) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1677
* changes for the gluster sanity scriptRaghavendra Bhat2010-10-011-1/+15
| | | | | | | | Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com> Signed-off-by: Vijay Bellur <vijay@dev.gluster.com> BUG: 1436 () URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1436
* extras: modify run level scripts to support glusterd.Balamurugan Arumugam2010-09-135-38/+33
| | | | | | | | | Signed-off-by: Bala.JA <bala@gluster.com> Signed-off-by: Pavan Vilas Sondur <pavan@gluster.com> Signed-off-by: Vijay Bellur <vijay@dev.gluster.com> BUG: 1589 (Change init.d scripts to include glusterd) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1589
* Man page updatesshishir gowda2010-09-072-1/+2
| | | | | | | | Signed-off-by: shishir gowda <shishirng@gluster.com> Signed-off-by: Vijay Bellur <vijay@dev.gluster.com> BUG: 1529 (need man pages for 'gluster' and 'glusterd') URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1529
* test: changes for the gluster cliPranith Kumar K2010-09-071-5/+1
| | | | | | | | Signed-off-by: Pranith Kumar K <pranithk@gluster.com> Signed-off-by: Vijay Bellur <vijay@dev.gluster.com> BUG: 1436 () URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1436
* Man page entries for glusterdshishir gowda2010-09-062-1/+2
| | | | | | | | Signed-off-by: shishir gowda <shishirng@gluster.com> Signed-off-by: Vijay Bellur <vijay@dev.gluster.com> BUG: 1529 (need man pages for 'gluster' and 'glusterd') URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1529
* exit from the test for the first failure itselfRaghavendra Bhat2010-09-061-2/+23
| | | | | | | | Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com> Signed-off-by: Vijay Bellur <vijay@dev.gluster.com> BUG: 1436 () URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1436
* Man pages for glustershishir gowda2010-09-062-1/+2
| | | | | | | | Signed-off-by: shishir gowda <shishirng@gluster.com> Signed-off-by: Vijay Bellur <vijay@dev.gluster.com> BUG: 1529 (need man pages for 'gluster' and 'glusterd') URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1529
* change the shell to bash form shRaghavendra Bhat2010-08-271-1/+1
| | | | | Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com> Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
* glusterd: handle failure of 'getspec' in case of '-' in volume nameAmar Tumballi2010-08-261-1/+1
| | | | | | | | Signed-off-by: Amar Tumballi <amar@gluster.com> Signed-off-by: Anand V. Avati <avati@dev.gluster.com> BUG: 1433 () URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1433
* script for testing basic gluster commandsRaghavendra Bhat2010-08-261-0/+173
| | | | | | | | Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com> Signed-off-by: Anand V. Avati <avati@dev.gluster.com> BUG: 1436 () URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1436
* generate separate volume files for nfs in case of 'portmapper' modeAmar Tumballi2010-08-212-26/+142
| | | | | | | | Signed-off-by: Amar Tumballi <amar@gluster.com> Signed-off-by: Anand V. Avati <avati@dev.gluster.com> BUG: 1319 (gnfs support in gluster command line) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1319
* volgen: generate listen port in server for portmap modev3.1.0qa6Vijay Bellur2010-08-161-0/+1
| | | | | | | | Signed-off-by: Vijay Bellur <vijay@gluster.com> Signed-off-by: Anand V. Avati <avati@dev.gluster.com> BUG: 1375 () URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1375
* mgmt/glusterd: cli: Various fixes for replace brick.Pavan Sondur2010-08-161-0/+2
| | | | | | | | Signed-off-by: Pavan Vilas Sondur <pavan@gluster.com> Signed-off-by: Anand V. Avati <avati@dev.gluster.com> BUG: 1304 (Free state info for replace brick) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1304
* new option to volgen '--portmapper-mode'Amar Tumballi2010-08-152-31/+272
| | | | | | | | | | | | | * without which, it generates volume files in old fashioned way. * with portmapper mode, no port option is taken, and there will be one process per one export. * corresponding changes in 'mgmt/glusterd' is made Signed-off-by: Amar Tumballi <amar@gluster.com> Signed-off-by: Anand V. Avati <avati@dev.gluster.com> BUG: 1341 (glusterfs-volgen should behave differently for flag '--internal') URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1341
* client changes for 'gluster volume migration' to workAmar Tumballi2010-08-121-1/+16
| | | | | | | | | Signed-off-by: Amar Tumballi <amar@gluster.com> Signed-off-by: Pavan Vilas Sondur <pavan@gluster.com> Signed-off-by: Anand V. Avati <avati@dev.gluster.com> BUG: 1303 (Cleanup replace-brick state info) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1303