summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* xlator: fix for the volume set help crashv3.3beta2v3.3.0qa9v3.3.0qa8Raghavendra Bhat2011-08-231-0/+2
| | | | | | | | Change-Id: I1649ed61b13b935d714ca024e6883f3903c5edeb BUG: 3460 Reviewed-on: http://review.gluster.com/310 Tested-by: Gluster Build System <jenkins@build.gluster.com> Reviewed-by: Amar Tumballi <amar@gluster.com>
* performance/stat-prefetch: fix memory leakRaghavendra G2011-08-231-1/+8
| | | | | | | | Change-Id: I84580e297ba93a9a093c2e3432ea52e3c0db4a1a BUG: 3467 Reviewed-on: http://review.gluster.com/307 Tested-by: Gluster Build System <jenkins@build.gluster.com> Reviewed-by: Vijay Bellur <vijay@gluster.com>
* cluster/distribute: unwind the proper dict in getxattr_cbkAmar Tumballi2011-08-231-1/+4
| | | | | | | | | | without which, quota would get confused about the total size Change-Id: I0fb822ee67e3c1585f783ae35292fe71c47ee249 BUG: 3421 Reviewed-on: http://review.gluster.com/304 Tested-by: Gluster Build System <jenkins@build.gluster.com> Reviewed-by: Vijay Bellur <vijay@gluster.com>
* features/marker-quota: Fix invalid reads in readdir_cbk.v3.3.0qa7Junaid2011-08-221-8/+24
| | | | | | | | Change-Id: Icc1e9dc039f1f2d7ee94c689779a715a69d373fa BUG: 3389 Reviewed-on: http://review.gluster.com/296 Tested-by: Gluster Build System <jenkins@build.gluster.com> Reviewed-by: Vijay Bellur <vijay@gluster.com>
* mgmt/glusterd: Initialize local variable in volgenVijay Bellur2011-08-222-2/+3
| | | | | | | | Change-Id: I84b4f7c9c2787334ce67e5c3e0534953b691c8e0 BUG: 3460 Reviewed-on: http://review.gluster.com/295 Tested-by: Gluster Build System <jenkins@build.gluster.com> Reviewed-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
* cluster/afr: Perform flush on all the children involved in self-healPranith Kumar K2011-08-221-19/+6
| | | | | | | | Change-Id: I66362a3087a635fb7b759d7836a1f6564a6a7fc9 BUG: 3456 Reviewed-on: http://review.gluster.com/294 Tested-by: Gluster Build System <jenkins@build.gluster.com> Reviewed-by: Vijay Bellur <vijay@gluster.com>
* cluster/afr: Change definition of stale childPranith Kumar K2011-08-221-1/+1
| | | | | | | | | | | | The code is checking for priv->child_up[i], which can change while the fop is in progress. Since pending[child][id-of-transaction] alone is enough to tell if the child became stale or not, use just that. Change-Id: I494bf02cca66f4fd41526195fafce86a202c6bd1 BUG: 3455 Reviewed-on: http://review.gluster.com/293 Tested-by: Gluster Build System <jenkins@build.gluster.com> Reviewed-by: Vijay Bellur <vijay@gluster.com>
* cluster/afr: Paused fop should not continue with fopPranith Kumar K2011-08-223-3/+11
| | | | | | | | Change-Id: Idce22a6266c354e327d5d717715d2e62533eec58 BUG: 3448 Reviewed-on: http://review.gluster.com/292 Tested-by: Gluster Build System <jenkins@build.gluster.com> Reviewed-by: Vijay Bellur <vijay@gluster.com>
* features/marker: changes in marker to avoid race conditions and corruptionsv3.3.0qa6Raghavendra Bhat2011-08-214-61/+217
| | | | | | | | Change-Id: I38ddfab200d59dd4c8e9f9dd964a98f3d7aa7ab7 BUG: 3389 Reviewed-on: http://review.gluster.com/289 Tested-by: Gluster Build System <jenkins@build.gluster.com> Reviewed-by: Vijay Bellur <vijay@gluster.com>
* protocol/client: Changes to be benign to replace-brickVijay Bellur2011-08-211-5/+5
| | | | | | | | Change-Id: Ic227781760a5f6dbf8aad69a19f90e45d4aaec13 BUG: 3415 Reviewed-on: http://review.gluster.com/288 Reviewed-by: Krishnan Parthasarathi <kp@gluster.com> Tested-by: Gluster Build System <jenkins@build.gluster.com>
* debug/io-stats: Handle loglevel in initVijay Bellur2011-08-211-0/+8
| | | | | | | | Change-Id: I5aa6ee7509a8f730ca64e2f7bada56d502785a6c BUG: 3415 Reviewed-on: http://review.gluster.com/287 Reviewed-by: Raghavendra Bhat <raghavendrabhat@gluster.com> Tested-by: Gluster Build System <jenkins@build.gluster.com>
* glusterd: replace-brick status was not 'shared' with peer.v3.3.0qa5Krishnan Parthasarathi2011-08-213-76/+297
| | | | | | | | Change-Id: Ia2d89fd919b077232a37debc2aebe1bc72150856 BUG: 3432 Reviewed-on: http://review.gluster.com/285 Tested-by: Gluster Build System <jenkins@build.gluster.com> Reviewed-by: Vijay Bellur <vijay@gluster.com>
* cluster/afr: fop should not continue if it is paused, until resumesPranith Kumar K2011-08-212-0/+8
| | | | | | | | | Change-Id: Ie026ebed98cf5ff75ae1a13437d29f67d0e0254a BUG: 3448 Reviewed-on: http://review.gluster.com/286 Tested-by: Gluster Build System <jenkins@build.gluster.com> Reviewed-by: Raghavendra Bhat <raghavendrabhat@gluster.com> Reviewed-by: Vijay Bellur <vijay@gluster.com>
* debug/io-stats: Handle log-level properly.Vijay Bellur2011-08-211-0/+8
| | | | | | | | Change-Id: I8e5b8841705b161068bdb2ccd2ac119d6b250c88 BUG: 3415 Reviewed-on: http://review.gluster.com/284 Reviewed-by: Raghavendra Bhat <raghavendrabhat@gluster.com> Tested-by: Gluster Build System <jenkins@build.gluster.com>
* cluster/afr: set frame localPranith Kumar K2011-08-212-1/+2
| | | | | | | | | Change-Id: I861b3c4494735b0ba6e038cdc39c50b9866747a8 BUG: 3448 Reviewed-on: http://review.gluster.com/283 Reviewed-by: Raghavendra Bhat <raghavendrabhat@gluster.com> Tested-by: Gluster Build System <jenkins@build.gluster.com> Reviewed-by: Vijay Bellur <vijay@gluster.com>
* rpc/xdr: Fix for Solaris build failurev3.3.0qa4Vijay Bellur2011-08-201-0/+1
| | | | | | | | Change-Id: I4704dfad655a79afb87ab275ba09413f785a97a4 BUG: 3446 Reviewed-on: http://review.gluster.com/280 Tested-by: Gluster Build System <jenkins@build.gluster.com> Reviewed-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
* cluster/afr: Perform self-heal without locking the whole filePranith Kumar K2011-08-2020-1727/+1582
| | | | | | | | Change-Id: I206571c77f2d7b3c9f9d7bb82a936366fd99ce5c BUG: 3182 Reviewed-on: http://review.gluster.com/141 Tested-by: Gluster Build System <jenkins@build.gluster.com> Reviewed-by: Vijay Bellur <vijay@gluster.com>
* mgmt/glusterd: Correct generation of nfs options in volfileVijay Bellur2011-08-201-16/+28
| | | | | | | | Change-Id: If3db4f81215271072030d7119081de5d8b1b3d78 BUG: 3414 Reviewed-on: http://review.gluster.com/279 Reviewed-by: Raghavendra Bhat <raghavendrabhat@gluster.com> Tested-by: Gluster Build System <jenkins@build.gluster.com>
* while validating options, make sure memory accounting is init()ed.Amar Tumballi2011-08-201-0/+9
| | | | | | | | Change-Id: Ifad5827c6b022de7d84e081ce77effda0c245a13 BUG: 3415 Reviewed-on: http://review.gluster.com/277 Tested-by: Gluster Build System <jenkins@build.gluster.com> Reviewed-by: Vijay Bellur <vijay@gluster.com>
* if nfs.port is not configured init the transport.socket.listen-port to ↵krishna2011-08-201-1/+5
| | | | | | | | | | GF_NFS3_PORT Change-Id: I6c0db600ba2010b0a0272f58b16c4955b4b570f2 BUG: 3308 Reviewed-on: http://review.gluster.com/273 Reviewed-by: Vijay Bellur <vijay@gluster.com> Tested-by: Gluster Build System <jenkins@build.gluster.com>
* xlators/nfs: Fix a typo in option descriptionVijay Bellur2011-08-201-2/+2
| | | | | | | | Change-Id: I626893fd16094742869d4abfa488b66924c2796e BUG: 3445 Reviewed-on: http://review.gluster.com/276 Tested-by: Gluster Build System <jenkins@build.gluster.com> Reviewed-by: Vijay Bellur <vijay@gluster.com>
* libglusterfs: Fix a crash in gluster volume set helpVijay Bellur2011-08-202-1/+9
| | | | | | | | Change-Id: I585e8e685f5c23b6fa632ef708adf2e349ba6704 BUG: 3415 Reviewed-on: http://review.gluster.com/274 Reviewed-by: Raghavendra Bhat <raghavendrabhat@gluster.com> Tested-by: Gluster Build System <jenkins@build.gluster.com>
* cli: remove bogus assertionCsaba Henk2011-08-191-5/+0
| | | | | | | | | | | | | | | | Since 86c818a9 (cli: taking my revenge ...) we cannot assert an exact match for the op/subop keywords in the followup parser functions. That is, # gluster vol stat foo is a valid invocation. Change-Id: I3f7f410f64f440744141f458886e4bba8ceeca17 BUG: 3439 Reviewed-on: http://review.gluster.com/268 Tested-by: Gluster Build System <jenkins@build.gluster.com> Reviewed-by: Vijay Bellur <vijay@gluster.com>
* cluster/afr: Update fresh_children in lookup if no other ops in progressPranith Kumar K2011-08-199-115/+236
| | | | | | | | | | | | | If write/truncate fails we should remove the child that failed the fop from the fresh children. The previous code assumes that the children that succeeded the fop are fresh children, which is wrong. Fixed that in this patch. Change-Id: I1e6e21e20faea00516a0fdd2e95f2d7e9cf9076d BUG: 3411 Reviewed-on: http://review.gluster.com/263 Tested-by: Gluster Build System <jenkins@build.gluster.com> Reviewed-by: Vijay Bellur <vijay@gluster.com>
* options handling: remove missing options check in reconfigureAnand Avati2011-08-191-2/+0
| | | | | | | | | | last minute change broke things. undo'ing damage. Change-Id: I330cf819b03e09f80d609d580d8b4c3497a98bbf BUG: 3415 Reviewed-on: http://review.gluster.com/271 Reviewed-by: Amar Tumballi <amar@gluster.com> Tested-by: Gluster Build System <jenkins@build.gluster.com>
* smoke-test.sh: script used by gerrit as part of pre-commit testAnand Avati2011-08-191-0/+83
| | | | | | | | Change-Id: Idc3be3e22cca5fc623b27c2f500f59785cbd332b BUG: 3234 Reviewed-on: http://review.gluster.com/262 Tested-by: Gluster Build System <jenkins@build.gluster.com> Reviewed-by: Anand Avati <avati@gluster.com>
* option validation: further fixesAnand Avati2011-08-194-5/+22
| | | | | | | | | | fixes in option handling changes Change-Id: I0a44cdb088e3f08cd43d583a580736d0903fa88c BUG: 3415 Reviewed-on: http://review.gluster.com/261 Tested-by: Gluster Build System <jenkins@build.gluster.com> Reviewed-by: Anand Avati <avati@gluster.com>
* mgmt/glusterd, cli: Introduce gluster volume status <volname>Vijay Bellur2011-08-1918-111/+828
| | | | | | | | Change-Id: Iea835b9e448e736016da2e44e3c9bfff93f2fa78 BUG: 3439 Reviewed-on: http://review.gluster.com/259 Tested-by: Gluster Build System <jenkins@build.gluster.com> Reviewed-by: Anand Avati <avati@gluster.com>
* xlator options: revamp xlator option validation/reconfigure codeAnand Avati2011-08-1825-3826/+1668
| | | | | | | | | | | | | | | | | - move option handling to options.c (new file) - remove duplication of option validation code - remove duplication of gf_log / sprintf - get rid of xlator_t->validate_options - get rid of option validation in rpc-transport - get rid of validate_options() in every xlator - use xlator_volume_option_get to clean up many functions - introduce primitives to init/reconfigure option types Change-Id: I51798af72c8dc0a2b9e017424036eb3667dfc7ff BUG: 3415 Reviewed-on: http://review.gluster.com/235 Tested-by: Gluster Build System <jenkins@build.gluster.com> Reviewed-by: Anand Avati <avati@gluster.com>
* do rpcsvc_init() after we fill nfs_state structure and add to nfsx->options ↵v3.3.0qa3krishna2011-08-181-11/+10
| | | | | | | | | | keys for allowing insecure client ports. Change-Id: Iae755d1460f2c7296fc7980b5257afcf778e7767 BUG: 3296 Reviewed-on: http://review.gluster.com/247 Tested-by: Gluster Build System <jenkins@build.gluster.com> Reviewed-by: Vijay Bellur <vijay@gluster.com>
* rpc-clnt: fix merge error of http://review.gluster.com/248Anand Avati2011-08-171-2/+6
| | | | | | | | | | | cherrypicked patch did not have the logic to reset port number to reconnect to glusterd. Change-Id: I78c903d5a28626f83b5024bd323e77b5f159e374 BUG: 3409 Reviewed-on: http://review.gluster.com/254 Reviewed-by: Amar Tumballi <amar@gluster.com> Tested-by: Gluster Build System <jenkins@build.gluster.com>
* glusterd: fix for volume stop causing inconsistent volume statusKaushal M2011-08-172-7/+10
| | | | | | | | | | | | | This fixes problem caused by race between glusterd and glusterfsd occuring when they try to unlink pidfile during volume stop, which led to the volume being stopped, but the status of the volume remained in started state. Change-Id: Ia99bb1a1fc6c78db138211538dfd10c577e82917 BUG: 3147 Reviewed-on: http://review.gluster.com/206 Tested-by: Gluster Build System <jenkins@build.gluster.com> Reviewed-by: Vijay Bellur <vijay@gluster.com>
* rpc-clnt: perform XDR encoding in unlocked regionAnand Avati2011-08-171-41/+36
| | | | | | | | Change-Id: Ia11c3ced4bec5959a5f0d8fcd4c6070b2ead220a BUG: 3409 Reviewed-on: http://review.gluster.com/248 Tested-by: Gluster Build System <jenkins@build.gluster.com> Reviewed-by: Anand Avati <avati@gluster.com>
* allocate extra bytes (for \0) when calling reallocVenky Shankar2011-08-171-1/+2
| | | | | | | | | | | | We use strcat to concat pathinfo strings. strcat appends a \0 at the end. Therefore allocate extra bytes for the same to avoid asserts being hit during gf_free call Change-Id: I582f5858e7375a5bacfc5c702c612ee09c3bb355 BUG: 3413 Reviewed-on: http://review.gluster.com/249 Tested-by: Gluster Build System <jenkins@build.gluster.com> Reviewed-by: Amar Tumballi <amar@gluster.com>
* Revert "Make sure glusterd and glusterfsd use the same address family"Anand Avati2011-08-171-52/+0
| | | | | | | | | | | This reverts commit 1dade36a6dfc6cae5559d5139f6b733e1b6fded1 This commit breaks glusterd. The insertion of --xlator-option=<transport family> in between --brick-port and <port> fails command line validation during glusterfsd start. Change-Id: I40186ca89d1d16cf798404747771353b1f1a3e1d Reviewed-on: http://review.gluster.com/251 Tested-by: Gluster Build System <jenkins@build.gluster.com> Reviewed-by: Anand Avati <avati@gluster.com>
* Revert "Remove white spaces"Anand Avati2011-08-171-4/+4
| | | | | | | | | | | This reverts commit 6ab425e4f3d34b1467f694ada9a36eacfac9bf3c Dependency revert for http://review.gluster.com/229 Change-Id: I7c4fcc45a6c25aedf4f06cbdeedc1fecbe424f45 Reviewed-on: http://review.gluster.com/250 Tested-by: Gluster Build System <jenkins@build.gluster.com> Reviewed-by: Anand Avati <avati@gluster.com>
* do not init nfs->override_portnum to GF_NFS3_PORTkrishna2011-08-171-1/+0
| | | | | | | | Change-Id: I7dc26b64a177ce5d30352cf7c531f38517c0368a BUG: 3308 Reviewed-on: http://review.gluster.com/155 Tested-by: Gluster Build System <jenkins@build.gluster.com> Reviewed-by: Shehjar Tikoo <shehjart@gluster.com>
* Remove white spacesEmmanuel Dreyfus2011-08-161-4/+4
| | | | | | | | Change-Id: I646c0c8e70268de6a20bb23dc3834ac6f5d2bbf2 BUG: 3422 Reviewed-on: http://review.gluster.com/245 Tested-by: Gluster Build System <jenkins@build.gluster.com> Reviewed-by: Anand Avati <avati@gluster.com>
* Make sure glusterd and glusterfsd use the same address familyEmmanuel Dreyfus2011-08-161-0/+52
| | | | | | | | | | | NB: This was heavily tested on 3.2.2, but code has changed a lot in the area. This patch itself is untested. Change-Id: Ie472f04b0804276c2d8a9efc5c96106c33029498 BUG: 3422 Reviewed-on: http://review.gluster.com/229 Tested-by: Gluster Build System <jenkins@build.gluster.com> Reviewed-by: Anand Avati <avati@gluster.com>
* adjust allocated length to memory overrun fixVenky Shankar2011-08-151-3/+4
| | | | | | | | | | | size of the allocated length is incorrectly calculated which could cause memory overrun while filling the buffer Change-Id: I4fbdbd1fff937ca15bae9f634ef5757dda52caa8 BUG: 3413 Reviewed-on: http://review.gluster.com/236 Tested-by: Gluster Build System <jenkins@build.gluster.com> Reviewed-by: Anand Avati <avati@gluster.com>
* cluster/afr: read_child should be >= 0v3.3.0qa2Pranith Kumar K2011-08-131-1/+3
| | | | | | | | Change-Id: I447fb6a93cdd77de322cd5ded30673411c4cf79e BUG: 3251 Reviewed-on: http://review.gluster.com/233 Reviewed-by: Vijay Bellur <vijay@gluster.com> Tested-by: Gluster Build System <jenkins@build.gluster.com>
* - Use linkat(2) instead of link(2) so that linking to symlink work onEmmanuel Dreyfus2011-08-122-0/+25
| | | | | | | | | | | non Linux systems - Also use mkfifo to create FIFO on NetBSD: it does not wotk with mknod Change-Id: I19ffd22b4d79009ef5f9d4a50fc6dd556c3c3ff4 BUG: 2923 Reviewed-on: http://review.gluster.com/226 Tested-by: Gluster Build System <jenkins@build.gluster.com> Reviewed-by: Anand Avati <avati@gluster.com>
* POSIXly correct: \n replacement is GNU sed specificEmmanuel Dreyfus2011-08-121-1/+1
| | | | | | | Change-Id: I5e4ca551b60477d454964e568209ad06f21cc64e Reviewed-on: http://review.gluster.com/227 Tested-by: Gluster Build System <jenkins@build.gluster.com> Reviewed-by: Anand Avati <avati@gluster.com>
* Allow georeplication for NetBSDEmmanuel Dreyfus2011-08-121-0/+3
| | | | | | | | Change-Id: Id8d62f4f83255c67a5aa615aed23ba44c182290e BUG: 2923 Reviewed-on: http://review.gluster.com/220 Tested-by: Gluster Build System <jenkins@build.gluster.com> Reviewed-by: Anand Avati <avati@gluster.com>
* Build fix for NetBSDEmmanuel Dreyfus2011-08-121-1/+13
| | | | | | | | Change-Id: Icb0163d61bfbd3bad520c06a655f80ec05fc3fb2 BUG: 2923 Reviewed-on: http://review.gluster.com/214 Tested-by: Gluster Build System <jenkins@build.gluster.com> Reviewed-by: Anand Avati <avati@gluster.com>
* Build fixEmmanuel Dreyfus2011-08-121-0/+1
| | | | | | | | Change-Id: I10dca7aee73df31f8b279591852d6ac19eab8ccc BUG: 2923 Reviewed-on: http://review.gluster.com/228 Tested-by: Gluster Build System <jenkins@build.gluster.com> Reviewed-by: Anand Avati <avati@gluster.com>
* For systems where O_DIRECTORY does not exist, we defined it as 0,Emmanuel Dreyfus2011-08-121-1/+1
| | | | | | | | | | | therefore ((flags & O_DIRECTORY) == O_DIRECTORY) is always true even if the flag is not set. Change-Id: Ie7837d521ea20b36ed70cf93c1763c226ff0e9f0 BUG: 2923 Reviewed-on: http://review.gluster.com/213 Tested-by: Gluster Build System <jenkins@build.gluster.com> Reviewed-by: Anand Avati <avati@gluster.com>
* Do not distribute UFS1 extended attribute backing storeEmmanuel Dreyfus2011-08-121-0/+14
| | | | | | | | Change-Id: Ie05751aa8d96a2f7996843a914e1a66df2777eba BUG: 2923 Reviewed-on: http://review.gluster.com/222 Tested-by: Gluster Build System <jenkins@build.gluster.com> Reviewed-by: Anand Avati <avati@gluster.com>
* One more missing change :-/Emmanuel Dreyfus2011-08-121-1/+1
| | | | | | | Change-Id: I6eeaee73e7c9124a1959acb2fe47d5cad3a3baac Reviewed-on: http://review.gluster.com/225 Tested-by: Gluster Build System <jenkins@build.gluster.com> Reviewed-by: Anand Avati <avati@gluster.com>
* Use bourne shell, fix error in previous commitEmmanuel Dreyfus2011-08-121-8/+8
| | | | | | | Change-Id: Id2a304d5090eb2564c5d56ea260fa53b9b17d0d5 Reviewed-on: http://review.gluster.com/223 Tested-by: Gluster Build System <jenkins@build.gluster.com> Reviewed-by: Anand Avati <avati@gluster.com>