summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* do not access the empty loc inodev3.2.0qa9Raghavendra Bhat2011-04-071-2/+2
| | | | | | | | Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com> Signed-off-by: Vijay Bellur <vijay@gluster.com> BUG: 2611 ([glusterfs-3.1.0-qa5]: crash in quota_rename) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2611
* removed reference to GF_LOG_NORMALAmar Tumballi2011-04-0742-287/+286
| | | | | | | | | | instead used GF_LOG_INFO, which is more standard log level. Signed-off-by: Amar Tumballi <amar@gluster.com> Signed-off-by: Vijay Bellur <vijay@gluster.com> BUG: 2669 (RuntimeError: cannot recognize log level "normal") URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2669
* do not change the arguments of a functionRaghavendra Bhat2011-04-071-9/+8
| | | | | | | | Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com> Signed-off-by: Vijay Bellur <vijay@gluster.com> BUG: 2685 (nfs server crashed in quota_check_limit) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2685
* features/marker: Perform quota updation on rmdir and unlink by holding ↵Junaid2011-04-071-30/+134
| | | | | | | | | | inodelk on parent. Signed-off-by: Junaid <junaid@gluster.com> Signed-off-by: Vijay Bellur <vijay@gluster.com> BUG: 2664 (Quota: recreating the volume on same bricks shows similar info as for earlier one using "list") URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2664
* debug/io-stats: Fix races and performance issues in profilePranith Kumar K2011-04-071-148/+115
| | | | | | | | | | | Fix the race in update_latency and memset of interval stats. Update fop hits and latencies only when both the options are set. Signed-off-by: Pranith Kumar K <pranithk@gluster.com> Signed-off-by: Vijay Bellur <vijay@gluster.com> BUG: 2636 ("profile info" lists 'nan' in latency when heavy i/o is running) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2636
* mgmt/glusterd: Fix gluster-profile performance issuesPranith Kumar K2011-04-072-3/+4
| | | | | | | | | | | Add count-fop-hits option to io-stats use count-fop-hits instead of dump-fd-stats for profile Signed-off-by: Pranith Kumar K <pranithk@gluster.com> Signed-off-by: Vijay Bellur <vijay@gluster.com> BUG: 2636 ("profile info" lists 'nan' in latency when heavy i/o is running) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2636
* extras: scripts to cleanup xattrs stored by quota.Raghavendra G2011-04-073-1/+49
| | | | | | | | Signed-off-by: Raghavendra G <raghavendra@gluster.com> Signed-off-by: Vijay Bellur <vijay@gluster.com> BUG: 2664 (Quota: recreating the volume on same bricks shows similar info as for earlier one using "list") URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2664
* features/marker: Check for NULL before dereferencing pointers stored in local.Junaid2011-04-071-2/+5
| | | | | | | | Signed-off-by: Junaid <junaid@gluster.com> Signed-off-by: Vijay Bellur <vijay@gluster.com> BUG: 2607 (Fileop fails when quota is enabled) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2607
* print the gfid of the inode for which dentry is not foundRaghavendra Bhat2011-04-071-2/+2
| | | | | | | | Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com> Signed-off-by: Vijay Bellur <vijay@gluster.com> BUG: 2652 ([glusterfs-3.2.0qa6]: dbench keeps on running) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2652
* mgmt/glusterd: Reset context upon operation completionVijay Bellur2011-04-071-12/+33
| | | | | | | Signed-off-by: Vijay Bellur <vijay@gluster.com> BUG: 2650 (replace brick failed in distributed-replicated setup) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2650
* features/marker: Check if gsync is enabled in getxattr fop before performing ↵Junaid2011-04-071-2/+8
| | | | | | | | | | gsync related operations. Signed-off-by: Junaid <junaid@gluster.com> Signed-off-by: Vijay Bellur <vijay@gluster.com> BUG: 2681 (marker returns dummy data for volume-mark attribute if xtime is switched off) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2681
* check buf for NULL before accessing itv3.2.0qa8Raghavendra Bhat2011-04-061-1/+2
| | | | | | | | Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com> Signed-off-by: Vijay Bellur <vijay@gluster.com> BUG: 2675 ([glusterfs-3.2.0qa7]: glusterfs client crashed) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2675
* check dict before unrefing itRaghavendra Bhat2011-04-061-1/+1
| | | | | | | | Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com> Signed-off-by: Vijay Bellur <vijay@gluster.com> BUG: 2642 ([glusterfs-3.2.0qa5]: invalid reads in glusterd) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2642
* nfs: convert errno EDQUOT into appropriate nfs-errno.Raghavendra G2011-04-061-0/+4
| | | | | | | | Signed-off-by: Raghavendra G <raghavendra@gluster.com> Signed-off-by: Vijay Bellur <vijay@gluster.com> BUG: 2607 (Fileop fails when quota is enabled) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2607
* protocol/client: Avoid logging when EAGAIN is received for *lk requestsVijay Bellur2011-04-061-5/+5
| | | | | | | Signed-off-by: Vijay Bellur <vijay@gluster.com> BUG: 1887 (logging mess) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1887
* change occurrences of marker_gsync to marker-gsyncVijay Bellur2011-04-062-5/+5
| | | | | | | Signed-off-by: Vijay Bellur <vijay@gluster.com> BUG: 2473 (Support for volume and directory level quota) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2473
* features/marker, cli: use appropriate conversion specifiers.Raghavendra G2011-04-062-7/+12
| | | | | | | | Signed-off-by: Raghavendra G <raghavendra@gluster.com> Signed-off-by: Vijay Bellur <vijay@gluster.com> BUG: 2649 (Quota: size field is not getting updated properly) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2649
* protocol/client: make sure to send only genuine events up to parentAmar Tumballi2011-04-063-36/+48
| | | | | | | | | | | | that way parent notify logic is fine. also, remove 'xlator_notify()' call in code, instead use 'default_notify()' Signed-off-by: Amar Tumballi <amar@gluster.com> Signed-off-by: Vijay Bellur <vijay@gluster.com> BUG: 2584 (Inode number changes on a directory when one of subvolumes is down in replicate) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2584
* NFS : Store verifier for exlusive mode craete.Gaurav2011-04-061-6/+17
| | | | | | | | Signed-off-by: Gaurav <gaurav@gluster.com> Signed-off-by: Vijay Bellur <vijay@gluster.com> BUG: 2553 (NFS file create with Mac client and UNCHECKED mode returns "Operation not permitted") URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2553
* cluster/dht: send back the proper inode number in the cbk functionsAmar Tumballi2011-04-061-2/+4
| | | | | | | | Signed-off-by: Amar Tumballi <amar@gluster.com> Signed-off-by: Vijay Bellur <vijay@gluster.com> BUG: 2584 (Inode number changes on a directory when one of subvolumes is down in replicate) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2584
* cluster/dht: log level fixes in lookup* functionsAmar Tumballi2011-04-061-21/+20
| | | | | | | | Signed-off-by: Amar Tumballi <amar@gluster.com> Signed-off-by: Vijay Bellur <vijay@gluster.com> BUG: 2346 (Log message enhancements in GlusterFS - phase 1) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2346
* log gfid mismatches for the same file in cluster xlator lookupAmar Tumballi2011-04-064-2/+33
| | | | | | | | | | | | This can help in pin pointing some of the issues resulted in gfid mismatch for the same file, which is harder to find through basic debugging/logging of current codebase. Signed-off-by: Amar Tumballi <amar@gluster.com> Signed-off-by: Vijay Bellur <vijay@gluster.com> BUG: 2346 () URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2346
* cluster/afr: log enhancements - part 1Amar Tumballi2011-04-067-585/+568
| | | | | | | | Signed-off-by: Amar Tumballi <amar@gluster.com> Signed-off-by: Vijay Bellur <vijay@shell.gluster.com> BUG: 2346 () URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2346
* features/quota: use a double pointer to uint64_t as an argument to ↵Raghavendra G2011-04-051-2/+2
| | | | | | | | | | dict_get_bin while getting size. Signed-off-by: Raghavendra G <raghavendra@gluster.com> Signed-off-by: Vijay Bellur <vijay@dev.gluster.com> BUG: 2604 (Quota: crossing the set limit) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2604
* features/quota: add NULL check before doing strcasecmpRaghavendra G2011-04-051-1/+1
| | | | | | | | Signed-off-by: Raghavendra G <raghavendra@gluster.com> Signed-off-by: Vijay Bellur <vijay@dev.gluster.com> BUG: 2646 (glusterfs-client crashes during getxattr) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2646
* syncdaemon: refine intermal configuration of gsyncdv3.2.0qa7Csaba Henk2011-04-042-37/+121
| | | | | | | | Signed-off-by: Csaba Henk <csaba@gluster.com> Signed-off-by: Vijay Bellur <vijay@dev.gluster.com> BUG: 2561 (gsyncd command's must be preconfigured) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2561
* syncdaemon: add monitor mode to support autorestartCsaba Henk2011-04-047-41/+174
| | | | | | | | Signed-off-by: Csaba Henk <csaba@gluster.com> Signed-off-by: Vijay Bellur <vijay@dev.gluster.com> BUG: 2537 (gsync autorestart) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2537
* syncdaemon: provide transactional semantics to config file writingCsaba Henk2011-04-042-13/+49
| | | | | | | | | | | | So updating the config file from multiple contexts won't mess it up. This prepares the next commit where we'll set options internaly (which lacks the serial nature of user actions). Signed-off-by: Csaba Henk <csaba@gluster.com> Signed-off-by: Vijay Bellur <vijay@dev.gluster.com> BUG: 2537 (gsync autorestart) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2537
* syncdaemon: give some refactoring to cascading codeCsaba Henk2011-04-042-84/+116
| | | | | | | | | | | | | | | | | | | | | | | - expiry check of foreign volinfo moved back to GLUSTERServer, so that under the hood we can removexattr the expired ones; a nice side-effect is that we can use the same dict layout for foreign and native volinfo (ie., foreign needs no timeout field) - get_volinfo() is renamed to get_sys_volinfo() and most of the logic is stripped off of it (what remained there is the check against foreign master ambiguity) - volinfo transition logic is cut out to an almost purely functional static method (only impurity is the exeption raised upon forbidden volinfo change) - ping renamed to keep-alive, as something called "ping" is not supposed to have payload (yeah, keep-alive is a bit fishy on this front too, but could not come up with better...) Signed-off-by: Csaba Henk <csaba@gluster.com> Signed-off-by: Vijay Bellur <vijay@dev.gluster.com> BUG: 2535 (gsync cascading) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2535
* syncdaemon; adding corresponding pcloses to gsyncd invocation via popenCsaba Henk2011-04-012-16/+20
| | | | | | | | Signed-off-by: Csaba Henk <csaba@gluster.com> Signed-off-by: Vijay Bellur <vijay@dev.gluster.com> BUG: 2427 (set a proper default for remote syncdaemon) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2427
* syncdaemon: fix up fallback xtime value for slaveCsaba Henk2011-04-011-1/+1
| | | | | | | | Signed-off-by: Csaba Henk <csaba@gluster.com> Signed-off-by: Vijay Bellur <vijay@dev.gluster.com> BUG: 2535 (gsync cascading) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2535
* debug/io-stats: Fix bugs in re-configure optionsPranith Kumar K2011-04-011-62/+43
| | | | | | | | | | | | If the options are not present in vol file reset the option values. If there is an invalid option log an error and continue, no need to exit Signed-off-by: Pranith Kumar K <pranithk@gluster.com> Signed-off-by: Vijay Bellur <vijay@dev.gluster.com> BUG: 2638 () URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2638
* Replace strdup call to gf_strdup as GF_FREE is being calledshishir gowda2011-04-012-3/+3
| | | | | | | | | | Also, fix validation of bs and count to <= 0. Signed-off-by: shishir gowda <shishirng@gluster.com> Signed-off-by: Vijay Bellur <vijay@dev.gluster.com> BUG: 2645 (volume top write-perf results in memory corruption) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2645
* cluster/afr: log enhancement - part 3Amar Tumballi2011-04-016-316/+139
| | | | | | | | Signed-off-by: Amar Tumballi <amar@gluster.com> Signed-off-by: Vijay Bellur <vijay@dev.gluster.com> BUG: 2346 (Log message enhancements in GlusterFS - phase 1) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2346
* cluster/afr: log enhancement - part 2Amar Tumballi2011-04-012-190/+215
| | | | | | | | Signed-off-by: Amar Tumballi <amar@gluster.com> Signed-off-by: Vijay Bellur <vijay@dev.gluster.com> BUG: 2346 (Log message enhancements in GlusterFS - phase 1) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2346
* nfs: capture attrs of create request in cs->stbuf for later useAnand Avati2011-04-011-1/+1
| | | | | | | | | | | | | | | | | | when attrs coming in as part of create request contain modes other than mode, they were getting discarded previously and a setattr was getting performed on a 0-filled iatt structure. This would result in EPERM at the access control translator as non-root users cannot chown a file to uid 0. Not seen with Linux NFS client as it (very likely) relies upon auth-unix to set the ownership of the file or sends an explicit setattr after the create. Signed-off-by: Anand Avati <avati@gluster.com> Signed-off-by: Vijay Bellur <vijay@dev.gluster.com> BUG: 2553 (NFS file create with Mac client and UNCHECKED mode returns "Operation not permitted") URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2553
* syncdaemon: fix gsyncd invocation for config-setCsaba Henk2011-03-311-1/+1
| | | | | | | | Signed-off-by: Csaba Henk <csaba@gluster.com> Signed-off-by: Vijay Bellur <vijay@dev.gluster.com> BUG: 2555 () URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2555
* syncdaemon: minor cleanups in cascading codeCsaba Henk2011-03-311-7/+1
| | | | | | | | Signed-off-by: Csaba Henk <csaba@gluster.com> Signed-off-by: Vijay Bellur <vijay@dev.gluster.com> BUG: 2535 (gsync cascading) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2535
* Revert "Process dir/link from other subvol if error in dht_readdir"Vijay Bellur2011-03-311-17/+4
| | | | This reverts commit cd3d977b10e24c4b46e55f9831113aba3a241583.
* TOP: Improve output formatv3.2.0qa6shishir gowda2011-03-311-2/+2
| | | | | | | | Signed-off-by: shishir gowda <shishirng@gluster.com> Signed-off-by: Vijay Bellur <vijay@dev.gluster.com> BUG: 2614 () URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2614
* TOP: Validate command optionsshishir gowda2011-03-313-7/+45
| | | | | | | | Signed-off-by: shishir gowda <shishirng@gluster.com> Signed-off-by: Vijay Bellur <vijay@dev.gluster.com> BUG: 2628 () URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2628
* TOP: handle list-cnt behaviour uniformly.shishir gowda2011-03-313-14/+28
| | | | | | | | | | | Valid range is 0-100. if list-cnt is 0 or there are no files in the list, handle it uniformly. Signed-off-by: shishir gowda <shishirng@gluster.com> Signed-off-by: Vijay Bellur <vijay@dev.gluster.com> BUG: 2622 () URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2622
* features/quota: Use appropriate inodes while logging and create contexts in ↵Junaid2011-03-312-131/+144
| | | | | | | | | | | | inode for files. - It also fixes limit checks if limit set in the directory. Signed-off-by: Junaid <junaid@gluster.com> Signed-off-by: Vijay Bellur <vijay@dev.gluster.com> BUG: 2604 (Quota: crossing the set limit) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2604
* features/marker: Fix memory corruption.Junaid2011-03-315-17/+24
| | | | | | | | Signed-off-by: Junaid <junaid@gluster.com> Signed-off-by: Vijay Bellur <vijay@dev.gluster.com> BUG: 2629 () URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2629
* mgmt/glusterd: Delete volume profile options on profile stopPranith Kumar K2011-03-311-72/+50
| | | | | | | | Signed-off-by: Pranith Kumar K <pranithk@gluster.com> Signed-off-by: Vijay Bellur <vijay@dev.gluster.com> BUG: 2638 () URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2638
* mgmt/glusterd: Improve profile output messagesPranith Kumar K2011-03-311-47/+49
| | | | | | | | Signed-off-by: Pranith Kumar K <pranithk@gluster.com> Signed-off-by: Vijay Bellur <vijay@dev.gluster.com> BUG: 2616 () URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2616
* cli: Improve profile output messagesPranith Kumar K2011-03-311-12/+36
| | | | | | | | Signed-off-by: Pranith Kumar K <pranithk@gluster.com> Signed-off-by: Vijay Bellur <vijay@dev.gluster.com> BUG: 2616 () URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2616
* syncdaemon: fix "--debug" option of gsyncd.pyCsaba Henk2011-03-311-3/+8
| | | | | | | | | | | also be explicit about logging to a stream (ie. don't rely on the feature of accessing stdin through /dev/stdin) Signed-off-by: Csaba Henk <csaba@gluster.com> Signed-off-by: Vijay Bellur <vijay@dev.gluster.com> BUG: 2637 (gsyncd --debug broken) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2637
* mgmt/glusterd: Fix space in error messagePranith Kumar K2011-03-311-1/+1
| | | | | | | | Signed-off-by: Pranith Kumar K <pranithk@gluster.com> Signed-off-by: Vijay Bellur <vijay@dev.gluster.com> BUG: 2623 () URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2623
* mgmt/glusterd: Mark the brick stopped when kill -SIGTERM is donePranith Kumar K2011-03-312-0/+2
| | | | | | | | Signed-off-by: Pranith Kumar K <pranithk@gluster.com> Signed-off-by: Vijay Bellur <vijay@dev.gluster.com> BUG: 2621 () URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2621