diff options
| -rw-r--r-- | glusterfsd/src/glusterfsd-mgmt.c | 60 | ||||
| -rw-r--r-- | glusterfsd/src/glusterfsd.c | 14 | ||||
| -rw-r--r-- | libglusterfs/src/glusterfs.h | 1 | ||||
| -rw-r--r-- | xlators/mgmt/glusterd/src/glusterd-store.c | 12 | ||||
| -rw-r--r-- | xlators/mgmt/glusterd/src/glusterd-store.h | 1 | ||||
| -rw-r--r-- | xlators/mgmt/glusterd/src/glusterd-utils.c | 29 | ||||
| -rw-r--r-- | xlators/mgmt/glusterd/src/glusterd.h | 1 | ||||
| -rw-r--r-- | xlators/protocol/client/src/client-handshake.c | 21 | ||||
| -rw-r--r-- | xlators/protocol/client/src/client.h | 3 | 
9 files changed, 135 insertions, 7 deletions
diff --git a/glusterfsd/src/glusterfsd-mgmt.c b/glusterfsd/src/glusterfsd-mgmt.c index 1e10056ac..ef9afaf23 100644 --- a/glusterfsd/src/glusterfsd-mgmt.c +++ b/glusterfsd/src/glusterfsd-mgmt.c @@ -899,12 +899,51 @@ out:  }  static int +mgmt_pmap_signin2_cbk (struct rpc_req *req, struct iovec *iov, int count, +                       void *myframe) +{ +        pmap_signin_rsp  rsp   = {0,}; +        call_frame_t    *frame = NULL; +        int              ret   = 0; + +        frame = myframe; + +        if (-1 == req->rpc_status) { +                rsp.op_ret   = -1; +                rsp.op_errno = EINVAL; +                goto out; +        } + +        ret = xdr_to_pmap_signin_rsp (*iov, &rsp); +        if (ret < 0) { +                gf_log (frame->this->name, GF_LOG_ERROR, "XDR decode error"); +                rsp.op_ret   = -1; +                rsp.op_errno = EINVAL; +                goto out; +        } + +        if (-1 == rsp.op_ret) { +                gf_log (frame->this->name, GF_LOG_ERROR, +                        "failed to register the port with glusterd"); +                goto out; +        } +out: +        STACK_DESTROY (frame->root); +        return 0; + +} + +static int  mgmt_pmap_signin_cbk (struct rpc_req *req, struct iovec *iov, int count,                        void *myframe)  {          pmap_signin_rsp  rsp   = {0,};          call_frame_t    *frame = NULL;          int              ret   = 0; +        pmap_signin_req  pmap_req = {0, }; +        cmd_args_t      *cmd_args = NULL; +        glusterfs_ctx_t *ctx      = NULL; +        char             brick_name[PATH_MAX] = {0,};          frame = myframe; @@ -927,6 +966,27 @@ mgmt_pmap_signin_cbk (struct rpc_req *req, struct iovec *iov, int count,                          "failed to register the port with glusterd");                  goto out;          } + +        ctx = glusterfs_ctx_get (); +        cmd_args = &ctx->cmd_args; + +        if (!cmd_args->brick_port2) { +                /* We are done with signin process */ +                goto out; +        } + +        snprintf (brick_name, PATH_MAX, "%s.rdma", cmd_args->brick_name); +        pmap_req.port  = cmd_args->brick_port2; +        pmap_req.brick = brick_name; + +        ret = mgmt_submit_request (&pmap_req, frame, ctx, &clnt_pmap_prog, +                                   GF_PMAP_SIGNIN, xdr_from_pmap_signin_req, +                                   mgmt_pmap_signin2_cbk); +        if (ret) +                goto out; + +        return 0; +  out:          STACK_DESTROY (frame->root); diff --git a/glusterfsd/src/glusterfsd.c b/glusterfsd/src/glusterfsd.c index 9406d74ac..9a39570d7 100644 --- a/glusterfsd/src/glusterfsd.c +++ b/glusterfsd/src/glusterfsd.c @@ -453,6 +453,8 @@ parse_opts (int key, char *arg, struct argp_state *state)          gf_boolean_t  b             = _gf_false;          char         *pwd           = NULL;          char          tmp_buf[2048] = {0,}; +        char         *tmp_str       = NULL; +        char         *port_str      = NULL;          cmd_args = state->input; @@ -671,8 +673,18 @@ parse_opts (int key, char *arg, struct argp_state *state)          case ARGP_BRICK_PORT_KEY:                  n = 0; -                if (gf_string2uint_base10 (arg, &n) == 0) { +                port_str = strtok_r (arg, ",", &tmp_str); +                if (gf_string2uint_base10 (port_str, &n) == 0) {                          cmd_args->brick_port = n; +                        port_str = strtok_r (NULL, ",", &tmp_str); +                        if (port_str) { +                                if (gf_string2uint_base10 (port_str, &n) == 0) +                                        cmd_args->brick_port2 = n; +                                break; + +                                argp_failure (state, -1, 0, +                                              "wrong brick (listen) port %s", arg); +                        }                          break;                  } diff --git a/libglusterfs/src/glusterfs.h b/libglusterfs/src/glusterfs.h index 56b5e2b9c..72f481147 100644 --- a/libglusterfs/src/glusterfs.h +++ b/libglusterfs/src/glusterfs.h @@ -297,6 +297,7 @@ struct _cmd_args {          /* required for portmap */          int             brick_port;          char           *brick_name; +        int             brick_port2;  };  typedef struct _cmd_args cmd_args_t; diff --git a/xlators/mgmt/glusterd/src/glusterd-store.c b/xlators/mgmt/glusterd/src/glusterd-store.c index 4f296c52a..bd932b26a 100644 --- a/xlators/mgmt/glusterd/src/glusterd-store.c +++ b/xlators/mgmt/glusterd/src/glusterd-store.c @@ -284,6 +284,10 @@ glusterd_store_brickinfo_write (int fd, glusterd_brickinfo_t *brickinfo)          ret = glusterd_store_save_value (fd, GLUSTERD_STORE_KEY_BRICK_PORT,                                           value); +        snprintf (value, sizeof(value), "%d", brickinfo->rdma_port); +        ret = glusterd_store_save_value (fd, GLUSTERD_STORE_KEY_BRICK_RDMA_PORT, +                                         value); +  out:          gf_log ("", GF_LOG_DEBUG, "Returning %d", ret);          return ret; @@ -1413,6 +1417,14 @@ glusterd_store_retrieve_bricks (glusterd_volinfo_t *volinfo)                                  pmap = pmap_registry_get (THIS);                                  if (pmap->last_alloc <= brickinfo->port)                                          pmap->last_alloc = brickinfo->port + 1; +                        } else if (!strncmp (key, GLUSTERD_STORE_KEY_BRICK_RDMA_PORT, +                                    strlen (GLUSTERD_STORE_KEY_BRICK_RDMA_PORT))) { +                                gf_string2int (value, &brickinfo->rdma_port); +                                /* This is required to have proper ports +                                   assigned to bricks after restart */ +                                pmap = pmap_registry_get (THIS); +                                if (pmap->last_alloc <= brickinfo->rdma_port) +                                        pmap->last_alloc = brickinfo->rdma_port + 1;                          } else {                                  gf_log ("", GF_LOG_ERROR, "Unknown key: %s",                                          key); diff --git a/xlators/mgmt/glusterd/src/glusterd-store.h b/xlators/mgmt/glusterd/src/glusterd-store.h index 0403c10f9..ad9ca6a95 100644 --- a/xlators/mgmt/glusterd/src/glusterd-store.h +++ b/xlators/mgmt/glusterd/src/glusterd-store.h @@ -58,6 +58,7 @@ typedef enum glusterd_store_ver_ac_{  #define GLUSTERD_STORE_KEY_BRICK_HOSTNAME "hostname"  #define GLUSTERD_STORE_KEY_BRICK_PATH     "path"  #define GLUSTERD_STORE_KEY_BRICK_PORT     "listen-port" +#define GLUSTERD_STORE_KEY_BRICK_RDMA_PORT "rdma.listen-port"  #define GLUSTERD_STORE_KEY_PEER_UUID      "uuid"  #define GLUSTERD_STORE_KEY_PEER_HOSTNAME  "hostname" diff --git a/xlators/mgmt/glusterd/src/glusterd-utils.c b/xlators/mgmt/glusterd/src/glusterd-utils.c index 8cb8f8f83..e07ce143b 100644 --- a/xlators/mgmt/glusterd/src/glusterd-utils.c +++ b/xlators/mgmt/glusterd/src/glusterd-utils.c @@ -1024,6 +1024,7 @@ glusterd_volume_start_glusterfs (glusterd_volinfo_t  *volinfo,          char                    exp_path[PATH_MAX] = {0,};          char                    logfile[PATH_MAX] = {0,};          int                     port = 0; +        int                     rdma_port = 0;          FILE                    *file = NULL;          gf_boolean_t            is_locked = _gf_false;          char                    socketpath[PATH_MAX] = {0}; @@ -1107,12 +1108,27 @@ glusterd_volume_start_glusterfs (glusterd_volinfo_t  *volinfo,          if (!port)                  port = pmap_registry_alloc (THIS); -        snprintf (cmd_str, 8192, -                  "%s/sbin/glusterfsd --xlator-option %s-server.listen-port=%d " -                  "-s localhost --volfile-id %s -p %s -S %s --brick-name %s " -                  "--brick-port %d -l %s", GFS_PREFIX, volinfo->volname, -                  port, volfile, pidfile, socketpath, brickinfo->path, port, -                  brickinfo->logfile); +        if (volinfo->transport_type != GF_TRANSPORT_BOTH_TCP_RDMA) { +                snprintf (cmd_str, 8192, +                          "%s/sbin/glusterfsd --xlator-option %s-server.listen-port=%d " +                          "-s localhost --volfile-id %s -p %s -S %s --brick-name %s " +                          "--brick-port %d -l %s", GFS_PREFIX, volinfo->volname, +                          port, volfile, pidfile, socketpath, brickinfo->path, port, +                          brickinfo->logfile); +        } else { +                rdma_port = brickinfo->rdma_port; +                if (!rdma_port) +                        rdma_port = pmap_registry_alloc (THIS); + +                snprintf (cmd_str, 8192, +                          "%s/sbin/glusterfsd --xlator-option %s-server.listen-port=%d " +                          "--xlator-option %s-server.transport.rdma.listen-port=%d -s localhost " +                          "--volfile-id %s -p %s -S %s --brick-name %s " +                          "--brick-port %d,%d -l %s", GFS_PREFIX, volinfo->volname, +                          port, volinfo->volname, rdma_port, volfile, pidfile, +                          socketpath, brickinfo->path, port, rdma_port, +                          brickinfo->logfile); +        }  	gf_log ("",GF_LOG_DEBUG,"Starting GlusterFS Command Executed: \n %s \n", cmd_str);          ret = gf_system (cmd_str); @@ -1120,6 +1136,7 @@ glusterd_volume_start_glusterfs (glusterd_volinfo_t  *volinfo,          if (ret == 0) {                  //pmap_registry_bind (THIS, port, brickinfo->path);                  brickinfo->port = port; +                brickinfo->rdma_port = rdma_port;          }  connect: diff --git a/xlators/mgmt/glusterd/src/glusterd.h b/xlators/mgmt/glusterd/src/glusterd.h index 9c90af2e2..8a14b20e4 100644 --- a/xlators/mgmt/glusterd/src/glusterd.h +++ b/xlators/mgmt/glusterd/src/glusterd.h @@ -121,6 +121,7 @@ struct glusterd_brickinfo {          struct list_head  brick_list;          uuid_t  uuid;          int     port; +        int     rdma_port;          char   *logfile;          gf_boolean_t signed_in;          glusterd_store_handle_t *shandle; diff --git a/xlators/protocol/client/src/client-handshake.c b/xlators/protocol/client/src/client-handshake.c index 5af149d56..583fb9483 100644 --- a/xlators/protocol/client/src/client-handshake.c +++ b/xlators/protocol/client/src/client-handshake.c @@ -918,6 +918,8 @@ client_setvolume_cbk (struct rpc_req *req, struct iovec *iov, int count, void *m          conf->connecting = 0;          conf->connected = 1; +        conf->need_different_port = 0; +          /* TODO: more to test */          client_post_handshake (frame, frame->this); @@ -1193,6 +1195,8 @@ client_query_portmap (xlator_t *this, struct rpc_clnt *rpc)          clnt_conf_t             *conf            = NULL;          dict_t                  *options         = NULL;          char                    *remote_subvol   = NULL; +        char                    *xprt            = NULL; +        char                     brick_name[PATH_MAX] = {0,};          options = this->options;          conf    = this->private; @@ -1206,6 +1210,23 @@ client_query_portmap (xlator_t *this, struct rpc_clnt *rpc)          req.brick = remote_subvol; +        /* FIXME: Dirty work around */ +        if (!dict_get_str (options, "transport-type", &xprt)) { +                /* This logic is required only in case of 'rdma' client +                   transport-type and the volume is of 'tcp,rdma' +                   transport type. */ +                if (!strcmp (xprt, "rdma")) { +                        if (!conf->need_different_port) { +                                snprintf (brick_name, PATH_MAX, "%s.rdma", +                                          remote_subvol); +                                req.brick = brick_name; +                                conf->need_different_port = 1; +                        } else { +                                conf->need_different_port = 0; +                        } +                } +        } +          fr  = create_frame (this, this->ctx->pool);          if (!fr) {                  ret = -1; diff --git a/xlators/protocol/client/src/client.h b/xlators/protocol/client/src/client.h index 40a3d5d3d..96080ef61 100644 --- a/xlators/protocol/client/src/client.h +++ b/xlators/protocol/client/src/client.h @@ -66,6 +66,9 @@ typedef struct clnt_conf {                                                     which was sent earlier */          char                   portmap_err_logged; /* flag used to prevent                                                        excessive logging */ +        char                   need_different_port; /* flag used to change the +                                                       portmap path in case of +                                                       'tcp,rdma' on server */  } clnt_conf_t;  typedef struct _client_fd_ctx {  | 
