diff options
| author | Raghavendra Bhat <raghavendrabhat@gluster.com> | 2011-10-27 23:13:43 +0530 |
|---|---|---|
| committer | Vijay Bellur <vijay@gluster.com> | 2011-10-28 04:14:56 -0700 |
| commit | b9d94056e555c2386cee3344db23518a47970a97 (patch) | |
| tree | 09013709517fd550301c1847db2181324ad0ac63 /xlators/features | |
| parent | 3b0eecb53f3a061016d277f862d54e15d2646bd6 (diff) | |
check the return value of inode_path for less than or equal to zero
Change-Id: I9bbdfe79664c1339b66819a6c7ea4b7698beb5c6
BUG: 3757
Reviewed-on: http://review.gluster.com/640
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amar@gluster.com>
Diffstat (limited to 'xlators/features')
| -rw-r--r-- | xlators/features/locks/src/inodelk.c | 4 | ||||
| -rw-r--r-- | xlators/features/marker/src/marker-quota-helper.c | 2 | ||||
| -rw-r--r-- | xlators/features/marker/src/marker.c | 2 | ||||
| -rw-r--r-- | xlators/features/quota/src/quota.c | 4 |
4 files changed, 6 insertions, 6 deletions
diff --git a/xlators/features/locks/src/inodelk.c b/xlators/features/locks/src/inodelk.c index 6fa9f3997..a122d54eb 100644 --- a/xlators/features/locks/src/inodelk.c +++ b/xlators/features/locks/src/inodelk.c @@ -392,7 +392,7 @@ release_inode_locks_of_transport (xlator_t *this, pl_dom_list_t *dom, list_del_init (&l->blocked_locks); - if (inode_path (inode, NULL, &path) < 0) { + if (inode_path (inode, NULL, &path) <= 0) { gf_log (this->name, GF_LOG_TRACE, "inode_path failed"); goto unlock; @@ -420,7 +420,7 @@ release_inode_locks_of_transport (xlator_t *this, pl_dom_list_t *dom, __destroy_inode_lock (l); - if (inode_path (inode, NULL, &path) < 0) { + if (inode_path (inode, NULL, &path) <= 0) { gf_log (this->name, GF_LOG_TRACE, "inode_path failed"); goto unlock; diff --git a/xlators/features/marker/src/marker-quota-helper.c b/xlators/features/marker/src/marker-quota-helper.c index 10746254d..0295b489e 100644 --- a/xlators/features/marker/src/marker-quota-helper.c +++ b/xlators/features/marker/src/marker-quota-helper.c @@ -94,7 +94,7 @@ mq_inode_loc_fill (const char *parent_gfid, inode_t *inode, loc_t *loc) ignore_parent: ret = inode_path (inode, NULL, &resolvedpath); - if (ret < 0) + if (ret <= 0) goto err; ret = mq_loc_fill (loc, inode, parent, resolvedpath); diff --git a/xlators/features/marker/src/marker.c b/xlators/features/marker/src/marker.c index 050da8879..f597309e4 100644 --- a/xlators/features/marker/src/marker.c +++ b/xlators/features/marker/src/marker.c @@ -113,7 +113,7 @@ marker_inode_loc_fill (inode_t *inode, loc_t *loc) ignore_parent: ret = inode_path (inode, NULL, &resolvedpath); - if (ret < 0) + if (ret <= 0) goto err; ret = marker_loc_fill (loc, inode, parent, resolvedpath); diff --git a/xlators/features/quota/src/quota.c b/xlators/features/quota/src/quota.c index bfadba8cf..3b6cfb62c 100644 --- a/xlators/features/quota/src/quota.c +++ b/xlators/features/quota/src/quota.c @@ -96,7 +96,7 @@ quota_inode_loc_fill (inode_t *inode, loc_t *loc) ignore_parent: ret = inode_path (inode, NULL, &resolvedpath); - if (ret < 0) { + if (ret <= 0) { gf_log (this->name, GF_LOG_WARNING, "cannot construct path for inode (ino:%"PRId64", " "gfid:%s)", inode->ino, @@ -479,7 +479,7 @@ quota_get_limit_value (inode_t *inode, xlator_t *this, int64_t *n) *n = 0; ret = inode_path (inode, NULL, &path); - if (ret < 0) { + if (ret <= 0) { ret = -1; goto out; } |