summaryrefslogtreecommitdiffstats
path: root/xlators/cluster
diff options
context:
space:
mode:
authorVikas Gorur <vikas@gluster.com>2009-09-08 05:07:02 +0000
committerAnand V. Avati <avati@dev.gluster.com>2009-09-08 04:00:19 -0700
commit1ad5952aaf29585d5349cc636261306ab7701619 (patch)
treefaab3a6f6b8c84641579b35f7d7632e6b415984e /xlators/cluster
parent06a885f70154720da0bcb77199312500998ba29b (diff)
cluster/afr: Check op_ret in afr_getxattr_cbk before accessing dict
Signed-off-by: Anand V. Avati <avati@dev.gluster.com> BUG: 250 (Crash in replicate getxattr) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=250
Diffstat (limited to 'xlators/cluster')
-rw-r--r--xlators/cluster/afr/src/afr-inode-read.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/xlators/cluster/afr/src/afr-inode-read.c b/xlators/cluster/afr/src/afr-inode-read.c
index 2f9a6cda9..203206511 100644
--- a/xlators/cluster/afr/src/afr-inode-read.c
+++ b/xlators/cluster/afr/src/afr-inode-read.c
@@ -642,7 +642,8 @@ afr_getxattr_cbk (call_frame_t *frame, void *cookie,
out:
if (unwind) {
- __filter_xattrs (dict);
+ if (op_ret >= 0 && dict)
+ __filter_xattrs (dict);
AFR_STACK_UNWIND (frame, op_ret, op_errno, dict);
}