path: root/rpc/xdr/
diff options
authorRaghavendra G <>2012-12-18 14:43:27 +0530
committerAnand Avati <>2013-02-05 13:35:16 -0800
commite8d09b9ab9a93367a7135fc6b0e721c9d13e0e2d (patch)
tree442cdb566d590e2284e776eec095e7dfb4e95b54 /rpc/xdr/
parent6763272e7f3fbe8afba948a8afb075b9cf2a5ca7 (diff)
rpcsvc: Fix memory corruption caused by rpcsvc_dump returning non-zero
The convention followed is that any actor should return non-zero value only if it has not attempted to send the reply back. If an actor returns non-zero, rpcsvc_handle_rpc_call tries to send an error reply. Since, rpcsvc_submit_generic frees the rpc_req, its wrong to invoke it more than once on same rpc_req. When the transport is not connected, rpcsvc_dump used to pass the non-zero value it got from transport to rpcsvc resulting in memory corruption. Hence this patch makes rpcsvc_dump to return 0. Change-Id: I1b6f28969ee546c44d193d3d33debccb65585b69 BUG: 903113 Signed-off-by: Raghavendra G <> Reviewed-on: Tested-by: Gluster Build System <> Reviewed-by: Anand Avati <> Reviewed-by: Raghavendra Bhat <> Reviewed-by: Jeff Darcy <>
Diffstat (limited to 'rpc/xdr/')
0 files changed, 0 insertions, 0 deletions