summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAmar Tumballi <amar@gluster.com>2011-09-23 16:19:20 +0530
committerVijay Bellur <vijay@gluster.com>2011-09-23 06:31:23 -0700
commit1b096c3ff0a4c25ff22a32d9594d2e289a3d67ea (patch)
treefc7345a0d41866b71ba14651abec0d4168d2b956
parent1fdcbb61872b0a849490d1f0de4fdb545e2865aa (diff)
glusterd-volgen: prevent a crash when volume type is stripe-replicate
when volgen tries to check for decommissioned nodes, a check for stripe replicate volume was missed Change-Id: Ie3aa97da2ec0d94fcf65f96bb4006b3fb54f59dc BUG: 3616 Reviewed-on: http://review.gluster.com/494 Tested-by: Gluster Build System <jenkins@build.gluster.com> Reviewed-by: Krishnan Parthasarathi <kp@gluster.com>
-rw-r--r--xlators/mgmt/glusterd/src/glusterd-volgen.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/xlators/mgmt/glusterd/src/glusterd-volgen.c b/xlators/mgmt/glusterd/src/glusterd-volgen.c
index 6320bf17e..77478f365 100644
--- a/xlators/mgmt/glusterd/src/glusterd-volgen.c
+++ b/xlators/mgmt/glusterd/src/glusterd-volgen.c
@@ -2013,7 +2013,9 @@ _xl_has_decommissioned_clients (xlator_t *xl, glusterd_volinfo_t *volinfo)
xl_child = xl->children;
while (xl_child) {
cxl = xl_child->xlator;
- decommissioned = _xl_is_client_decommissioned (cxl, volinfo);
+ /* this can go into 2 depths if the volume type
+ is stripe-replicate */
+ decommissioned = _xl_has_decommissioned_clients (cxl, volinfo);
if (decommissioned)
break;