summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorPranith Kumar K <pranithk@gluster.com>2011-08-22 12:14:22 +0530
committerVijay Bellur <vijay@gluster.com>2011-08-22 02:39:03 -0700
commitb9ae4b19da2898fa610d1bfd4b9e5829acabb121 (patch)
tree4a5605b1dc6a47b339023b0807445c22436f842a
parentb249ff7505392ae5cac1421a6a44310800d26feb (diff)
cluster/afr: Change definition of stale child
The code is checking for priv->child_up[i], which can change while the fop is in progress. Since pending[child][id-of-transaction] alone is enough to tell if the child became stale or not, use just that. Change-Id: I494bf02cca66f4fd41526195fafce86a202c6bd1 BUG: 3455 Reviewed-on: http://review.gluster.com/293 Tested-by: Gluster Build System <jenkins@build.gluster.com> Reviewed-by: Vijay Bellur <vijay@gluster.com>
-rw-r--r--xlators/cluster/afr/src/afr-transaction.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/xlators/cluster/afr/src/afr-transaction.c b/xlators/cluster/afr/src/afr-transaction.c
index 6b0e9a7cf..e9b8ee7dc 100644
--- a/xlators/cluster/afr/src/afr-transaction.c
+++ b/xlators/cluster/afr/src/afr-transaction.c
@@ -440,7 +440,7 @@ afr_transaction_rm_stale_children (call_frame_t *frame, xlator_t *this,
if (!afr_is_child_present (fresh_children,
priv->child_count, i))
continue;
- if ((!priv->child_up[i]) || (pending[i][idx] == 0)) {
+ if (pending[i][idx] == 0) {
/* child is down or op failed on it */
rm_stale_children = _gf_true;
afr_children_rm_child (fresh_children, i,