glusterfs-afrv1.git, branch release-3.3

build: really disable fusermount if you say so

2014-03-10T07:32:24+00:00

There is no logic in configure.ac that provides a $disable_fusermount
variable. So, use the $enable_fusermount variable instead.

Backport from:
> Follow-up-for: http://review.gluster.org/4773
> Change-Id: I81cdbd0045409d0036438d542ca6dc1934f784e4
> BUG: 948205
> Signed-off-by: Niels de Vos 
> Reviewed-on: http://review.gluster.org/4803
> Reviewed-by: Kaleb KEITHLEY 
> Reviewed-by: Sachidananda Urs 
> Tested-by: Gluster Build System 

Change-Id: Ie5fa36fa6cf40336e75efbf7fd8527c3ff466e4c
BUG: 1058666
Signed-off-by: Niels de Vos 
Reviewed-on: http://review.gluster.org/6832
Tested-by: Gluster Build System 
Reviewed-by: Justin Clift 
Tested-by: Justin Clift 
Reviewed-by: Vijay Bellur

build: enable fusermount by default

2014-03-10T07:32:04+00:00

The fusermount available in gluster is customized to ensure
mounting with SELinux happens properly, i.e - to have a separate
thread for fuse_thread_proc which can process getxattr requests
and in parallel perform sys_mount() in a different thread, thereby
avoiding a deadlock.

However our build and packaging defaults to not including our
fusermount. This patch reverses the defaults.

Backport from:
> Change-Id: I793af4c2f56aeac46efae3db30e7c64ee7c18850
> BUG: 811217
> Signed-off-by: Anand Avati 
> Reviewed-on: http://review.gluster.org/4773
> Reviewed-by: Jeff Darcy 
> Tested-by: Gluster Build System 

Change-Id: If5fb368b6737fe8b6f22d2f2aa0785baa7f96364
BUG: 1058666
Signed-off-by: Niels de Vos 
Reviewed-on: http://review.gluster.org/6831
Tested-by: Gluster Build System 
Reviewed-by: Justin Clift 
Tested-by: Justin Clift 
Reviewed-by: Vijay Bellur

Do not overwrite swift config files on upgrade

2013-08-28T03:40:14+00:00

We now include the config files as part of the RPM and include
the directive %config(noreplace) in the RPM specfile for
upgrades, installations, and removals.

When the system is now upgraded to this fix number, any of the
config files edited are kept verbatim.  When the system
is upgraded to the gluster-swift project, their config files
are saved as ${configfile}.rpmsave since they will need to
re-inspect the file using the new grizzly settings.

BUG: 1001418

Change-Id: I306501d3148f5f6a1d2ee381a9abd98efccadd00
Signed-off-by: Luis Pabon 
Reviewed-on: http://review.gluster.org/5706
Reviewed-by: Peter Portante 
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

NFS is picking up geo-rep's already open (read-only) file descriptor

2013-07-05T13:31:14+00:00

Add anonymous member to fd_t and use it instead of over-loading pid for
geo-rep and self heal

Change-Id: I4d6b29a044a8ed4b8f69ff6e3f35ee227739b2af
Signed-off-by: Kaleb S. KEITHLEY 
BUG: 874272
Reviewed-on: http://review.gluster.org/4185
Tested-by: Gluster Build System 
Reviewed-by: Raghavendra Bhat 
Reviewed-by: Vijay Bellur 
Reviewed-on: http://review.gluster.org/5283

cluster/afr: detect in-progress creation in lookup and return ENOENT

2013-06-19T05:49:01+00:00

        Port of http://review.gluster.org/4625

if any subvol returned ENOENT while parent entrylk lock was held,
yield and return ENOENT for the entire lookup.

This is how the issue happens:

Multiple clients A, B and C are attempting 'mkdir -p /mnt/a/b/c'

1 Client A is in the middle of mkdir(/a). It has acquired lock.
  It has performed mkdir(/a) on one subvol, and second one is still
  in progress
2 Client B performs a lookup, sees directory /a on one,
  ENOENT on the other, succeeds lookup.
3 Client B performs lookup on /a/b on both subvols, both return ENOENT
  (one subvol because /a/b does not exist, another because /a
  itself does not exist)
4 Client B proceeds to mkdir /a/b. It obtains entrylk on inode=/a with
  basename=b on one subvol, but fails on other subvol as /a is yet to
  be created by Client A.
5 Client A finishes mkdir of /a on other subvol
6 Client C also attempts to create /a/b, lookup returns ENOENT on
  both subvols.
7 Client C tries to obtain entrylk on on inode=/a with basename=b,
  obtains on one subvol (where B had failed), and waits for B to unlock
  on other subvol.
8 Client B finishes mkdir() on one subvol with GFID-1 and completes
  transaction and unlocks
9 Client C gets the lock on the second subvol, At this stage second
  subvol already has /a/b created from Client B, but Client C does not
  check that in the middle of mkdir transaction
10 Client C attempts mkdir /a/b on both subvols. It succeeds on
   ONLY ONE (where Client B could not get lock because of
   missing parent /a dir) with GFID-2, and gets EEXIST from ONE subvol.
This way we have /a/b in GFID mismatch. One subvol got GFID-1 because
Client B performed transaction on only one subvol (because entrylk()
could not be obtained on second subvol because of missing parent dir --
caused by premature/speculative succeeding of lookup() on /a when locks
are detected). Other subvol gets GFID-2 from Client C because while
it was waiting for entrylk() on both subvols, Client B was in the
middle of creating mkdir() on only one subvol, and Client C does not
"expect" this when it is between lock() and pre-op()/op() phase of the
transaction.

Change-Id: I40107d4638ffdcb7b1ff4748c8e5ea92e62697e8
BUG: 860210
Signed-off-by: Pranith Kumar K 
Reviewed-on: http://review.gluster.org/5173
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

cluster/dht: Linkfiles creation with correct uid/gid

2013-05-16T15:49:39+00:00

If renames are done with different uid/gid (non-owners), then we would
end up with incorrect uid/gid.

The fix is to create linkfiles, and heal the uid/gid as root:root. This
preserves our notion of creation as root:root and heal the uid/gid as
root:root in all paths. Additionally, we need to consider uid/gid from
only src_cached subvol, and not from linkfiles.

rename is also done as root:root if done on linkfile, as setattr of ownership
on linkfile is done after the rename

BUG: 884597
Change-Id: Ifaacd8dba0f39cb909761ffc8fe7e06cd44ec8de
Signed-off-by: shishir gowda 
Reviewed-on: http://review.gluster.org/5025
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

cluster/dht: Create linkfile with file uid/gid

2013-05-16T15:47:44+00:00

Currently, linkfile creation happens as root.

use uid/gid returned from _cbk (link/rename) to set the correct ownership of
the link files.

Change-Id: I5345cff193d5095442ca446fbe5ea05f2c2d86a3
Signed-off-by: shishir gowda 
BUG: 884597
Reviewed-on: http://review.gluster.org/5024
Reviewed-by: Vijay Bellur 
Tested-by: Gluster Build System

libglusterfs/statedump: move options file and statedumps from /tmp

2013-05-14T17:47:09+00:00

Change-Id: I6b107b9a668b0521b955dba8895cbbeaf9e7cb02
BUG: 764890
Signed-off-by: Raghavendra Bhat 
Reviewed-on: http://review.gluster.org/5005
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

glusterfs: add gf_mkostemp api and use it instead of mkostemp of libc

2013-05-14T16:02:11+00:00

Change-Id: Ia3d2f37ae1f7a7d87a75c82bedb4963729d45b6c
BUG: 764890
Signed-off-by: Raghavendra Bhat 
Reviewed-on: http://review.gluster.org/5004
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

geo-rep: retire old style ssh setup

2013-04-27T16:36:58+00:00

Users are still using geo-rep with the old, deprecated, insecure, unsupported
ssh setup. Not their fault -- the implementation of the new method had the
following charasteristics:
- old method is possible, but with default settings it's not working
- it can be made operational by fiddling with "remote-gsyncd" tunable
- with default setting, an unhelpful, actually misleading error message is
  produced
- the UI gave no hint to the changes in the ssh setup

http://review.gluster.org/4392 tried to fix these; what it accomplished was
unrestricted support to the bad practice (by making the default old setup
operational).

From this on:
- we disable the old method by reserving the "remote-gsyncd" tunable
- if the old method is attempted, give a hint what to do

Change-Id: Icade94725d8d8d2d4c89cab992d4226351637b86
BUG: 895656
Signed-off-by: Csaba Henk 
Reviewed-on: http://review.gluster.org/4892
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur