diff options
| author | Prashanth Pai <ppai@redhat.com> | 2013-11-22 12:13:09 +0530 |
|---|---|---|
| committer | Luis Pabon <lpabon@redhat.com> | 2013-12-05 09:15:40 -0800 |
| commit | fc9124caf45949dfcc0732536c6825c12d74582a (patch) | |
| tree | ad9871cda75a8c5f08e4a06d88a38836b674c8c5 /test/unit | |
| parent | 0eb79aad3658ca519143029f219c9efe3591e724 (diff) | |
gswauth: Fix 403 being returned instead of 401
- 401(Unauthorized) is to be returned when user credentials are
wrong where as 403(Forbidden) is to be returned when user
credentials are correct but the user doesn't have the priveleges
to carry out the operation.
- Also error messages displayed when using swauth-* command line
utilities have been updated.
Change-Id: I485786896ad14d3263f4325d1857cacc93adab96
Signed-off-by: Prashanth Pai <ppai@redhat.com>
Reviewed-on: http://review.gluster.org/6336
Reviewed-by: Luis Pabon <lpabon@redhat.com>
Tested-by: Luis Pabon <lpabon@redhat.com>
Diffstat (limited to 'test/unit')
| -rw-r--r-- | test/unit/common/middleware/gswauth/swauth/test_middleware.py | 28 |
1 files changed, 14 insertions, 14 deletions
diff --git a/test/unit/common/middleware/gswauth/swauth/test_middleware.py b/test/unit/common/middleware/gswauth/swauth/test_middleware.py index 46d634f..00e6453 100644 --- a/test/unit/common/middleware/gswauth/swauth/test_middleware.py +++ b/test/unit/common/middleware/gswauth/swauth/test_middleware.py @@ -1283,7 +1283,7 @@ class TestAuth(unittest.TestCase): 'super_admin', 'X-Auth-Admin-Key': 'supertest'} ).get_response(self.test_auth) - self.assertEquals(resp.status_int, 403) + self.assertEquals(resp.status_int, 401) resp = Request.blank('/auth/v2/.prep', environ={ 'REQUEST_METHOD': 'POST'}, @@ -1292,25 +1292,25 @@ class TestAuth(unittest.TestCase): '.super_admin', 'X-Auth-Admin-Key': 'upertest'} ).get_response(self.test_auth) - self.assertEquals(resp.status_int, 403) + self.assertEquals(resp.status_int, 401) resp = Request.blank('/auth/v2/.prep', environ={ 'REQUEST_METHOD': 'POST'}, headers={ 'X-Auth-Admin-User': '.super_admin'} ).get_response(self.test_auth) - self.assertEquals(resp.status_int, 403) + self.assertEquals(resp.status_int, 401) resp = Request.blank('/auth/v2/.prep', environ={ 'REQUEST_METHOD': 'POST'}, headers={ 'X-Auth-Admin-Key': 'supertest'} ).get_response(self.test_auth) - self.assertEquals(resp.status_int, 403) + self.assertEquals(resp.status_int, 401) resp = Request.blank( '/auth/v2/.prep', environ={'REQUEST_METHOD': 'POST'}).get_response(self.test_auth) - self.assertEquals(resp.status_int, 403) + self.assertEquals(resp.status_int, 401) def test_prep_fail_account_create(self): self.test_auth.app = FakeApp(iter([ @@ -1420,7 +1420,7 @@ class TestAuth(unittest.TestCase): 'super:admin', 'X-Auth-Admin-Key': 'supertest'} ).get_response(self.test_auth) - self.assertEquals(resp.status_int, 403) + self.assertEquals(resp.status_int, 401) self.assertEquals(self.test_auth.app.calls, 1) self.test_auth.app = FakeApp(iter([ @@ -1594,7 +1594,7 @@ class TestAuth(unittest.TestCase): 'super:admin', 'X-Auth-Admin-Key': 'supertest'} ).get_response(self.test_auth) - self.assertEquals(resp.status_int, 403) + self.assertEquals(resp.status_int, 401) self.assertEquals(self.test_auth.app.calls, 1) self.test_auth.app = FakeApp(iter([ @@ -1809,7 +1809,7 @@ class TestAuth(unittest.TestCase): body=json.dumps( {'storage': {'local': 'new_value'}}) ).get_response(self.test_auth) - self.assertEquals(resp.status_int, 403) + self.assertEquals(resp.status_int, 401) self.assertEquals(self.test_auth.app.calls, 1) self.test_auth.app = FakeApp(iter([ @@ -2042,7 +2042,7 @@ class TestAuth(unittest.TestCase): headers={'X-Auth-Admin-User': 'super:admin', 'X-Auth-Admin-Key': 'supertest'},).get_response( self.test_auth) - self.assertEquals(resp.status_int, 403) + self.assertEquals(resp.status_int, 401) self.assertEquals(self.test_auth.app.calls, 1) self.test_auth.app = FakeApp(iter([ @@ -2387,7 +2387,7 @@ class TestAuth(unittest.TestCase): 'super:admin', 'X-Auth-Admin-Key': 'supertest'}, ).get_response(self.test_auth) - self.assertEquals(resp.status_int, 403) + self.assertEquals(resp.status_int, 401) self.assertEquals(self.test_auth.app.calls, 1) self.test_auth.app = FakeApp(iter([ @@ -2986,7 +2986,7 @@ class TestAuth(unittest.TestCase): 'super:admin', 'X-Auth-Admin-Key': 'supertest'}, ).get_response(self.test_auth) - self.assertEquals(resp.status_int, 403) + self.assertEquals(resp.status_int, 401) self.assertEquals(self.test_auth.app.calls, 1) self.test_auth.app = FakeApp(iter([ @@ -3256,7 +3256,7 @@ class TestAuth(unittest.TestCase): 'key', 'X-Auth-User-Reseller-Admin': 'true'} ).get_response(self.test_auth) - self.assertEquals(resp.status_int, 403) + self.assertEquals(resp.status_int, 401) self.assertEquals(self.test_auth.app.calls, 0) self.test_auth.app = FakeApp(iter([ @@ -3278,7 +3278,7 @@ class TestAuth(unittest.TestCase): 'key', 'X-Auth-User-Reseller-Admin': 'true'} ).get_response(self.test_auth) - self.assertEquals(resp.status_int, 403) + self.assertEquals(resp.status_int, 401) self.assertEquals(self.test_auth.app.calls, 0) self.test_auth.app = FakeApp(iter([ @@ -3299,7 +3299,7 @@ class TestAuth(unittest.TestCase): 'key', 'X-Auth-User-Reseller-Admin': 'true'} ).get_response(self.test_auth) - self.assertEquals(resp.status_int, 403) + self.assertEquals(resp.status_int, 401) self.assertEquals(self.test_auth.app.calls, 0) def test_put_user_account_admin_fail_bad_creds(self): |