diff options
| author | Peter Portante <peter.portante@redhat.com> | 2013-05-23 16:34:24 -0400 |
|---|---|---|
| committer | Luis Pabon <lpabon@redhat.com> | 2013-05-24 12:08:18 -0700 |
| commit | b29164198523591a69b234e869b7a1b94bd4f08e (patch) | |
| tree | 04a3787ea446cdc42d282d5483ad21841c880f70 /test/unit/common/test_diskfile.py | |
| parent | 3ff44850b4b0151b55028d45c8c77a521c478b2c (diff) | |
Add DiskDir unit test skeleton and pep8 filter
The new DiskDir unit test skeleton is quite incomplete, but gets the
DiskDir module on the board for modules covered, explicitly exposing
the fact that we need to get test coverage. This is a first step.
At the same time, we also update all the modules we have applying the
fix for pep8 errors now run under tox. We can then add a Jenkins
pre-commit job to fail on pep8 errors. This brings our code to parity
with what they are doing in OpenStack Swift.
Change-Id: Ia0565606512efda6e73f67bd00269177b89db858
Signed-off-by: Peter Portante <peter.portante@redhat.com>
Reviewed-on: http://review.gluster.org/5080
Reviewed-by: Luis Pabon <lpabon@redhat.com>
Tested-by: Luis Pabon <lpabon@redhat.com>
Diffstat (limited to 'test/unit/common/test_diskfile.py')
| -rw-r--r-- | test/unit/common/test_diskfile.py | 9 |
1 files changed, 0 insertions, 9 deletions
diff --git a/test/unit/common/test_diskfile.py b/test/unit/common/test_diskfile.py index 85d539a..5af661e 100644 --- a/test/unit/common/test_diskfile.py +++ b/test/unit/common/test_diskfile.py @@ -57,9 +57,6 @@ class MockException(Exception): def _mock_rmdirs(p): raise MockException("gluster.swift.common.DiskFile.rmdirs() called") -def _mock_do_listdir(p): - raise MockException("gluster.swift.common.DiskFile.do_listdir() called") - def _mock_do_unlink(f): ose = OSError() ose.errno = errno.ENOENT @@ -575,16 +572,13 @@ class TestDiskFile(unittest.TestCase): "z", self.lg) assert gdf.metadata == {} _saved_rmdirs = gluster.swift.common.DiskFile.rmdirs - _saved_do_listdir = gluster.swift.common.DiskFile.do_listdir gluster.swift.common.DiskFile.rmdirs = _mock_rmdirs - gluster.swift.common.DiskFile.do_listdir = _mock_do_listdir try: gdf.unlinkold(None) except MockException as exp: self.fail(str(exp)) finally: gluster.swift.common.DiskFile.rmdirs = _saved_rmdirs - gluster.swift.common.DiskFile.do_listdir = _saved_do_listdir def test_unlinkold_same_timestamp(self): assert not os.path.exists("/tmp/foo") @@ -593,16 +587,13 @@ class TestDiskFile(unittest.TestCase): assert gdf.metadata == {} gdf.metadata['X-Timestamp'] = 1 _saved_rmdirs = gluster.swift.common.DiskFile.rmdirs - _saved_do_listdir = gluster.swift.common.DiskFile.do_listdir gluster.swift.common.DiskFile.rmdirs = _mock_rmdirs - gluster.swift.common.DiskFile.do_listdir = _mock_do_listdir try: gdf.unlinkold(1) except MockException as exp: self.fail(str(exp)) finally: gluster.swift.common.DiskFile.rmdirs = _saved_rmdirs - gluster.swift.common.DiskFile.do_listdir = _saved_do_listdir def test_unlinkold_file(self): td = tempfile.mkdtemp() |