summaryrefslogtreecommitdiffstats
path: root/gluster/swift/common/DiskFile.py
diff options
context:
space:
mode:
authorMohammed Junaid <junaid@redhat.com>2013-06-25 07:50:28 +0530
committerPeter Portante <pportant@redhat.com>2013-06-27 17:15:45 -0700
commitc7ce3beec168cfc530da9e8d11fc1a0e8c80bcce (patch)
tree79100a6d0bc58a219f2c5784033fb7cff7276db6 /gluster/swift/common/DiskFile.py
parent41b91061436210afd1d22cad3c2ee1e038c23e3c (diff)
object-storage: Use fchown instead of chown.
This is a step towards making fd based system calls where ever possible to avoid path lookups. Signed-off-by: Mohammed Junaid <junaid@redhat.com> Change-Id: I482ea29ebe0859d0a5307ff25ecb5945d54bc7ca Reviewed-on: http://review.gluster.org/5251 Reviewed-by: Peter Portante <pportant@redhat.com> Tested-by: Peter Portante <pportant@redhat.com>
Diffstat (limited to 'gluster/swift/common/DiskFile.py')
-rw-r--r--gluster/swift/common/DiskFile.py4
1 files changed, 2 insertions, 2 deletions
diff --git a/gluster/swift/common/DiskFile.py b/gluster/swift/common/DiskFile.py
index a3f7987..c7138d4 100644
--- a/gluster/swift/common/DiskFile.py
+++ b/gluster/swift/common/DiskFile.py
@@ -22,7 +22,7 @@ from swift.common.utils import renamer
from swift.common.exceptions import DiskFileNotExist
from gluster.swift.common.exceptions import AlreadyExistsAsDir
from gluster.swift.common.fs_utils import mkdirs, rmdirs, do_open, do_close, \
- do_unlink, do_chown, os_path, do_fsync
+ do_unlink, do_chown, os_path, do_fsync, do_fchown
from gluster.swift.common.utils import read_metadata, write_metadata, \
validate_object, create_object_metadata
from gluster.swift.common.utils import X_CONTENT_LENGTH, X_CONTENT_TYPE, \
@@ -234,9 +234,9 @@ class Gluster_DiskFile(DiskFile):
tmp_path = os.path.join(tmp_path, dir_name)
self._create_dir_object(tmp_path)
+ do_fchown(fd, self.uid, self.gid)
newpath = os.path.join(self.datadir, self._obj)
renamer(self.tmppath, newpath)
- do_chown(newpath, self.uid, self.gid)
self.metadata = metadata
self.data_file = newpath
self.filter_metadata()