|author||Kyle Schneider <email@example.com>||2013-07-09 19:57:17 -0400|
|committer||Luis Pabon <firstname.lastname@example.org>||2013-07-09 17:42:21 -0700|
Edited the mechanics of the wording within the document.
Changed all "we" wording to "you," and altered and rearranged some wording to help the document flow better when being read. Change-Id: Idf39eb93666a71e3fda25375080eaae90a23ed52 Signed-off-by: Kyle Schneider <email@example.com> Reviewed-on: http://review.gluster.org/5306 Reviewed-by: Luis Pabon <firstname.lastname@example.org> Tested-by: Luis Pabon <email@example.com>
1 files changed, 8 insertions, 8 deletions
diff --git a/doc/markdown/dev_guide.md b/doc/markdown/dev_guide.md
index 52dcf01..3547643 100644
@@ -24,7 +24,7 @@ cd gluster-swift
### Git Review
The tool `git review` is a simple tool to automate interaction with Gerrit.
-We recommend using this tool to upload, modify, and query changes in Gerrit.
+It is recommended to use this tool to upload, modify, and query changes in Gerrit.
The tool can be installed by running the following command:
@@ -35,16 +35,16 @@ Note that while many distros offer a version of `git review`, they don't
necessarily keep it up to date. Pip gives one the latest which
often avoids problems with various Gerrit servers.
-We now need to setup `git review` to communicate with review.gluster.org.
-First, let's determine our `git review` setup by typing:
+You now need to setup `git review` to communicate with review.gluster.org.
+First, determine your `git review` setup by typing:
git review -s
If there is no output, then everything is setup correctly. If the output
-contains the string *We don't know where your gerrit is*, then we need
-a setup a remote repo with the name `gerrit`. We can inspect the current
+contains the string *We don't know where your gerrit is*, then you need to
+setup a remote repo with the name `gerrit`. You can inspect the current
remote repo's by typing the following command.
@@ -148,14 +148,14 @@ For more information on commit messages, please visit the
[Git Commit Messages] page in OpenStack.org.
### Uploading to Gerrit
-Once you have the changes ready for review, you can submit it to Gerrit
-simply by typing:
+Once you have the changes ready for review, you can submit it to Gerrit
-After the change is reviewed, most likely you may have to make some
+After the change is reviewed, you might have to make some
additional modifications to your change. To continue the work for
a specific change, you can query Gerrit for the change number by